Re: [PATCH] Cure some compilation warnings

2005-01-03 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Try it out. If it works I am ok with it (with a comment) > | OK, I am going to commit the following, then. ok -- Lgb

Re: [PATCH] Cure some compilation warnings

2005-01-03 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Try it out. If it works I am ok with it (with a comment) OK, I am going to commit the following, then. JMarc Index: src/frontends/xforms//ChangeLog === RCS file:

Re: [PATCH] Cure some compilation warnings

2005-01-03 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Try (void)var; > | Lars> in the body of the funxtion > | That would work indeed. Shall I do it? Try it out. If it works I am ok with it (with a comment) -- Lgb

Re: [PATCH] Cure some compilation warnings

2005-01-03 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Try (void)var; Lars> in the body of the funxtion That would work indeed. Shall I do it? JMarc

Re: [PATCH] Cure some compilation warnings

2004-12-30 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: 6>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > | Georg> There is, but it is gcc specific: Place > | Georg> __attribute__((unused)) > | Georg> after the parameter. I don't know if other compilers support | Georg> similar things. > | Than

Re: [PATCH] Cure some compilation warnings

2004-12-29 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> There is, but it is gcc specific: Place Georg> __attribute__((unused)) Georg> after the parameter. I don't know if other compilers support Georg> similar things. Thanks. That's probably not worth the effort in this case... JMarc

Re: [PATCH] Cure some compilation warnings

2004-12-29 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > That's a pretty good reason. So there is no way to avoid these > warnings, right? That's pretty stupid... There is, but it is gcc specific: Place __attribute__((unused)) after the parameter. I don't know if other compilers support similar things. Georg

Re: [PATCH] Cure some compilation warnings

2004-12-29 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: >> In C++, I would define the parameter as "void * /*xev*/" and be >> done with it. Is there a reason why this is not done in .c files? >> Are there portability concerns? Angus> Try it. gcc will refuse to compile it. That's a pretty good

Re: [PATCH] Cure some compilation warnings

2004-12-28 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > There are still some unused parameters in the xforms .c files like: > > ../../../../lyx-devel/src/frontends/xforms/bmtable.c: In function > `handle_bitmap table': > ../../../../lyx-devel/src/frontends/xforms/bmtable.c:170: warning: unused > parame ter `xev' > > In C+

[PATCH] Cure some compilation warnings

2004-12-28 Thread Jean-Marc Lasgouttes
The following patch gets rid of a few unused variables, probably leftovers of big code changes. It is pretty straightforward, except that it may ring a bell in someone's mind (as in "but we _should_ be using this!"). Also, this remove bogus initialisations of a XpmAttribute struct. There are sti