Re: [PATCH] CT 18

2006-05-31 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> Jean-Marc Lasgouttes wrote: >> They look good, although the repetition makes me wonder whether you >> should declare a Changes(BufferParams const &) constructor. >> >> Michael> Depending on the context, tracking_changes == true

Re: [PATCH] CT 18

2006-05-30 Thread Michael Gerz
Jean-Marc Lasgouttes wrote: They look good, although the repetition makes me wonder whether you should declare a Changes(BufferParams const &) constructor. Depending on the context, tracking_changes == true results in either DELETED or INSERTED. Thus, the proposed constructor wouldn't work.

Re: [PATCH] CT 18

2006-05-29 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> This time, I fixed a few calls to Paragraph::insertChar. Michael> Depending on the buffer's parameter, the character is Michael> inserted as UNCHANGED or INSERTED. They look good, although the repetition makes me wonder whether

[PATCH] CT 18

2006-05-29 Thread Michael Gerz
It's me again :-) This time, I fixed a few calls to Paragraph::insertChar. Depending on the buffer's parameter, the character is inserted as UNCHANGED or INSERTED. Please let me know if something looks suspicious. There are more similar places, which I will fix in the next couple of days (st