Re: [PATCH] Bump RC format for commit 214f7ed2

2014-03-19 Thread Scott Kostyshak
On Wed, Mar 19, 2014 at 6:33 PM, Richard Heck wrote: > On 03/19/2014 05:04 PM, Vincent van Ravesteijn wrote: >> Yes, please commit. > > > But note you need to increase the format in configure.py as well. > > Richard > I changed it in configure.py and committed at 23a28e78. Scott

Re: [PATCH] Bump RC format for commit 214f7ed2

2014-03-19 Thread Richard Heck
On 03/19/2014 05:04 PM, Vincent van Ravesteijn wrote: Scott Kostyshak schreef op 19-3-2014 21:15: On Wed, Mar 19, 2014 at 10:58 AM, Richard Heck wrote: On 03/19/2014 04:43 AM, Vincent van Ravesteijn wrote: On Wed, Mar 19, 2014 at 7:51 AM, Scott Kostyshak wrote: Is the attached patch OK? Sco

Re: [PATCH] Bump RC format for commit 214f7ed2

2014-03-19 Thread Vincent van Ravesteijn
Scott Kostyshak schreef op 19-3-2014 21:15: On Wed, Mar 19, 2014 at 10:58 AM, Richard Heck wrote: On 03/19/2014 04:43 AM, Vincent van Ravesteijn wrote: On Wed, Mar 19, 2014 at 7:51 AM, Scott Kostyshak wrote: Is the attached patch OK? Scott The lyxrc.dist files don't have a version number. S

Re: [PATCH] Bump RC format for commit 214f7ed2

2014-03-19 Thread Scott Kostyshak
On Wed, Mar 19, 2014 at 10:58 AM, Richard Heck wrote: > On 03/19/2014 04:43 AM, Vincent van Ravesteijn wrote: >> >> On Wed, Mar 19, 2014 at 7:51 AM, Scott Kostyshak wrote: >>> Is the attached patch OK? Scott >> >> The lyxrc.dist files don't have a version number. Shouldn't these be >> checked ve

Re: [PATCH] Bump RC format for commit 214f7ed2

2014-03-19 Thread Richard Heck
On 03/19/2014 04:43 AM, Vincent van Ravesteijn wrote: On Wed, Mar 19, 2014 at 7:51 AM, Scott Kostyshak wrote: On Sat, Mar 15, 2014 at 12:02 PM, Richard Heck wrote: If it's a new preference, then no substantive code is needed. But the format should be bumped. Note that something needs to be a

Re: [PATCH] Bump RC format for commit 214f7ed2

2014-03-19 Thread Vincent van Ravesteijn
On Wed, Mar 19, 2014 at 7:51 AM, Scott Kostyshak wrote: > On Sat, Mar 15, 2014 at 12:02 PM, Richard Heck wrote: > >> If it's a new preference, then no substantive code is needed. But the format >> should >> be bumped. Note that something needs to be added to the prefs2prefs script >> itself, >> a

Re: [PATCH] Bump RC format for commit 214f7ed2

2014-03-18 Thread Scott Kostyshak
he attached patch OK? Scott From c39e88b51524c670751696d03680249ef9ea3925 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Fri, 14 Mar 2014 16:12:55 -0400 Subject: [PATCH] Bump RC format for commit 214f7ed2 --- lib/scripts/prefs2prefs_prefs.py | 3 ++- src/LyXRC.cpp| 2 +-

Re: [PATCH] Bump RC format for commit 214f7ed2

2014-03-15 Thread Richard Heck
On 03/14/2014 04:19 PM, Scott Kostyshak wrote: I've never done this before. Is this correct? Am I right that prefs2prefs is optional when adding a new preference? If it's a new preference, then no substantive code is needed. But the format should be bumped. Note that something needs to be adde

[PATCH] Bump RC format for commit 214f7ed2

2014-03-14 Thread Scott Kostyshak
I've never done this before. Is this correct? Am I right that prefs2prefs is optional when adding a new preference? Scott From f6ebf3ef3d30e6dc7f3d08cee3b7d482a76feb23 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Fri, 14 Mar 2014 16:12:55 -0400 Subject: [PATCH] Bump RC format for c