Re: [PATCH] Bugs 2474 and 1777: Reference Selection

2007-04-24 Thread Abdelrazak Younes
Richard Heck wrote: It turns out that the multiple calls are due to the fact that updateToolbars(), which is called at the end of the dipatch() routine, also calls update() which calls update_contents(). Since update() also gets called in, say, the INSET_APPLY routine, you get multiple calls. Is

Re: [PATCH] Bugs 2474 and 1777: Reference Selection

2007-04-24 Thread Richard Heck
It turns out that the multiple calls are due to the fact that updateToolbars(), which is called at the end of the dipatch() routine, also calls update() which calls update_contents(). Since update() also gets called in, say, the INSET_APPLY routine, you get multiple calls. Is it worth looking into

Re: [PATCH] Bugs 2474 and 1777: Reference Selection

2007-04-23 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > By the way, running several of these dialogs through the debugger, I've > > noticed that this is generally true: if you go through update_contents() > > once, you'll go through it two or three times. This does not seem like a > > good thing, but I d

Re: [PATCH] Bugs 2474 and 1777: Reference Selection

2007-04-23 Thread Abdelrazak Younes
Richard Heck wrote: This patch was sent to the list a few days back. I'm reposting it before committing, in case anyone wants to comment. The previous code for setting a "default" reference was irremediably broken. State has to be maintained in QRef itself, not in the list widget, which gets cle

[PATCH] Bugs 2474 and 1777: Reference Selection

2007-04-23 Thread Richard Heck
This patch was sent to the list a few days back. I'm reposting it before committing, in case anyone wants to comment. The previous code for setting a "default" reference was irremediably broken. State has to be maintained in QRef itself, not in the list widget, which gets cleared every time throu

[PATCH] Bugs 2474 and 1777: Reference Selection

2007-04-20 Thread Richard Heck
The attached patch addresses these two bugs. I'm not proposing to commit before beta 2, but comments are nonetheless invited. The previous code for setting a "default" reference was irremediably broken. State has to be maintained in QRef itself, not in the list widget, which gets cleared every ti