Re: [PATCH] Bug 5061

2008-11-02 Thread Dov Feldstern
Vincent van Ravesteijn - TNW wrote: (2) However, #5061 still exists when boundary is set to true for a correct reason; for example, try this recipe: - create a new file - insert an equation - press the right arrow key to jump out of the equation - press Ctrl-Return - switch the language to an

RE: [PATCH] Bug 5061

2008-10-31 Thread Vincent van Ravesteijn - TNW
>Okay, there are actually two separate issues here: > >(1) boundary is incorrectly set to true in this case (my bug, >correctly diagnosed, but incorrectly fixed, by Vincent); The >attached patch fixes it. If nobody has objections to it, I'll >check it in tomorrow evening. > >This is good enough t

RE: [PATCH] Bug 5061

2008-10-31 Thread Vincent van Ravesteijn - TNW
>Okay, there are actually two separate issues here: > >(1) boundary is incorrectly set to true in this case (my bug, correctly >diagnosed, but incorrectly fixed, by Vincent); The attached patch fixes >it. If nobody has objections to it, I'll check it in tomorrow evening. > >This is good enough to

Re: [PATCH] Bug 5061

2008-10-31 Thread Dov Feldstern
Dov Feldstern wrote: Enrico Forestieri wrote: On Thu, Oct 30, 2008 at 07:51:41AM -0400, rgheck wrote: http://bugzilla.lyx.org/show_bug.cgi?id=5061 Can someone who knows about InsetMathNest review the patch Vincent attached to this bug? It looks like it's probably correct, but I don't know ab

Re: [PATCH] Bug 5061

2008-10-31 Thread Pavel Sanda
Dov Feldstern wrote: > No, I don't think it was an oversight, Vincent's patch breaks visual cursor > movements in math. it may be good to add some comment in the code so other people in future will be warned whats going on.. pavel

Re: [PATCH] Bug 5061

2008-10-31 Thread Dov Feldstern
Enrico Forestieri wrote: On Thu, Oct 30, 2008 at 07:51:41AM -0400, rgheck wrote: http://bugzilla.lyx.org/show_bug.cgi?id=5061 Can someone who knows about InsetMathNest review the patch Vincent attached to this bug? It looks like it's probably correct, but I don't know about this stuff. Me n

Re: [PATCH] Bug 5061

2008-10-30 Thread Enrico Forestieri
On Thu, Oct 30, 2008 at 07:51:41AM -0400, rgheck wrote: > > http://bugzilla.lyx.org/show_bug.cgi?id=5061 > > Can someone who knows about InsetMathNest review the patch Vincent > attached to this bug? It looks like it's probably correct, but I don't > know about this stuff. Me neither, but look

[PATCH] Bug 5061

2008-10-30 Thread rgheck
http://bugzilla.lyx.org/show_bug.cgi?id=5061 Can someone who knows about InsetMathNest review the patch Vincent attached to this bug? It looks like it's probably correct, but I don't know about this stuff. rh -- --- Richard G Heck Jr Professor of Philosophy Brown Univers