Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-09 Thread Richard Heck
Jean-Marc Lasgouttes wrote: Richard Heck <[EMAIL PROTECTED]> writes: i would intuitively expect more that paragraphs inside the insets wont be changed by this. but it may be difficult to gain consesus on this. what others think ? I've been thinking about this a fair bit, and I agree

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-09 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: >> i would intuitively expect more that paragraphs inside the insets wont be >> changed by this. but it may be difficult to gain consesus on this. >> what others think ? >> > I've been thinking about this a fair bit, and I agree with you, Pavel. > Suppos

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-09 Thread Richard Heck
Pavel Sanda wrote: looking on the rest of the patch i didnt see how to easily make indent toggling as i made available in previous patches. is it still possible to make something like "paragraph-indent toggle" ? i started to use it and became almost addicted to it :) Not at present, a

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-09 Thread Pavel Sanda
> >looking on the rest of the patch i didnt see how to easily make indent > >toggling as i made available in previous patches. is it still possible to > >make > >something like "paragraph-indent toggle" ? i started to use it and became > >almost addicted to it :) > > > Not at present, and it wo

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-09 Thread Richard Heck
Pavel Sanda wrote: New patch attached. I don't have time to test it right now but will later. But it should work. i'm sure i knew how to deliver correct params to paragraph-params-apply, but now my guesses dont work :) please can you give me samples for params for centering or (no)indent f

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-08 Thread Pavel Sanda
> New patch attached. I don't have time to test it right now but will > later. But it should work. i'm sure i knew how to deliver correct params to paragraph-params-apply, but now my guesses dont work :) please can you give me samples for params for centering or (no)indent for paragraph-params lf

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-08 Thread Alfredo Braunstein
Pavel Sanda wrote: >> One day I'll add this to the wiki (help welcomed though) > > skeleton created here: > http://wiki.lyx.org/Devel/Diagrams > change it as you wish Cool, thanks! A/

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-08 Thread Pavel Sanda
> One day I'll add this to the wiki (help welcomed though) skeleton created here: http://wiki.lyx.org/Devel/Diagrams change it as you wish pavel

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-08 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Richard Heck wrote: > >> there before, if it is there now. I'm still not sure I understand these >> ParIterators---though thanks for the earlier info---so if you want to > > > Just to add something to JMarc's explanation (and because they it is said > that a picture

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-08 Thread Alfredo Braunstein
Richard Heck wrote: > there before, if it is there now. I'm still not sure I understand these > ParIterators---though thanks for the earlier info---so if you want to Just to add something to JMarc's explanation (and because they it is said that a picture is worth at least 10^3 words) I'm attachi

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-08 Thread Richard Heck
New patch attached. I don't have time to test it right now but will later. But it should work. Jean-Marc Lasgouttes wrote: Richard Heck <[EMAIL PROTECTED]> writes: + /// Similar, but handles only one paragraph. + void setParagraph(Paragraph & par, ParagraphParameters const & p

Re: [PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-08 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: > The basic idea is pretty simple, but the code needed some cleanup > before it would work at all elegantly. It is nice to see this done. A few comments: > + void setParagraphs(Cursor & cur, docstring arg, bool modify = false); I do not like the name

[PATCH] Bug 2714: Add general paragraph-params LFUN

2007-08-07 Thread Richard Heck
This patch addresses 2714, for which there was an earlier patch, but this patch proceeds more generally, in accord with some comments by JMarc. The original request was to be able to set paragraph alignment via an LFUN. This was not possible using paragraph-params-apply, because that override