Re: [PATCH] Bug 2186 .bst files cannot live in paths with spaces

2006-03-30 Thread Georg Baum
Am Donnerstag, 30. März 2006 21:29 schrieb Bo Peng: > Then, this is not my fault. :-) I did not say that it was yours. > I definitely agree, but a speedier review would be welcome. No problem if you can extend each day by some extra hours ;-) > The patch works, but I do not like the one line f

Re: [PATCH] Bug 2186 .bst files cannot live in paths with spaces

2006-03-30 Thread Bo Peng
> That place is wrong, too. mangledFilename() treats the extension > specially. Then, this is not my fault. :-) My current knowledge of lyx source code only allows me to mimic existing code. > This is a good example why reviewing is needed: Even if you are sure that > your patch has no problem ot

Re: [PATCH] Bug 2186 .bst files cannot live in paths with spaces

2006-03-30 Thread Georg Baum
Am Mittwoch, 29. März 2006 21:51 schrieb Bo Peng: > > mangledFilename() should be called on complete filenames (with extension). > > Please use something like > > This is not what the code shows me (insetbibtex.C, line 166). That place is wrong, too. mangledFilename() treats the extension speci

Re: [PATCH] Bug 2186 .bst files cannot live in paths with spaces

2006-03-29 Thread Bo Peng
> Only copy the file if runparams.nice == false. This is consistent with > insetgraphics and insetinclude. You should probably output a warning if > runparams.nice == true and the filename contains spaces (see the .bib file > handling). Attached. Now, export->latex does not show mangled name. Than

Re: [PATCH] Bug 2186 .bst files cannot live in paths with spaces

2006-03-29 Thread Georg Baum
Am Mittwoch, 29. März 2006 05:16 schrieb Bo Peng: > The patch does not look nice, but seem to work. One problem I find is > that if I export the file to latex, the mangled bst filename will be > used. I am glad that you did this, one bug less on my TODO list :-) It would be nice if you could fix s

[PATCH] Bug 2186 .bst files cannot live in paths with spaces

2006-03-28 Thread Bo Peng
The patch does not look nice, but seem to work. One problem I find is that if I export the file to latex, the mangled bst filename will be used. I expect someone to jump in and say 'this is not a lyx bug and we should not fix it.' :-) Bo Index: src/insets/insetbibtex.C ===