Re: [PATCH] BUG 1486 copied formula is not previewed.

2007-06-21 Thread José Matos
On Thursday 21 June 2007 14:36:33 Bo Peng wrote: > Anyway, your patch fixes this specific problem with less code, so it can go > in. > > Cheers, > Bo OK. -- José Abílio

Re: [PATCH] BUG 1486 copied formula is not previewed.

2007-06-21 Thread Bo Peng
I wonder if there is any side-effect of using something like the attached instead. Your patch is better, so you have my OK. My original thought was to remove outside addPreview so that all MathHull (and other previewable insets) get their preview in this way (if preview empty, add snippet). I m

Re: [PATCH] BUG 1486 copied formula is not previewed.

2007-06-21 Thread Alfredo Braunstein
Bo Peng wrote: >> Waiting for two OKs. > > Please use this version. I wonder if there is any side-effect of using something like the attached instead. A/ Index: InsetMathHull.cpp === --- InsetMathHull.cpp (revision 18837) +++ Inse

Re: [PATCH] BUG 1486 copied formula is not previewed.

2007-06-20 Thread Bo Peng
Waiting for two OKs. Please use this version. Bo Index: src/insets/RenderPreview.h === --- src/insets/RenderPreview.h (revision 18839) +++ src/insets/RenderPreview.h (working copy) @@ -51,6 +51,9 @@ RenderPreview(RenderPreview co

[PATCH] BUG 1486 copied formula is not previewed.

2007-06-20 Thread Bo Peng
http://bugzilla.lyx.org/show_bug.cgi?id=1486 Problem: Create a lyx document, enter $x^2$, wait for it to be previewed, now copy this formula and paste. The copied mathed will not be previewed, even if you move your cursor in and out. Diagnosis: In the copy constructor of InsetMathHull, preview