Re: [PATCH] Add more controls to the view source dialog.

2006-08-04 Thread Bo Peng
Dear all, The patch has been committed. The function names are writeXXXSource for the ostream version and makeXXXFile for the file version, where XXX is LaTeX, LinuxDoc and DocBook. I did not touch the Ascii file since writeAsciiSource does not sound right. 'write' seems to be better than 'gener

Re: [PATCH] Add more controls to the view source dialog.

2006-08-03 Thread Bo Peng
> Bo Peng <[EMAIL PROTECTED]> writes: > > This is what makeLatexFile is doing Do you want to change the > > name of those functions as well? Any suggestion? > > generateLatex, generateAscii, generateDocbook... If you look at buffer.h, we also have writeFileAscii(filename...), writeFileAscii(

Re: [PATCH] Add more controls to the view source dialog.

2006-08-03 Thread Bo Peng
On 8/3/06, Angus Leeming <[EMAIL PROTECTED]> wrote: Bo Peng <[EMAIL PROTECTED]> writes: > This is what makeLatexFile is doing Do you want to change the > name of those functions as well? Any suggestion? generateLatex, generateAscii, generateDocbook... If you look at buffer.h, we also have

Re: [PATCH] Add more controls to the view source dialog.

2006-08-03 Thread Angus Leeming
Bo Peng <[EMAIL PROTECTED]> writes: > This is what makeLatexFile is doing Do you want to change the > name of those functions as well? Any suggestion? generateLatex, generateAscii, generateDocbook... Angus

Re: [PATCH] Add more controls to the view source dialog.

2006-08-03 Thread Bo Peng
You change the signatures of some functions (makeXXXFile), and by doing this the name of the function is now "meaningless". makeXxxxFile(ostream & os, ...) is not making a file anymore, is is just outputting to a stream. IMO the names of these functions should change as well. This is what make

Re: [PATCH] Add more controls to the view source dialog.

2006-08-03 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | Dear list, | | Attached patch adds to the view-source dialog (qt3/4): | | 1. 'automatic update' check box. If unchecked, stop automatic updating | of the view source dialog. This is useful for slow machines, and when | full source is displayed. | 2. update

[PATCH] Add more controls to the view source dialog.

2006-08-02 Thread Bo Peng
Dear list, Attached patch adds to the view-source dialog (qt3/4): 1. 'automatic update' check box. If unchecked, stop automatic updating of the view source dialog. This is useful for slow machines, and when full source is displayed. 2. update button: force update if 'auto update' checkbox is unc