Re: [PATCH] change tracking changes, revised

2005-08-08 Thread Andre Poenitz
On Thu, Jul 21, 2005 at 04:12:01PM +0100, John Levon wrote: > non-editable. Andre, please look it over > > Index: lyxfunc.C > === > RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfunc.C,v > retrieving revision 1.663 > diff -u -a -p

Re: [PATCH] change tracking changes, revised

2005-08-08 Thread Andre Poenitz
On Thu, Jul 21, 2005 at 04:46:32PM +0100, John Levon wrote: > On Thu, Jul 21, 2005 at 05:31:33PM +0200, Jean-Marc Lasgouttes wrote: > > > Why don't you add the editable() stuff directly to InsetBase? Both > > math and normal insets derive from that these days. > > There's a nasty comment saying I

Re: [PATCH] change tracking changes, revised

2005-07-21 Thread John Levon
On Thu, Jul 21, 2005 at 05:56:57PM +0200, Jean-Marc Lasgouttes wrote: > John> There's a nasty comment saying I'm not allowed to add data > John> members > > Indeed :) What kind of support do you want to obtain anyway? You do > not plan to support change tracking _inside_ insets, I guess? Sure I

Re: [PATCH] change tracking changes, revised

2005-07-21 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Thu, Jul 21, 2005 at 05:31:33PM +0200, Jean-Marc Lasgouttes John> wrote: >> Why don't you add the editable() stuff directly to InsetBase? Both >> math and normal insets derive from that these days. John> There's a nasty comment sayin

Re: [PATCH] change tracking changes, revised

2005-07-21 Thread John Levon
On Thu, Jul 21, 2005 at 05:31:33PM +0200, Jean-Marc Lasgouttes wrote: > Why don't you add the editable() stuff directly to InsetBase? Both > math and normal insets derive from that these days. There's a nasty comment saying I'm not allowed to add data members regards john

Re: [PATCH] change tracking changes, revised

2005-07-21 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> This version includes basic support for making math formulae John> non-editable. Andre, please look it over Why don't you add the editable() stuff directly to InsetBase? Both math and normal insets derive from that these days. JMarc

[PATCH] change tracking changes, revised

2005-07-21 Thread John Levon
This version includes basic support for making math formulae non-editable. Andre, please look it over thanks john Index: lyxfunc.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfunc.C,v retrieving revision 1.663 diff -u -a -