Re: [PATCH]: silence MSVC warning about truncation of int to char

Lars Gullik Bjønnes wrote: > | The patch is exactly equivalent to this test code. c==c2 and uc==uc2, > | as expected. > > :-) > > When I said tested, meant "compiled" > but your test was nice as well. Sheesh! You think I trust myself to second guess what a compiler thinks about all these implici

Re: [PATCH]: silence MSVC warning about truncation of int to char

Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Angus Leeming <[EMAIL PROTECTED]> writes: >> >> | Angus Leeming wrote: >>> Lars Gullik Bjønnes wrote: > Hmm... it should be easy to avoid the extra local var. > >'\x5f' could have been used.

Re: [PATCH]: silence MSVC warning about truncation of int to char

Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | Angus Leeming wrote: >> >>> Lars Gullik Bjønnes wrote: Hmm... it should be easy to avoid the extra local var. '\x5f' could have been used. but keep the local var, but IMHO it would be ni

Re: [PATCH]: silence MSVC warning about truncation of int to char

Angus Leeming <[EMAIL PROTECTED]> writes: | Angus Leeming wrote: > >> Lars Gullik Bjønnes wrote: >>> Hmm... it should be easy to avoid the extra local var. >>> >>>'\x5f' could have been used. >>> >>> but keep the local var, but IMHO it would be nice with: >>> >>> char const underbar

Re: [PATCH]: silence MSVC warning about truncation of int to char

Angus Leeming wrote: > Lars Gullik Bjønnes wrote: >> Hmm... it should be easy to avoid the extra local var. >> >>'\x5f' could have been used. >> >> but keep the local var, but IMHO it would be nice with: >> >> char const underbar = '\x5f'; >> >> then you don't get any conversions a

Re: [PATCH]: silence MSVC warning about truncation of int to char

Lars Gullik Bjønnes wrote: > Hmm... it should be easy to avoid the extra local var. > >'\x5f' could have been used. > > but keep the local var, but IMHO it would be nice with: > > char const underbar = '\x5f'; > > then you don't get any conversions at all, implicit nor explicit. Ok

Re: [PATCH]: silence MSVC warning about truncation of int to char

Angus Leeming <[EMAIL PROTECTED]> writes: | Here's another obvious fix. Ok to commit? > | \lyx\lyx-devel\src\insets\insetlatexaccent.C(431) : warning C4309: | 'argument' : truncation of constant value > | Index: src/insets/insetlatexaccent.C | =

Re: [PATCH]: silence MSVC warning about truncation of int to char

Angus Leeming wrote: > Here's another obvious fix. Ok to commit? I committed it. -- Angus

Re: [PATCH]: silence MSVC warning

On Mon, Feb 14, 2005 at 02:54:08PM +, Angus Leeming wrote: > The MSVC compiler is complaining about math_rootinset.C: > > \lyx\lyx-devel\src\mathed\math_rootinset.C(86) : warning C4805: '==' : > unsafe mix of type 'DocIterator::idx_type' and type 'bool' in operation > > It seems to me that t

Re: [PATCH]: silence MSVC warning

Jean-Marc Lasgouttes wrote: > Angus> The MSVC compiler is complaining about math_rootinset.C: > Angus> \lyx\lyx-devel\src\mathed\math_rootinset.C(86) : warning C4805: > Angus> '==' : unsafe mix of type 'DocIterator::idx_type' and type > Angus> 'bool' in operation > > Angus> It seems to me that the

[PATCH]: silence MSVC warning about truncation of int to char

Here's another obvious fix. Ok to commit? \lyx\lyx-devel\src\insets\insetlatexaccent.C(431) : warning C4309: 'argument' : truncation of constant value Index: src/insets/insetlatexaccent.C === RCS file: /usr/local/lyx/cvsroot/lyx-dev

Re: [PATCH]: silence MSVC warning

> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> The MSVC compiler is complaining about math_rootinset.C: Angus> \lyx\lyx-devel\src\mathed\math_rootinset.C(86) : warning C4805: Angus> '==' : unsafe mix of type 'DocIterator::idx_type' and type Angus> 'bool' in operation Angus> It

[PATCH]: silence MSVC warning

The MSVC compiler is complaining about math_rootinset.C: \lyx\lyx-devel\src\mathed\math_rootinset.C(86) : warning C4805: '==' : unsafe mix of type 'DocIterator::idx_type' and type 'bool' in operation It seems to me that the fix is both obvious and makes the code more transparent. Ok to commit?