Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Martin Vermeer
On Thu, Nov 13, 2003 at 03:01:21PM +, Angus Leeming spake thusly: > > If no shout, I'll commit a bit later. > > Please do. So done. - Martin pgp0.pgp Description: PGP signature

Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Angus Leeming
Martin Vermeer wrote: > OK, here's my latest including a local LFUN_INSET_INSERT. Thank you. > If no shout, I'll commit a bit later. Please do. -- Angus

Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Martin Vermeer
On Thu, Nov 13, 2003 at 02:04:06PM +, Angus Leeming spake thusly: > > Andre Poenitz wrote: > > > On Thu, Nov 13, 2003 at 01:48:37PM +, Angus Leeming wrote: > >> I am all in favour of the general thrust (to get things working) > >> but would want LFUN_INSET_INSERT to be moved across too. >

Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Andre Poenitz
On Thu, Nov 13, 2003 at 02:04:06PM +, Angus Leeming wrote: > > Andre', off for a few days now. > Have a good break. Conference. Talk. *sigh* Andre'

Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Angus Leeming
Andre Poenitz wrote: > On Thu, Nov 13, 2003 at 01:48:37PM +, Angus Leeming wrote: >> I am all in favour of the general thrust (to get things working) >> but would want LFUN_INSET_INSERT to be moved across too. >> Pleaeee! > > So why don't you just do it. > You are a big boy after

Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Andre Poenitz
On Thu, Nov 13, 2003 at 01:48:37PM +, Angus Leeming wrote: > I am all in favour of the general thrust (to get things working) but > would want LFUN_INSET_INSERT to be moved across too. > Pleaeee! So why don't you just do it. You are a big boy after all. Andre', off for a few day

Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Angus Leeming
Andre Poenitz wrote: > On Thu, Nov 13, 2003 at 01:26:53PM +, [EMAIL PROTECTED] > wrote: >> .. >> >> >> Attached a patch instrumented with asserts. >> >> >> >> Let's check this in. We'll hear about it soon enough if this >> >> code is >> >> in use somewhere... I gave it a quick test, but didn

Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Andre Poenitz
On Thu, Nov 13, 2003 at 01:26:53PM +, [EMAIL PROTECTED] wrote: > .. > > >> Attached a patch instrumented with asserts. > >> > >> Let's check this in. We'll hear about it soon enough if this code is > >> in use somewhere... I gave it a quick test, but didn't manage to > >> trigger it. > >> > >

Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread martin . vermeer
... >> Attached a patch instrumented with asserts. >> >> Let's check this in. We'll hear about it soon enough if this code is >> in use somewhere... I gave it a quick test, but didn't manage to >> trigger it. >> >> (Is there a way to check more systematically whether a piece of code >> _ever_ get

Re: [New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Andre Poenitz
On Thu, Nov 13, 2003 at 02:58:01PM +0200, Martin Vermeer wrote: > On Thu, Nov 13, 2003 at 12:13:14PM +, [EMAIL PROTECTED] spake thusly: > > > It doesn't get called, that's what's wrong with it. > > > > What implications does deleting the above code from > > BufferView::Pimpl::dispatch have?

[New patch] Re: Why label etc. is not inserted

2003-11-13 Thread Martin Vermeer
On Thu, Nov 13, 2003 at 12:13:14PM +, [EMAIL PROTECTED] spake thusly: > It doesn't get called, that's what's wrong with it. > > What implications does deleting the above code from > BufferView::Pimpl::dispatch have? I haven't tried it. Attached a patch instrumented with asserts. Let's ch