Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-29 Thread Martin Vermeer
On Thu, Jun 22, 2006 at 12:23:38PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: ... > Martin> Attached the tabular background patch for 1.4 (still not > Martin> applied) > > This part is OK. Checked it in, so it isn't forgotten. Log:

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-26 Thread Martin Vermeer
On Fri, Jun 23, 2006 at 12:04:33PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> I do not know whether this is related to your patch(es): try to > >> insert a collapsable inset in a tabular cell; the right margin of > >> the inset is outs

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-23 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> I do not know whether this is related to your patch(es): try to >> insert a collapsable inset in a tabular cell; the right margin of >> the inset is outside of the screen. Martin> I suppose the speed-up patch exposed this bug, Umm

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Martin Vermeer
On Thu, Jun 22, 2006 at 04:05:34PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: ... > Running under gdb, I noticed that InsetCollapsable::metrics is called > twice when creating a new note inset. The reason is that it is called > twice in Ins

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> And do you think it would be too difficult to fix the real cause? Martin> My patch does that... imperfectly. The value is now sensible, Martin> but often a bit generous. Yes, I saw that afterwards, but failed to edit the message co

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Martin Vermeer
On Thu, 2006-06-22 at 12:23 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> I suppose the speed-up patch exposed this bug, i.e., that a > Martin> tabular cell with a non-fixed width does not transmit a > Martin> sensible mi.base.textwid

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-22 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> I suppose the speed-up patch exposed this bug, i.e., that a Martin> tabular cell with a non-fixed width does not transmit a Martin> sensible mi.base.textwidth to any textinsets it contains. Now Martin> that we use this (or the de

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Martin Vermeer
On Wed, Jun 21, 2006 at 12:17:41PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> In my newfound tradition of making everything simpler :-) If > Martin> you paint the whole tabular background, you don't have to > Martin> figure out wha

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> In my newfound tradition of making everything simpler :-) If Martin> you paint the whole tabular background, you don't have to Martin> figure out what cell you're in... Martin> Please give it some exercise before the go-ahead fo

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, 2006-06-20 at 13:41 +0300, Martin Vermeer wrote: > On Tue, 2006-06-20 at 11:55 +0200, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > Martin> In my newfound tradition of making everything simpler :-) If > > Martin> you paint the whole ta

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, 2006-06-20 at 11:55 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> In my newfound tradition of making everything simpler :-) If > Martin> you paint the whole tabular background, you don't have to > Martin> figure out what cell

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> In my newfound tradition of making everything simpler :-) If Martin> you paint the whole tabular background, you don't have to Martin> figure out what cell you're in... You are saying it is not a problem because you repaint the

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Mon, 2006-06-19 at 15:05 +0300, Martin Vermeer wrote: > On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a > > >> rendering bug. > > > > Ma

[Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a > >> rendering bug. > > Martin> Committed for trunk. Jean-Marc? > > OK. No. I found a better w

Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a >> rendering bug. Martin> Committed for trunk. Jean-Marc? OK. JMarc

Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-18 Thread Martin Vermeer
On Thu, Jun 15, 2006 at 01:31:55PM +0300, Martin Vermeer wrote: > On Wed, 2006-06-14 at 20:58 +0200, Andre Poenitz wrote: > > On Wed, Jun 14, 2006 at 09:35:23PM +0300, Martin Vermeer wrote: > > > (BTW what should I use instead of 99? No, don't say 42...) > > > > size_t(-1) > > > > [Or the equival

[New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-15 Thread Martin Vermeer
On Wed, 2006-06-14 at 20:58 +0200, Andre Poenitz wrote: > On Wed, Jun 14, 2006 at 09:35:23PM +0300, Martin Vermeer wrote: > > (BTW what should I use instead of 99? No, don't say 42...) > > size_t(-1) > > [Or the equivalent from numeric_limits...] > > Or a bool. Done. I propose this for trunk an