Re: [LyX master] Implement revision info for git

2013-02-17 Thread Pavel Sanda
Georg Baum wrote: > > maybe adding dirty flag makes sense as well: git describe --abrev --dirty > > --long p > > Do whatever you like, you know better than me the intended usage. Check the new version, looks nicer to me. Pavel

Re: [LyX master] Implement revision info for git

2013-02-16 Thread Georg Baum
Pavel Sanda wrote: > Pavel Sanda wrote: >> -doVCCommand("git log -n 1 --pretty=format:%H . > " + >> quoteName(tmpf.toFilesystemEncoding()), >> +doVCCommand("git describe --long > " + >> quoteName(tmpf.toFilesystemEncoding()), > > maybe adding dirty flag makes sense as well: git describe -

Re: [LyX master] Implement revision info for git

2013-02-15 Thread Pavel Sanda
Pavel Sanda wrote: > - doVCCommand("git log -n 1 --pretty=format:%H . > " + > quoteName(tmpf.toFilesystemEncoding()), > + doVCCommand("git describe --long > " + > quoteName(tmpf.toFilesystemEncoding()), maybe adding dirty flag makes sense as well: git describe --abrev --dirty --long p

Re: [LyX master] Implement revision info for git

2013-02-15 Thread Pavel Sanda
Pavel Sanda wrote: > IIRC "svnversion ." would return version of the whole tree as well not just > the current directory while git has different semantics. > > > How yould you implement that? > > I think "git log -n 1 --pretty=format:%H" without the dot does the job. Would you agree with the fol

Re: [LyX master] Implement revision info for git

2013-02-11 Thread Pavel Sanda
Georg Baum wrote: > tmpf); > >> + return false; > >> + } > >> + > >> + doVCCommand("git log -n 1 --pretty=format:%H . > " + > >> quoteName(tmpf.toFilesystemEncoding()), > >> + FileName(owner_->filePath())); > > > > The "." is intentional? I would expect that we wanted the w

Re: [LyX master] Implement revision info for git

2013-02-11 Thread Georg Baum
Pavel Sanda wrote: > Georg Baum wrote: >> commit 22b7ad2b0a6c228f234bcf7f5a0b164fca17e122 >> Author: Georg Baum >> Date: Thu Feb 7 22:07:22 2013 +0100 >> >> Implement revision info for git >> >> +bool GIT::getTreeRevisionInfo() >> +{ >> +FileName tmpf = FileName::tempName("lyxvcout");

Re: [LyX master] Implement revision info for git

2013-02-09 Thread Pavel Sanda
Georg Baum wrote: > commit 22b7ad2b0a6c228f234bcf7f5a0b164fca17e122 > Author: Georg Baum > Date: Thu Feb 7 22:07:22 2013 +0100 > > Implement revision info for git > > +bool GIT::getTreeRevisionInfo() > +{ > + FileName tmpf = FileName::tempName("lyxvcout"); > + if (tmpf.empty()) { >