Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-05-18 Thread Kornel Benko
Am Montag, 18. Mai 2015 um 12:16:19, schrieb Jürgen Spitzmüller > 2015-05-03 14:30 GMT+02:00 Jürgen Spitzmüller: > > > 2015-04-30 19:35 GMT+02:00 Jürgen Spitzmüller: > > > >> Further testing revealed that this is a change that needs careful > >> testing. I have learned that readParToken also uses

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-05-18 Thread Jürgen Spitzmüller
2015-05-03 14:30 GMT+02:00 Jürgen Spitzmüller: > 2015-04-30 19:35 GMT+02:00 Jürgen Spitzmüller: > >> Further testing revealed that this is a change that needs careful >> testing. I have learned that readParToken also uses getDocString() in order >> to read normal paragraph lines, and thus obviousl

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-05-04 Thread Jürgen Spitzmüller
2015-05-04 15:32 GMT+02:00 Jean-Marc Lasgouttes: > > Doing it in eatLine breaks parsing of LANGUAGES. >> > > What file is that? > err, lib/languages. Jürgen > > JMarc > >

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-05-04 Thread Jean-Marc Lasgouttes
Le 27/04/2015 11:09, Jürgen Spitzmüller a écrit : I inspected the (actually not so few) uses now, and I think that getString and getDocString is the place where tabs should be replaced by blanks. Doing it in eatLine breaks parsing of LANGUAGES. What file is that? JMarc

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-05-04 Thread Jean-Marc Lasgouttes
Le 03/05/2015 14:30, Jürgen Spitzmüller a écrit : 2015-04-30 19:35 GMT+02:00 Jürgen Spitzmüller: Further testing revealed that this is a change that needs careful testing. I have learned that readParToken also uses getDocString() in order to read normal paragraph lines, and thus obvi

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-05-03 Thread Uwe Stöhr
Am 03.05.2015 um 12:38 schrieb Jürgen Spitzmüller: Example file, please. This strikes me highly dubious. You already comitted the example file. In http://www.lyx.org/trac/changeset/f7b152581c0a00d2b2c92610325105e7ae0b599f/lyxgit the additional whitespace lines were deleted. Now I pulled git, o

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-05-03 Thread Jürgen Spitzmüller
2015-04-30 19:35 GMT+02:00 Jürgen Spitzmüller: > Further testing revealed that this is a change that needs careful testing. > I have learned that readParToken also uses getDocString() in order to read > normal paragraph lines, and thus obviously must not be trimmed. > After some more pondering, I

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-05-03 Thread Jürgen Spitzmüller
2015-05-03 4:43 GMT+02:00 Uwe Stöhr: > Am 30.04.2015 um 01:26 schrieb Uwe Stöhr: > > Hmm, I could verify this problem twice today but not now anymore. I >> therefore changed the whitespace as you requested. >> > > This whitespace commit > > http://www.lyx.org/trac/changeset/8efc734f1a5af3d44c006e

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-05-02 Thread Uwe Stöhr
Am 30.04.2015 um 01:26 schrieb Uwe Stöhr: Hmm, I could verify this problem twice today but not now anymore. I therefore changed the whitespace as you requested. This whitespace commit http://www.lyx.org/trac/changeset/8efc734f1a5af3d44c006e96e4ea19e25c61d737/lyxgit was a mistake. There I only

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-30 Thread Jürgen Spitzmüller
2015-04-27 11:09 GMT+02:00 Jürgen Spitzmüller: > 2015-04-27 9:56 GMT+02:00 Jürgen Spitzmüller: > >> 2015-04-26 21:40 GMT+02:00 Jean-Marc Lasgouttes: >> >>> I think it should treat tab like space. It is probably not that hard to >>> look up all the uses of eatLine in the code. The only place I woul

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-29 Thread Uwe Stöhr
Am 29.04.2015 um 09:42 schrieb Jürgen Spitzmüller: 2015-04-29 2:02 GMT+02:00 Uwe Stöhr : I would do this, but this add an unwanted empty line to the LyX file. To test, take the pdfform.module and remove the tabs by 2 spaces in the first InsetLayout definition. Then open the PDF-forms.lyx examp

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-29 Thread Jürgen Spitzmüller
2015-04-29 2:02 GMT+02:00 Uwe Stöhr : > I would do this, but this add an unwanted empty line to the LyX file. > > To test, take the pdfform.module and remove the tabs by 2 spaces in the > first InsetLayout definition. Then open the PDF-forms.lyx example file and > save it. Finally see the git diff

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-28 Thread Uwe Stöhr
Am 28.04.2015 um 09:23 schrieb Jürgen Spitzmüller: I prefer (2) spaces for intending sub-tags. I would do this, but this add an unwanted empty line to the LyX file. To test, take the pdfform.module and remove the tabs by 2 spaces in the first InsetLayout definition. Then open the PDF-forms.l

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-28 Thread Jürgen Spitzmüller
2015-04-27 23:00 GMT+02:00 Uwe Stöhr: > Hi Jürgen, > > since I don't know this code I cannot state on this. For me it important > to be able to use tabs for the spacing for all statements. This makes > working with the layouts and modules much easier. > If an author prefers spaces, it is OK but th

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-27 Thread Uwe Stöhr
Am 27.04.2015 um 11:09 schrieb Jürgen Spitzmüller: I inspected the (actually not so few) uses now, and I think that getString and getDocString is the place where tabs should be replaced by blanks. Doing it in eatLine breaks parsing of LANGUAGES. See attached patch. Opinions? Hi Jürgen, since

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-27 Thread Jürgen Spitzmüller
2015-04-27 10:11 GMT+02:00 Jean-Marc Lasgouttes: > I am away for a week, and I have no access to the source code > unfortunately. > Does eatline eat spaces? > It eats it in the sense that it does not ignore it. Only \r is ignored, AFAICS. Jürgen > > JMarc >

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-27 Thread Jean-Marc Lasgouttes
Le 27 avril 2015 09:56:37 UTC+02:00, "Jürgen Spitzmüller" a écrit : >2015-04-26 21:40 GMT+02:00 Jean-Marc Lasgouttes: > >> I think it should treat tab like space. It is probably not that hard >to >> look up all the uses of eatLine in the code. The only place I would >be >> scared about is the par

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-27 Thread Jürgen Spitzmüller
2015-04-27 9:56 GMT+02:00 Jürgen Spitzmüller: > 2015-04-26 21:40 GMT+02:00 Jean-Marc Lasgouttes: > >> I think it should treat tab like space. It is probably not that hard to >> look up all the uses of eatLine in the code. The only place I would be >> scared about is the parsing on .lyx files >> >

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-27 Thread Jürgen Spitzmüller
2015-04-26 21:40 GMT+02:00 Jean-Marc Lasgouttes: > I think it should treat tab like space. It is probably not that hard to > look up all the uses of eatLine in the code. The only place I would be > scared about is the parsing on .lyx files > So should eatLine itself care about the \t -> blank con

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-26 Thread Jean-Marc Lasgouttes
Le 26 avril 2015 16:46:13 UTC+02:00, "Jürgen Spitzmüller" a écrit : >The attached patch fixes it for me. However, I wonder if it is >intentional >that Lexer::Pimpl::eatLine() does not ignore \t. > >Opinions? I think it should treat tab like space. It is probably not that hard to look up all the

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-26 Thread Kornel Benko
Am Sonntag, 26. April 2015 um 16:46:13, schrieb Jürgen Spitzmüller > 2015-04-26 15:36 GMT+02:00 Kornel Benko: > > > I had to add > > \usepackage{hyperref} > > \usepackage{pdfcomment} > > > > to the preamble, to make it compilable. This should be done automatically > > either by l

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-26 Thread Uwe Stöhr
Am 26.04.2015 um 08:35 schrieb Scott Kostyshak: This commit broke three tests for me: 1710 - export/examples/PDF-comment_pdf2 (Failed) 1714 - export/examples/PDF-comment_pdf5_texF (Failed) 1715 - export/examples/PDF-comment_pdf5_systemF (Failed) I only changed whitesapce as you can see in the

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-26 Thread Jürgen Spitzmüller
2015-04-26 4:23 GMT+02:00 Uwe Stöhr: > commit 544b3f177446e0947fb6a709d18a48451f96fcad > Author: Uwe Stöhr > Date: Sun Apr 26 04:23:10 2015 +0200 > > pdfcomment.module: uniform whitespace > > the file used spaces and tabs, now it uses only tabs for the whitespace > This does not look p

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-26 Thread Jürgen Spitzmüller
The patch... 2015-04-26 16:46 GMT+02:00 Jürgen Spitzmüller: > 2015-04-26 15:36 GMT+02:00 Kornel Benko: > >> I had to add >> \usepackage{hyperref} >> \usepackage{pdfcomment} >> >> to the preamble, to make it compilable. This should be done automatically >> either by lyx (using hype

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-26 Thread Jürgen Spitzmüller
2015-04-26 15:36 GMT+02:00 Kornel Benko: > I had to add > \usepackage{hyperref} > \usepackage{pdfcomment} > > to the preamble, to make it compilable. This should be done automatically > either by lyx (using hyperlinks) > or by the pdfcomment.module (for the package pdfcomment) > >

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-26 Thread Kornel Benko
Am Sonntag, 26. April 2015 um 02:35:41, schrieb Scott Kostyshak > On Sat, Apr 25, 2015 at 10:23 PM, Uwe Stöhr wrote: > > commit 544b3f177446e0947fb6a709d18a48451f96fcad > > Author: Uwe Stöhr > > Date: Sun Apr 26 04:23:10 2015 +0200 > > > > pdfcomment.module: uniform whitespace > > > >

Re: [LyX/master] pdfcomment.module: uniform whitespace

2015-04-25 Thread Scott Kostyshak
On Sat, Apr 25, 2015 at 10:23 PM, Uwe Stöhr wrote: > commit 544b3f177446e0947fb6a709d18a48451f96fcad > Author: Uwe Stöhr > Date: Sun Apr 26 04:23:10 2015 +0200 > > pdfcomment.module: uniform whitespace > > the file used spaces and tabs, now it uses only tabs for the whitespace This com