On Thu, Apr 06, 2017 at 01:46:32PM +0200, Jean-Marc Lasgouttes wrote:
> Le 06/04/2017 à 05:05, Scott Kostyshak a écrit :
> > To make sure I understand, you are against the attached patch because
> > the changes are not as complicated as in the iconv case, right?
>
> No, I would be against the atta
Le 06/04/2017 à 05:05, Scott Kostyshak a écrit :
To make sure I understand, you are against the attached patch because
the changes are not as complicated as in the iconv case, right?
No, I would be against the attached because it is wrong: what should be
in ifdef is the
if(){} else{}
and th
On Sat, Apr 01, 2017 at 11:11:42AM +0200, Jean-Marc Lasgouttes wrote:
> Le 01/04/2017 à 07:06, Scott Kostyshak a écrit :
> > What are your thoughts on using pro-processor directives to keep track
> > of workarounds like this? For example, I really like the approach in
> > docstream.cpp for "WORKARO
Le 01/04/2017 à 07:06, Scott Kostyshak a écrit :
What are your thoughts on using pro-processor directives to keep track
of workarounds like this? For example, I really like the approach in
docstream.cpp for "WORKAROUND_ICONV_BUG". Are there disadvantages to
that approach?
In this particular cas
On Fri, Mar 31, 2017 at 05:03:44PM +0200, Jean-Marc Lasgouttes wrote:
> commit da590925cd6749587b9f500ecdaa457e34bc0f4a
> Author: Jean-Marc Lasgouttes
> Date: Fri Mar 31 16:56:06 2017 +0200
>
> Work around bug in QTextLine::xToCursor
>
> With RtL text, the method can be non-monoton
