Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-03-09 Thread Pavel Sanda
On Mon, Mar 08, 2021 at 10:48:07PM -0500, Richard Kimberly Heck wrote: > > Riki, unless you object I suggest to revert the whole 7e5c42593e45 because > > it seems > > to bring more problems then it solves... Would that be Ok with you? > > OK, go ahead. We can try something else later. Committed.

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-03-08 Thread Richard Kimberly Heck
On 3/8/21 5:35 PM, Pavel Sanda wrote: > On Wed, Mar 03, 2021 at 04:53:23PM +0100, Pavel Sanda wrote: >> On Sat, Jan 09, 2021 at 12:12:45AM -0500, Scott Kostyshak wrote: > I can see why the implementation in the previous version of using git-ls > was complex since we had to redirect output t

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-03-08 Thread Pavel Sanda
On Wed, Mar 03, 2021 at 04:53:23PM +0100, Pavel Sanda wrote: > On Sat, Jan 09, 2021 at 12:12:45AM -0500, Scott Kostyshak wrote: > > > > I can see why the implementation in the previous version of using git-ls > > > > was complex since we had to redirect output to a file and check it, but > > > > wh

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-03-04 Thread Richard Kimberly Heck
On 3/3/21 10:48 AM, Pavel Sanda wrote: > On Fri, Dec 25, 2020 at 06:35:08PM +0100, Pavel Sanda wrote: >> are you positive that cvs log does not actually try to connect to server >> (would >> make us fail if you are offline)? It's really long time ago I used cvs, but >> IIRC each tracked directory

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-03-03 Thread Pavel Sanda
On Sat, Jan 09, 2021 at 12:12:45AM -0500, Scott Kostyshak wrote: > > > I can see why the implementation in the previous version of using git-ls > > > was complex since we had to redirect output to a file and check it, but > > > what about using "git ls-files --error-unmatch " ? The > > > "--error-u

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-03-03 Thread Pavel Sanda
On Fri, Dec 25, 2020 at 06:35:08PM +0100, Pavel Sanda wrote: > are you positive that cvs log does not actually try to connect to server > (would > make us fail if you are offline)? It's really long time ago I used cvs, but > IIRC each tracked directory has the needed metadata locally at the place

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-01-11 Thread José Abílio Matos
On Saturday, January 9, 2021 10:38:21 PM WET Scott Kostyshak wrote: > That does sounds like a good idea, so as to avoid overhead of separate > processes. I have no idea if it's doable, but I like your strategy: > whenever José proposes something time-consuming, I will reframe it into > having to do

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-01-09 Thread Scott Kostyshak
On Sat, Jan 09, 2021 at 10:38:22PM +0100, Jean-Marc Lasgouttes wrote: > Le 09/01/2021 à 18:14, Scott Kostyshak a écrit : > > No bonus points given because it's a good point. It would be more clean and > > might actually make a noticeable difference in terms of speed. I haven't > > particularly no

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-01-09 Thread Jean-Marc Lasgouttes
Le 09/01/2021 à 18:14, Scott Kostyshak a écrit : No bonus points given because it's a good point. It would be more clean and might actually make a noticeable difference in terms of speed. I haven't particularly noticed slowness because of the VC code (although the previous code that redirected

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-01-09 Thread Scott Kostyshak
On Sat, Jan 09, 2021 at 09:12:19AM +, José Abílio Matos wrote: > On Saturday, January 9, 2021 5:12:45 AM WET Scott Kostyshak wrote: > > Sounds good. If anyone knows a good approach, please feel free to merge it > > into the patch and commit. Or describe the approach and I'll implement it. > >

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-01-09 Thread José Abílio Matos
On Saturday, January 9, 2021 5:12:45 AM WET Scott Kostyshak wrote: > Sounds good. If anyone knows a good approach, please feel free to merge it > into the patch and commit. Or describe the approach and I'll implement it. > > Scott Not necessarily what you want to hear, and clearly overkill in thi

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-01-08 Thread Scott Kostyshak
On Fri, Jan 08, 2021 at 10:59:43PM -0500, Richard Kimberly Heck wrote: > On 1/8/21 10:45 PM, Scott Kostyshak wrote: > > On Mon, Dec 28, 2020 at 03:45:11PM +0200, Yuriy Skalko wrote: > > I am sorry not to have a time to follow this thoroughly, but is this > > cvs log / git log used only inh

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-01-08 Thread Richard Kimberly Heck
On 1/8/21 10:45 PM, Scott Kostyshak wrote: > On Mon, Dec 28, 2020 at 03:45:11PM +0200, Yuriy Skalko wrote: > I am sorry not to have a time to follow this thoroughly, but is this > cvs log / git log used only inh "register" case as initially discussed > or you want to use it on every fil

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2021-01-08 Thread Scott Kostyshak
On Mon, Dec 28, 2020 at 03:45:11PM +0200, Yuriy Skalko wrote: > > > > I am sorry not to have a time to follow this thoroughly, but is this > > > > cvs log / git log used only inh "register" case as initially discussed > > > > or you want to use it on every file load? > > > > Calling log could but p

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2020-12-28 Thread Yuriy Skalko
> I am sorry not to have a time to follow this thoroughly, but is this > cvs log / git log used only inh "register" case as initially discussed > or you want to use it on every file load? > Calling log could but pretty expensive operation for large archives. The -n0 flag that Yuriy proposed shoul

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2020-12-25 Thread Pavel Sanda
On Thu, Dec 24, 2020 at 10:34:40AM -0500, Richard Kimberly Heck wrote: > > I am sorry not to have a time to follow this thoroughly, but is this > > cvs log / git log used only inh "register" case as initially discussed > > or you want to use it on every file load? > > Calling log could but pretty e

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2020-12-24 Thread Richard Kimberly Heck
On 12/24/20 3:20 AM, Pavel Sanda wrote: > On Fri, Dec 18, 2020 at 10:13:25PM +0100, Richard Kimberly Heck wrote: >> commit 7e5c42593e45424676b466db257e5c377329c2e4 >> Author: Richard Kimberly Heck >> Date: Fri Dec 18 16:43:52 2020 -0500 >> >> Simplify checking whether files are controlled by

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2020-12-24 Thread Pavel Sanda
On Fri, Dec 18, 2020 at 10:13:25PM +0100, Richard Kimberly Heck wrote: > commit 7e5c42593e45424676b466db257e5c377329c2e4 > Author: Richard Kimberly Heck > Date: Fri Dec 18 16:43:52 2020 -0500 > > Simplify checking whether files are controlled by SVN and GIT. > --- > src/VCBackend.cpp | 4

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2020-12-23 Thread Scott Kostyshak
On Wed, Dec 23, 2020 at 12:46:01PM -0500, Richard Kimberly Heck wrote: > On 12/23/20 2:47 AM, Yuriy Skalko wrote: > > > I think starting with this commit I now get a lot of Git output. For > > > example: > > > > > > ... > > > > > > Another question is: is it possible to avoid these commands for >

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2020-12-23 Thread Richard Kimberly Heck
On 12/23/20 2:47 AM, Yuriy Skalko wrote: I think starting with this commit I now get a lot of Git output. For example: ... Another question is: is it possible to avoid these commands for command-line export? I'm guessing it would be too complicated. Scott Passing "-n 0" option to git shou

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2020-12-22 Thread Yuriy Skalko
I think starting with this commit I now get a lot of Git output. For example: ... Another question is: is it possible to avoid these commands for command-line export? I'm guessing it would be too complicated. Scott Passing "-n 0" option to git should help, try the attached patch. Yuriy dif

Re: [LyX/master] Simplify checking whether files are controlled by SVN and GIT.

2020-12-22 Thread Scott Kostyshak
On Fri, Dec 18, 2020 at 10:13:25PM +0100, Richard Kimberly Heck wrote: > commit 7e5c42593e45424676b466db257e5c377329c2e4 > Author: Richard Kimberly Heck > Date: Fri Dec 18 16:43:52 2020 -0500 > > Simplify checking whether files are controlled by SVN and GIT. > --- I think starting with thi