Re: [LyX/master] Refine lang nesting fix

2015-10-20 Thread Scott Kostyshak
On Mon, Oct 19, 2015 at 07:59:59PM -0400, Scott Kostyshak wrote: > On Mon, Oct 19, 2015 at 09:24:45PM +0200, Georg Baum wrote: > > Scott Kostyshak wrote: > > > > > http://www.lyx.org/trac/ticket/9633 > > > > I am a bit confused. I thought my fix which I just submitted would address > > this? >

Re: [LyX/master] Refine lang nesting fix

2015-10-19 Thread Scott Kostyshak
On Mon, Oct 19, 2015 at 09:24:45PM +0200, Georg Baum wrote: > Scott Kostyshak wrote: > > > http://www.lyx.org/trac/ticket/9633 > > I am a bit confused. I thought my fix which I just submitted would address > this? Ah that is great then. I was focused only on regressions caused by 46aed6d2 but i

Re: [LyX/master] Refine lang nesting fix

2015-10-19 Thread Georg Baum
Scott Kostyshak wrote: > Do you mean with the patch in this email? Or do you mean on current > master, after commit 86325e50? with the patch, as you found out. > Yes we will have to discuss this. One issue is that you need a lot of > dependencies to run all the tests. Another issue is that a cou

Re: [LyX/master] Refine lang nesting fix

2015-10-18 Thread Scott Kostyshak
On Sun, Oct 18, 2015 at 09:56:06PM -0400, Scott Kostyshak wrote: > On Sun, Oct 18, 2015 at 09:42:08PM +0200, Georg Baum wrote: > > Thanks for taking a look at this mess, Georg. > > > Scott, could you please look whether the tests do still produce any > > regression? > > Do you mean with the pat

Re: [LyX/master] Refine lang nesting fix

2015-10-18 Thread Scott Kostyshak
On Sun, Oct 18, 2015 at 09:42:08PM +0200, Georg Baum wrote: > Scott Kostyshak wrote: > > > Much better. The following tests still fail (compared to not using your > > patch and reverting the commit in question, where these tests pass) > > > > ctest -R > > "(export/doc/de/Additional_pdf4_systemF|

Re: [LyX/master] Refine lang nesting fix

2015-10-18 Thread Kornel Benko
Am Sonntag, 18. Oktober 2015 um 21:42:08, schrieb Georg Baum > Scott Kostyshak wrote: > > > Much better. The following tests still fail (compared to not using your > > patch and reverting the commit in question, where these tests pass) > > > > ctest -R > > "(export/doc/de/Additional_pdf4_system

Re: [LyX/master] Refine lang nesting fix

2015-10-18 Thread Georg Baum
Scott Kostyshak wrote: > Much better. The following tests still fail (compared to not using your > patch and reverting the commit in question, where these tests pass) > > ctest -R > "(export/doc/de/Additional_pdf4_systemF| export/doc/fr/Additional_pdf4_systemF|export/doc/he/Tutorial_pdf4_systemF|

Re: [LyX/master] Refine lang nesting fix

2015-10-18 Thread Georg Baum
Jürgen Spitzmüller wrote: > Am Freitag 16 Oktober 2015, 23:50:38 schrieb Georg Baum: > >> Under the assumption that the old babel output was correct the fix is >> indeed trivial. > > I am not sure. When a babel language environment is used > (\begin{otherlanguage}...\end{otherlanguage}), I'd expe

Re: [LyX/master] Refine lang nesting fix

2015-10-17 Thread Jürgen Spitzmüller
Am Freitag 16 Oktober 2015, 23:50:38 schrieb Georg Baum: > Scott Kostyshak wrote: > > On Fri, Oct 16, 2015 at 10:55:25PM +0200, Georg Baum wrote: > >> I looked into the changes, and I believe we can fix this easily. The two > >> nesting fixs did also change the behaviour if babel is used. Was that

Re: [LyX/master] Refine lang nesting fix

2015-10-16 Thread Scott Kostyshak
On Fri, Oct 16, 2015 at 11:50:38PM +0200, Georg Baum wrote: > Scott Kostyshak wrote: > > > Great! Hopefully Jürgen can provide some direction (I think he is > > checking in on the list whenever he finds time). I can provide results > > from testing. > > If you want to try, see the attached. Much

Re: [LyX/master] Refine lang nesting fix

2015-10-16 Thread Georg Baum
Scott Kostyshak wrote: > On Fri, Oct 16, 2015 at 10:55:25PM +0200, Georg Baum wrote: >> >> I looked into the changes, and I believe we can fix this easily. The two >> nesting fixs did also change the behaviour if babel is used. Was that >> intended? If yes, what was the problem with the old babel

Re: [LyX/master] Refine lang nesting fix

2015-10-16 Thread Scott Kostyshak
On Fri, Oct 16, 2015 at 10:55:25PM +0200, Georg Baum wrote: > Scott Kostyshak wrote: > > > On Fri, Jun 19, 2015 at 07:03:14PM +0200, Juergen Spitzmueller wrote: > >> commit 46aed6d2b90cafed93a6ee996ec72c09a6325f92 > >> Author: Juergen Spitzmueller > >> Date: Fri Jun 19 19:02:35 2015 +0200 > >>

Re: [LyX/master] Refine lang nesting fix

2015-10-16 Thread Georg Baum
Scott Kostyshak wrote: > On Fri, Jun 19, 2015 at 07:03:14PM +0200, Juergen Spitzmueller wrote: >> commit 46aed6d2b90cafed93a6ee996ec72c09a6325f92 >> Author: Juergen Spitzmueller >> Date: Fri Jun 19 19:02:35 2015 +0200 >> >> Refine lang nesting fix >> > > After this commit I believe that

Re: [LyX/master] Refine lang nesting fix

2015-10-15 Thread Scott Kostyshak
On Fri, Jun 19, 2015 at 07:03:14PM +0200, Juergen Spitzmueller wrote: > commit 46aed6d2b90cafed93a6ee996ec72c09a6325f92 > Author: Juergen Spitzmueller > Date: Fri Jun 19 19:02:35 2015 +0200 > > Refine lang nesting fix > After this commit I believe that many tests fail (I have only checked