Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-27 Thread Scott Kostyshak
On Mon, Dec 27, 2021 at 09:55:11AM +0100, Jürgen Spitzmüller wrote: > Am Sonntag, dem 26.12.2021 um 12:15 -0500 schrieb Scott Kostyshak: > > Strangely I could not create an example (to put in tests) that fails > > to compile with 2.3.0 (no cprotect) but compiles with master (which > > uses cprotect

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-27 Thread Jürgen Spitzmüller
Am Sonntag, dem 26.12.2021 um 12:15 -0500 schrieb Scott Kostyshak: > Strangely I could not create an example (to put in tests) that fails > to compile with 2.3.0 (no cprotect) but compiles with master (which > uses cprotect). I wonder if a LaTeX figure improved this situation in > the last couple o

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-26 Thread Scott Kostyshak
On Sun, Dec 26, 2021 at 05:48:02PM +0100, Jean-Marc Lasgouttes wrote: > Le 23/12/2021 à 07:52, Jürgen Spitzmüller a écrit : > > Am Mittwoch, dem 22.12.2021 um 16:16 +0100 schrieb Jean-Marc > > Lasgouttes: > > > Jürgen, can you tell me what is the purpose of the test against math > > > insets? > >

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-26 Thread Jean-Marc Lasgouttes
Le 23/12/2021 à 04:05, Scott Kostyshak a écrit : Yes, that would be nice. I added a test at 87bea678. I'll add more files to that directory (autotests/export/latex/lyxbugs-resolved/cprotect) as I find them. Thanks for the tests. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-26 Thread Jean-Marc Lasgouttes
Le 23/12/2021 à 07:52, Jürgen Spitzmüller a écrit : Am Mittwoch, dem 22.12.2021 um 16:16 +0100 schrieb Jean-Marc Lasgouttes: Jürgen, can you tell me what is the purpose of the test against math insets? Some math insets need to be \cprotect'ed in macro arguments (e.g., captions). See https://ww

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-26 Thread Jean-Marc Lasgouttes
Le 21/12/2021 à 16:32, Jürgen Spitzmüller a écrit : Am Dienstag, dem 21.12.2021 um 15:45 +0100 schrieb Jean-Marc Lasgouttes: I could try to help with this, but for that I would have to understand what the code does (and what cprotect does). \cprotect allows to put verbatim context into places

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-25 Thread Scott Kostyshak
On Sun, Dec 26, 2021 at 02:27:12AM +0100, Thibaut Cuvelier wrote: > On Fri, 24 Dec 2021 at 03:39, Scott Kostyshak wrote: > > > On Fri, Dec 24, 2021 at 01:13:24AM +0100, Thibaut Cuvelier wrote: > > > On Fri, 24 Dec 2021 at 00:57, Thibaut Cuvelier > > wrote: > > > > > > > On Fri, 24 Dec 2021 at 00

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-25 Thread Thibaut Cuvelier
On Fri, 24 Dec 2021 at 03:39, Scott Kostyshak wrote: > On Fri, Dec 24, 2021 at 01:13:24AM +0100, Thibaut Cuvelier wrote: > > On Fri, 24 Dec 2021 at 00:57, Thibaut Cuvelier > wrote: > > > > > On Fri, 24 Dec 2021 at 00:50, Thibaut Cuvelier > wrote: > > > > > >> On Thu, 23 Dec 2021 at 22:26, Scott

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-23 Thread Scott Kostyshak
On Fri, Dec 24, 2021 at 01:13:24AM +0100, Thibaut Cuvelier wrote: > On Fri, 24 Dec 2021 at 00:57, Thibaut Cuvelier wrote: > > > On Fri, 24 Dec 2021 at 00:50, Thibaut Cuvelier wrote: > > > >> On Thu, 23 Dec 2021 at 22:26, Scott Kostyshak wrote: > >> > >>> On Thu, Dec 23, 2021 at 03:07:00PM -0500

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-23 Thread Scott Kostyshak
On Fri, Dec 24, 2021 at 12:57:20AM +0100, Thibaut Cuvelier wrote: > On Fri, 24 Dec 2021 at 00:50, Thibaut Cuvelier wrote: > > > On Thu, 23 Dec 2021 at 22:26, Scott Kostyshak wrote: > > > >> On Thu, Dec 23, 2021 at 03:07:00PM -0500, Scott Kostyshak wrote: > >> > On Thu, Dec 23, 2021 at 11:36:53AM

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-23 Thread Thibaut Cuvelier
On Fri, 24 Dec 2021 at 00:57, Thibaut Cuvelier wrote: > On Fri, 24 Dec 2021 at 00:50, Thibaut Cuvelier wrote: > >> On Thu, 23 Dec 2021 at 22:26, Scott Kostyshak wrote: >> >>> On Thu, Dec 23, 2021 at 03:07:00PM -0500, Scott Kostyshak wrote: >>> > On Thu, Dec 23, 2021 at 11:36:53AM +0100, Kornel

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-23 Thread Thibaut Cuvelier
On Fri, 24 Dec 2021 at 00:50, Thibaut Cuvelier wrote: > On Thu, 23 Dec 2021 at 22:26, Scott Kostyshak wrote: > >> On Thu, Dec 23, 2021 at 03:07:00PM -0500, Scott Kostyshak wrote: >> > On Thu, Dec 23, 2021 at 11:36:53AM +0100, Kornel Benko wrote: >> > > Am Wed, 22 Dec 2021 22:05:02 -0500 >> > > s

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-23 Thread Thibaut Cuvelier
On Thu, 23 Dec 2021 at 22:26, Scott Kostyshak wrote: > On Thu, Dec 23, 2021 at 03:07:00PM -0500, Scott Kostyshak wrote: > > On Thu, Dec 23, 2021 at 11:36:53AM +0100, Kornel Benko wrote: > > > Am Wed, 22 Dec 2021 22:05:02 -0500 > > > schrieb Scott Kostyshak : > > > > > > > On Wed, Dec 22, 2021 at

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-23 Thread Scott Kostyshak
On Thu, Dec 23, 2021 at 03:07:00PM -0500, Scott Kostyshak wrote: > On Thu, Dec 23, 2021 at 11:36:53AM +0100, Kornel Benko wrote: > > Am Wed, 22 Dec 2021 22:05:02 -0500 > > schrieb Scott Kostyshak : > > > > > On Wed, Dec 22, 2021 at 05:16:45PM +0100, Jean-Marc Lasgouttes wrote: > > > > Le 22/12/202

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-23 Thread Scott Kostyshak
On Thu, Dec 23, 2021 at 11:36:53AM +0100, Kornel Benko wrote: > Am Wed, 22 Dec 2021 22:05:02 -0500 > schrieb Scott Kostyshak : > > > On Wed, Dec 22, 2021 at 05:16:45PM +0100, Jean-Marc Lasgouttes wrote: > > > Le 22/12/2021 à 16:52, Scott Kostyshak a écrit : > > > > On Wed, Dec 22, 2021 at 04:16:

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-23 Thread Kornel Benko
Am Wed, 22 Dec 2021 22:05:02 -0500 schrieb Scott Kostyshak : > On Wed, Dec 22, 2021 at 05:16:45PM +0100, Jean-Marc Lasgouttes wrote: > > Le 22/12/2021 à 16:52, Scott Kostyshak a écrit : > > > On Wed, Dec 22, 2021 at 04:16:30PM +0100, Jean-Marc Lasgouttes wrote: > > > > > > > Do we have a cpro

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-22 Thread Jürgen Spitzmüller
Am Mittwoch, dem 22.12.2021 um 16:16 +0100 schrieb Jean-Marc Lasgouttes: > Jürgen, can you tell me what is the purpose of the test against math > insets? Some math insets need to be \cprotect'ed in macro arguments (e.g., captions). See https://www.lyx.org/trac/ticket/6243 Jürgen signature.asc D

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-22 Thread Scott Kostyshak
On Wed, Dec 22, 2021 at 05:16:45PM +0100, Jean-Marc Lasgouttes wrote: > Le 22/12/2021 à 16:52, Scott Kostyshak a écrit : > > On Wed, Dec 22, 2021 at 04:16:30PM +0100, Jean-Marc Lasgouttes wrote: > > > > > Do we have a cprotect torture test, BTW? > > > > We don't. But I could spend some time setti

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-22 Thread Jean-Marc Lasgouttes
Le 22/12/2021 à 16:52, Scott Kostyshak a écrit : On Wed, Dec 22, 2021 at 04:16:30PM +0100, Jean-Marc Lasgouttes wrote: Do we have a cprotect torture test, BTW? We don't. But I could spend some time setting these up. Just to make sure, you mean examples of .lyx files that need the cprotect fea

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-22 Thread Scott Kostyshak
On Wed, Dec 22, 2021 at 04:16:30PM +0100, Jean-Marc Lasgouttes wrote: > Do we have a cprotect torture test, BTW? We don't. But I could spend some time setting these up. Just to make sure, you mean examples of .lyx files that need the cprotect feature to compile without error, right? As mentioned

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-22 Thread Jean-Marc Lasgouttes
Le 21/12/2021 à 16:32, Jürgen Spitzmüller a écrit : Am Dienstag, dem 21.12.2021 um 15:45 +0100 schrieb Jean-Marc Lasgouttes: I could try to help with this, but for that I would have to understand what the code does (and what cprotect does). \cprotect allows to put verbatim context into places

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-21 Thread Jürgen Spitzmüller
Am Dienstag, dem 21.12.2021 um 15:45 +0100 schrieb Jean-Marc Lasgouttes: > I could try to help with this, but for that I would have to > understand what the code does (and what cprotect does). \cprotect allows to put verbatim context into places where this would normally be invalid (basically macr

Re: [LyX/master] Paragraph::needsCProtection(): use inset list

2021-12-21 Thread Jean-Marc Lasgouttes
Le 19/12/2021 à 15:13, Juergen Spitzmueller a écrit : commit 61b8afd893ecdbc15924aaf8f44014b41c5623ef Author: Juergen Spitzmueller Date: Sun Dec 19 15:39:49 2021 +0100 Paragraph::needsCProtection(): use inset list rather than checking each pos whether it's an inset or not.