Re: [LyX/master] Fix crash when citeengine is unknown.

2018-03-09 Thread Jürgen Spitzmüller
Am Donnerstag, den 08.03.2018, 16:32 -0500 schrieb Richard Heck: > Question that popped up while looking at this > > Is it possible for more than one citeengine to be loaded by a > document at one > time? No. > If so, how (other than by editing the LyX file itself)? Assuming it > is not > p

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-03-08 Thread Richard Heck
On 02/16/2018 12:24 PM, Jürgen Spitzmüller wrote: > 2018-02-16 18:05 GMT+01:00 Richard Heck >: > > On 02/14/2018 01:21 PM, Jürgen Spitzmüller wrote: > > Am Mittwoch, den 14.02.2018, 12:50 -0500 schrieb Richard Heck: > >> I wonder if what we really need to do here

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-02-16 Thread Jürgen Spitzmüller
2018-02-16 18:05 GMT+01:00 Richard Heck : > On 02/14/2018 01:21 PM, Jürgen Spitzmüller wrote: > > Am Mittwoch, den 14.02.2018, 12:50 -0500 schrieb Richard Heck: > >> I wonder if what we really need to do here is add the 'unknown' cite > >> engine the way we do unknown layouts. Otherwise, if, say,

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-02-16 Thread Richard Heck
On 02/14/2018 01:21 PM, Jürgen Spitzmüller wrote: > Am Mittwoch, den 14.02.2018, 12:50 -0500 schrieb Richard Heck: >> I wonder if what we really need to do here is add the 'unknown' cite >> engine the way we do unknown layouts. Otherwise, if, say, the font is >> modified in Document>Settings, then

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-02-14 Thread Jürgen Spitzmüller
Am Mittwoch, den 14.02.2018, 12:50 -0500 schrieb Richard Heck: > I wonder if what we really need to do here is add the 'unknown' cite > engine the way we do unknown layouts. Otherwise, if, say, the font is > modified in Document>Settings, then I am guessing we won't save the > document with the sam

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-02-14 Thread Richard Heck
On 02/14/2018 11:12 AM, Jürgen Spitzmüller wrote: > Am Mittwoch, den 14.02.2018, 10:11 -0500 schrieb Richard Heck: >>> I wonder how that happens. >> LyXCiteEngine const * CiteEnginesList::operator[](string const & str) >> const >> { >> LyXCiteEnginesList::const_iterator it = englist_.begin();

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-02-14 Thread Jürgen Spitzmüller
Am Mittwoch, den 14.02.2018, 10:11 -0500 schrieb Richard Heck: > > I wonder how that happens. > > LyXCiteEngine const * CiteEnginesList::operator[](string const & str) > const > { > LyXCiteEnginesList::const_iterator it = englist_.begin(); > for (; it != englist_.end(); ++it) > if

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-02-14 Thread Richard Heck
On 02/14/2018 03:04 AM, Jürgen Spitzmüller wrote: > Am Montag, den 12.02.2018, 16:31 -0500 schrieb Richard Heck: >>> src/frontends/qt4/GuiDocument.cpp |6 ++ >>> 1 files changed, 6 insertions(+), 0 deletions(-) >>> >>> diff --git a/src/frontends/qt4/GuiDocument.cpp >>> b/src/frontends/qt4/

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-02-14 Thread Jürgen Spitzmüller
Am Montag, den 12.02.2018, 16:31 -0500 schrieb Richard Heck: > > src/frontends/qt4/GuiDocument.cpp |6 ++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > diff --git a/src/frontends/qt4/GuiDocument.cpp > > b/src/frontends/qt4/GuiDocument.cpp > > index 85318bc..8149b50 100644 >

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-02-12 Thread Scott Kostyshak
On Mon, Feb 12, 2018 at 09:31:03PM +, Richard Heck wrote: > On 02/12/2018 04:27 PM, Richard Heck wrote: > > commit 5ee3396459602e0982234cab064c5c960af7e4fc > > Author: Richard Heck > > Date: Mon Feb 12 16:26:27 2018 -0500 > > > > Fix crash when citeengine is unknown. > > Scott, this is

Re: [LyX/master] Fix crash when citeengine is unknown.

2018-02-12 Thread Richard Heck
On 02/12/2018 04:27 PM, Richard Heck wrote: > commit 5ee3396459602e0982234cab064c5c960af7e4fc > Author: Richard Heck > Date: Mon Feb 12 16:26:27 2018 -0500 > > Fix crash when citeengine is unknown. Scott, this is also needed in 2.3.x. Trivial and completely safe crash-fix. Richard > ---