Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-11 Thread Jean-Marc Lasgouttes
Le 9 septembre 2024 19:01:09 GMT+02:00, "José Matos" a écrit : >On Mon, 2024-09-09 at 17:54 +0200, Jean-Marc Lasgouttes wrote: >> string const arg = (type.empty()) ? move(label) : move(label) + " " >> + type; > >I can understand the first move. That makes all the sense to me. > >I can not unde

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread José Matos
On Mon, 2024-09-09 at 17:54 +0200, Jean-Marc Lasgouttes wrote: > string const arg = (type.empty()) ? move(label) : move(label) + " " > + type; I can understand the first move. That makes all the sense to me. I can not understand why you use move and then add it to a chr * (that will be converted

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread Jürgen Spitzmüller
Am Montag, dem 09.09.2024 um 17:54 +0200 schrieb Jean-Marc Lasgouttes: > I am even tempted to use std::move() here to > point out that this is the standard library method and not just a > function of our own. Thankfully, Scott has done that for my commit at 0a7585403832c -- Jürgen -- lyx-dev

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread Jürgen Spitzmüller
Am Montag, dem 09.09.2024 um 17:55 +0200 schrieb Jean-Marc Lasgouttes: > The good thing is that we caught a few real bugs. It is not always > coverity being annoying. No, it is actually really helpful. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/lis

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2024 à 17:35, Scott Kostyshak a écrit : I see, good to know! Thanks to you and JMarc for taking on that seemingly never-ending task. The good thing is that we caught a few real bugs. It is not always coverity being annoying. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org h

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2024 à 16:47, Jürgen Spitzmüller a écrit : Am Montag, dem 09.09.2024 um 16:31 +0200 schrieb Scott Kostyshak: Just out of curiosity (no I don't want to receive the scan results ;)), are most of these from Coverity adding new features that detect new things? Or were they there before, and

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread Scott Kostyshak
On Mon, Sep 09, 2024 at 04:47:57PM GMT, Jürgen Spitzmüller wrote: > Am Montag, dem 09.09.2024 um 16:31 +0200 schrieb Scott Kostyshak: > > Just out of curiosity (no I don't want to receive the scan results > > ;)), > > are most of these from Coverity adding new features that detect new > > things? O

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread Jürgen Spitzmüller
Am Montag, dem 09.09.2024 um 16:31 +0200 schrieb Scott Kostyshak: > Just out of curiosity (no I don't want to receive the scan results > ;)), > are most of these from Coverity adding new features that detect new > things? Or were they there before, and you are whittling down the > list little by li

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread Scott Kostyshak
On Mon, Sep 09, 2024 at 01:54:05PM GMT, Jean-Marc Lasgouttes wrote: > Spotted by Coverity scan. Just out of curiosity (no I don't want to receive the scan results ;)), are most of these from Coverity adding new features that detect new things? Or were they there before, and you are whittling