Re: [LyX/master] Do not forget to set cursor current font when selecting

2017-10-12 Thread Scott Kostyshak
On Thu, Oct 12, 2017 at 07:16:13PM +, Jean-Marc Lasgouttes wrote: > Le 12/10/2017 à 01:29, Scott Kostyshak a écrit : > > > PS: I would not be surprised that there are other cases that I did not > > > catch. > > > > Could an assertion help catch more? > > Not really, since the cursor current c

Re: [LyX/master] Do not forget to set cursor current font when selecting

2017-10-12 Thread Jean-Marc Lasgouttes
Le 12/10/2017 à 01:29, Scott Kostyshak a écrit : On Wed, Oct 11, 2017 at 10:05:46AM +, Jean-Marc Lasgouttes wrote: So, shall I push to 2.3.x too? Yes, please. Thanks, done. JMarc

Re: [LyX/master] Do not forget to set cursor current font when selecting

2017-10-12 Thread Jean-Marc Lasgouttes
Le 12/10/2017 à 01:29, Scott Kostyshak a écrit : PS: I would not be surprised that there are other cases that I did not catch. Could an assertion help catch more? Not really, since the cursor current can be different from the font at position. This happens when the user uses C-e to switch to

Re: [LyX/master] Do not forget to set cursor current font when selecting

2017-10-11 Thread Scott Kostyshak
On Wed, Oct 11, 2017 at 10:05:46AM +, Jean-Marc Lasgouttes wrote: > So, shall I push to 2.3.x too? Yes, please. > PS: I would not be surprised that there are other cases that I did not > catch. Could an assertion help catch more? Scott signature.asc Description: PGP signature

Re: [LyX/master] Do not forget to set cursor current font when selecting

2017-10-11 Thread Jean-Marc Lasgouttes
Le 11/10/2017 à 12:01, Jean-Marc Lasgouttes a écrit : commit 88d0390724c60410dd680a2528eab5c91b1252ce Author: Jean-Marc Lasgouttes Date: Wed Oct 11 11:56:09 2017 +0200 Do not forget to set cursor current font when selecting Fix several unreleated cases where the `selecting' co