Re: [LyX/2.4.x] Cleanup MathMLStream

2024-07-23 Thread Enrico Forestieri
On Tue, Jul 23, 2024 at 12:18:08AM +0200, Jean-Marc Lasgouttes wrote: Le 22/07/2024 à 22:40, Enrico Forestieri a écrit : diff --git a/src/mathed/InsetMathChar.cpp b/src/mathed/InsetMathChar.cpp index 199982a5f7..82d0b63f1e 100644 --- a/src/mathed/InsetMathChar.cpp +++ b/src/mathed/InsetMathChar.

Re: [LyX/2.4.x] Cleanup MathMLStream

2024-07-23 Thread Enrico Forestieri
On Mon, Jul 22, 2024 at 11:34:31PM +0200, Jean-Marc Lasgouttes wrote: What are typically those systems? The platforms for which sizeof(wchar_t) == 2 (such as cygwin and mingw) or for which HAVE_WCHAR_T is not defined (possibly FreeBSD and others). I can introduce a MathML::put(c) method. It

Re: [LyX/2.4.x] Cleanup MathMLStream

2024-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2024 à 22:40, Enrico Forestieri a écrit : diff --git a/src/mathed/InsetMathChar.cpp b/src/mathed/InsetMathChar.cpp index 199982a5f7..82d0b63f1e 100644 --- a/src/mathed/InsetMathChar.cpp +++ b/src/mathed/InsetMathChar.cpp @@ -248,7 +248,7 @@ void InsetMathChar::mathmlize(MathMLStream & ms

Re: [LyX/2.4.x] Cleanup MathMLStream

2024-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2024 à 22:40, Enrico Forestieri a écrit : I don't understand the need for the two changes above. Note that on systems where sizeof(wchar_t) == 2, lyx::char_type is defined as a 32- bit value. So, with the above changes, char_ will be output as a number rather than a character. What a

Re: [LyX/2.4.x] Cleanup MathMLStream

2024-07-22 Thread Enrico Forestieri
On Mon, Jul 22, 2024 at 08:09:19PM +, Jean-Marc Lasgouttes wrote: commit 17bc6d05b327034c2034087978c2ebf9f8d9e469 Author: Jean-Marc Lasgouttes Date: Fri Jul 19 14:57:58 2024 +0200 Cleanup MathMLStream This is preparatory work for fixing ticket #13069. Remove direct accesses to