Re: [Final Patch] InsetListings ...

2007-05-11 Thread Peter Kümmel
Bo Peng wrote: >> Like this? This time also the ui file. >> > > I get > > In file included from src/frontends/qt4/QListings.h:16, > from src/frontends/qt4/Dialogs.cpp:70: > debug/common/frontends/qt4/ui/ListingsUi.h: In member function `void > Ui_QListingsUi::setupUi(QDialog*)': >

Re: [Final Patch] InsetListings ...

2007-05-10 Thread Bo Peng
On 5/10/07, Peter Kümmel <[EMAIL PROTECTED]> wrote: Bo Peng wrote: >> Like this? This time also the ui file. I get the same error. I guess I miss a header file somewhere and your cmake's pch stuff can not detect it. Bo

Re: [Final Patch] InsetListings ...

2007-05-10 Thread Peter Kümmel
Bo Peng wrote: >> Like this? This time also the ui file. >> > With attached ui file I get attached dialog. Does it still not work? Peter QListingsUi Qt::ApplicationModal 0 0 448 417 Listing true 6

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Bo Peng
Like this? This time also the ui file. I get In file included from src/frontends/qt4/QListings.h:16, from src/frontends/qt4/Dialogs.cpp:70: debug/common/frontends/qt4/ui/ListingsUi.h: In member function `void Ui_QListingsUi::setupUi(QDialog*)': debug/common/frontends/qt4/ui/Lis

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Peter Kümmel
Bo Peng wrote: >> There is a big gray area below the second text field. >> Could you test the .ui patch I send to the list? > > I can not find any attachment of yours from this thread. Could you > please fix the layout and commit? > > For this TextLayout panel, I think two textedit/browser can be

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Edwin Leuven
patch for listingsui.ui and textlayout.ui attached (will be offline until sunday...) Bo Peng wrote: Index: src/frontends/qt4/ui/ListingsUi.ui === The patch can not be cleanly applied here... I guess you will have to open designer

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Bo Peng
Index: src/frontends/qt4/ui/ListingsUi.ui === The patch can not be cleanly applied here... I guess you will have to open designer and repeat what you have done again. Sorry about the inconvenience. Bo

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Peter Kümmel
Bo Peng wrote: >> There is a big gray area below the second text field. >> Could you test the .ui patch I send to the list? > > I can not find any attachment of yours from this thread. Could you > please fix the layout and commit? "reply all" > > For this TextLayout panel, I think two texte

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Bo Peng
There is a big gray area below the second text field. Could you test the .ui patch I send to the list? I can not find any attachment of yours from this thread. Could you please fix the layout and commit? For this TextLayout panel, I think two textedit/browser can be put side by side to save som

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Peter Kümmel
Bo Peng wrote: > On 5/9/07, Edwin Leuven <[EMAIL PROTECTED]> wrote: >> layout of text layout in document settings is broken... > > What exactly is broken? The dialog is too small for two editboxes, but > I can set parameters there. > > Bo > There is a big gray area below the second text field.

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Bo Peng
Here the insert is always centered and sometimes it is labeled as "ERT". I just noticed and fixed it. Centered is normal diaplyed listing. If you need inline listing, check inline from the listings dialog. Bo

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Bo Peng
On 5/9/07, Edwin Leuven <[EMAIL PROTECTED]> wrote: layout of text layout in document settings is broken... What exactly is broken? The dialog is too small for two editboxes, but I can set parameters there. Bo

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Peter Kümmel
Bo Peng wrote: >> Please wait for a day and then you can commit. > > An update patch has been committed. lyx2lyx seems to work but I could > not test it because of the armtex.sty problem. The dialogs are ugly > but I can live with it. I am especially happy with the validation > system which can

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Edwin Leuven
layout of text layout in document settings is broken... Bo Peng wrote: Please wait for a day and then you can commit. An update patch has been committed. lyx2lyx seems to work but I could not test it because of the armtex.sty problem. The dialogs are ugly but I can live with it. I am especia

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Bo Peng
Please wait for a day and then you can commit. An update patch has been committed. lyx2lyx seems to work but I could not test it because of the armtex.sty problem. The dialogs are ugly but I can live with it. I am especially happy with the validation system which can actually help some listing

RE: [Final Patch] InsetListings ...

2007-05-09 Thread Leuven, E.
PROTECTED] Sent: Wed 5/9/07 16:57 To: Leuven, E. Subject: Re: [Final Patch] InsetListings ... > and another one... The first QTextBrowser is too big and I can not resize it to a small size. Because it only displays error messages, I guess I actually need a multi-line label with scroll box. At le

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Bo Peng
as in attached? Yes. If I 'layout' the two editboxes in group box. The first box resizes and I can not resize it back to a smaller size after 'layout'ing. I guess I should choose two editboxes *and* the group box and layout them, but the first editbox still resizes. Bo

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Bo Peng
The question, basically, is why you're making use of getOptions. My understanding was that getOptions and setOptions (and some other things) were scheduled for removal because they're some kind of relic of an older way in which insets interacted with parameters. (There are other routines in the sa

RE: [Final Patch] InsetListings ...

2007-05-09 Thread Leuven, E.
as in attached? -Original Message- From: Bo Peng [mailto:[EMAIL PROTECTED] Sent: Wed 5/9/07 16:23 To: Andre Poenitz Cc: Peter Kümmel; LyX Devel List Subject: Re: [Final Patch] InsetListings ... > The groupbox itself needs a layout. If there's only one item in there > (the l

Re: [Final Patch] InsetListings ...

2007-05-09 Thread Bo Peng
The groupbox itself needs a layout. If there's only one item in there (the lineedit) it doesn't really matter which kind of layout, but one is needed... 1. create a new dialog 2. put a push button 3. put a group box 4. put a lineedit in group box 5. put another lineedit in group box 6. select t

Re: [Final Patch] InsetListings ...

2007-05-08 Thread Andre Poenitz
On Tue, May 08, 2007 at 05:04:27PM -0500, Bo Peng wrote: > >Starting with your ui file I get a design which seems ok when I click > >1. in the QGroupBoxlayout->vertical (then I see the narrow band) > >2. again layout->vertical on the empty space on the right of the QGroupBox > >3. and change the si

Re: [Final Patch] InsetListings ...

2007-05-08 Thread Bo Peng
Starting with your ui file I get a design which seems ok when I click 1. in the QGroupBoxlayout->vertical (then I see the narrow band) 2. again layout->vertical on the empty space on the right of the QGroupBox 3. and change the sizePolicy property of listingTB to expanding This seems to work and

Re: [Final Patch] InsetListings ...

2007-05-08 Thread Peter Kümmel
Bo Peng wrote: >> +bool InsetListingsParams::fromEncodedString(string const & in) >> +{ >> + // Decode string! >> + // Do nothing because " was silently ignored. >> + setParams(in); >> +} >> >> msvc needs a return value. > > Thanks. I will correct that. bool was used in many plac

Re: [Final Patch] InsetListings ...

2007-05-08 Thread Bo Peng
+bool InsetListingsParams::fromEncodedString(string const & in) +{ + // Decode string! + // Do nothing because " was silently ignored. + setParams(in); +} msvc needs a return value. Thanks. I will correct that. bool was used in many places to see if a parameter string is corre

Re: [Final Patch] InsetListings ...

2007-05-08 Thread Peter Kümmel
Bo Peng wrote: > Dear all, > > I have spent another two days on the InsetListings patch, trying to > make the GUI more usable. What I get is a validation system that > reports to QInclude, QListings and QDocument exactly what is wrong > with the params string (through exception). With the attached

Re: [Final Patch] InsetListings ...

2007-05-08 Thread Peter Kümmel
José Matos wrote: > On Tuesday 08 May 2007 21:51:29 Bo Peng wrote: >> With this validation system in place, I will stop working on this >> feature until I get an OK to proceed. > > You have an OK to proceed, but I would like to hear more feedback from the > list to the technical details of the

Re: [Final Patch] InsetListings ...

2007-05-08 Thread José Matos
On Tuesday 08 May 2007 21:51:29 Bo Peng wrote: > With this validation system in place, I will stop working on this > feature until I get an OK to proceed. You have an OK to proceed, but I would like to hear more feedback from the list to the technical details of the patches. Please wait for