Re: [Final PATCH] session/toolbar

2006-11-02 Thread Bo Peng
> - The status of the toolbars can only be changed when a document is loaded. > - Changing the status of a toolbar modifies the changed status of the > document. > - Maybe the toolbars should not be numerated in the menu and their first > letter capitalized. When you first turn 'on' a toolbar

Re: [Final PATCH] session/toolbar

2006-11-02 Thread John Levon
On Thu, Nov 02, 2006 at 09:00:45PM +0100, Enrico Forestieri wrote: > - The status of the toolbars can only be changed when a document is loaded. > - Changing the status of a toolbar modifies the changed status of the > document. > - Maybe the toolbars should not be numerated in the menu and thei

Re: [Final PATCH] session/toolbar

2006-11-02 Thread Enrico Forestieri
On Fri, Nov 03, 2006 at 10:13:47AM +1800, Bo Peng wrote: > The session/toolbar patch have been committed to the trunk. Please > test and comment. Good work, Bo ;-) Some comments: - The status of the toolbars can only be changed when a document is loaded. - Changing the status of a toolbar modif

Re: [Final PATCH] session/toolbar

2006-11-02 Thread Bo Peng
Yes, I could do it in the next days. Maybe I try to add the Auto option instead of removing the complete popup. Since ToolbarBackend::Flags will always reflect the true toolbar status, I have modified the view->toolbars display as standard etc, two states: on standard off standard review

Re: [Final PATCH] session/toolbar

2006-11-02 Thread Bo Peng
When I evtl. add the Auto option, I will make sure that the menu is always up to date. Yes, just remember to update ToolbarBackend::Flags so MenuBackends::expandToolbars() can get the correct status. Thanks. Bo

Re: [Final PATCH] session/toolbar

2006-11-02 Thread Peter Kümmel
> OK. Peter, could you please remove this popup for me? It will take me > much longer than you to do this. Yes, I could do it in the next days. Maybe I try to add the Auto option instead of removing the complete popup. > Also, if there is no other way to turn on/off toolbar than > view->toolbar,

Re: [Final PATCH] session/toolbar

2006-11-02 Thread Bo Peng
The popup could be disabled by reimplementing createPopouMenu in GuiView.C http://doc.trolltech.com/4.2/qmainwindow.html#createPopupMenu You could try returning just a QMenu() or QWidget() to disbale the popup. OK. Peter, could you please remove this popup for me? It will take me much longer

Re: [Final PATCH] session/toolbar

2006-11-02 Thread Juergen Spitzmueller
Bo Peng wrote: > This will be less confusing indeed. But do people in general agree to > remove it? I do. I think the popup is just not suited for our needs, as opposed to your menu entry (apparently -- I didn't have time to have a look at it yet). Jürgen

Re: [Final PATCH] session/toolbar

2006-11-02 Thread Bo Peng
The popup could be disabled by reimplementing createPopouMenu in GuiView.C This will be less confusing indeed. But do people in general agree to remove it? Bo

Re: [Final PATCH] session/toolbar

2006-11-02 Thread Peter Kümmel
Bo Peng wrote: > Dear all, > > http://www.lyx.org/trac/changeset/15688 > > As far as I can tell, I have solved the three state toolbar chaos > completely by introducing this view->toolbar menu and > LFUN_TOOLBAR_TOGGLE_STATE lfunc. If there is no objection, I will > apply both patches tomorrow to

Re: [Final PATCH] session/toolbar

2006-11-02 Thread Bo Peng
Dear all, The session/toolbar patch have been committed to the trunk. Please test and comment. Features to test: 1. turn toolbar on/off, move it around, and see if session can restore them correctly. 2. view->toolbar toggle on/off, and in the math/table/review cases, toggle on/off/auto. You may

Re: [Final PATCH] session/toolbar

2006-11-01 Thread Bo Peng
Dear all, http://www.lyx.org/trac/changeset/15688 As far as I can tell, I have solved the three state toolbar chaos completely by introducing this view->toolbar menu and LFUN_TOOLBAR_TOGGLE_STATE lfunc. If there is no objection, I will apply both patches tomorrow to attract more testing. Interes

[Final PATCH] session/toolbar

2006-11-01 Thread Bo Peng
Hi, Lars (and others), Attached is the patch you can beat. It will be committed tomorrow. It works well here, except for the on/off/auto state change, which needs frontend support. This patch: 1. toolbar has on/off/auto states, (see session.h) 2. I have added an AUTO flag to Toolbar. MATH etc wi