> Signal in the core, dialogs connect to that... makes 3 lines of code
> plus 1 per connecting dialog.
The problem is where to emit the signal. If I do that at the inset
level, and emit the signal whenever an inset is created, modified and
removed, it may not be efficient because insets get create
On Sat, Sep 15, 2007 at 01:55:24PM -0500, Bo Peng wrote:
> > I will commit if there is no objection.
>
> Done. I have only done this for InsetGraphics. Other insets like
> InsetExternal and InsetBibtex will wait.
>
> Now, the only problem left is when to update the embedding dialog. I
> am reluct
> I will commit if there is no objection.
Done. I have only done this for InsetGraphics. Other insets like
InsetExternal and InsetBibtex will wait.
Now, the only problem left is when to update the embedding dialog. I
am reluctant to implement a full auto-update facility, that update
this dialog w
> The attached patch:
>
Here it is.
Bo
Index: src/insets/InsetGraphicsParams.h
===
--- src/insets/InsetGraphicsParams.h (revision 20282)
+++ src/insets/InsetGraphicsParams.h (working copy)
@@ -17,6 +17,7 @@
#include "graphics/Graphic
> Sounds like a plan?
>
The attached patch:
1. Use EmbeddedFile for InsetGraphicsParams::filename. This involves
params2string and file format change.
2. Because InsetGraphics now has embedding information, it can be
easily updated from the embedding dialog. The inset graphic dialog now
has an e
> Attached is an updated patch, which is even uglier because it tries to
> display 'Embedded:/filename' in the graphic dialog when the file is
> embedded. As you can imagine, back and forth translations are needed.
I am actually waiting for someone to say ' this is way too ugly. Why
do not you mer
> Here is a question for you: Do you want to display true, embedded
> filename, or the may-not-exist external filename in the graphics
> dialog? The attached patch does the former, but in a ugly way:
>
Attached is an updated patch, which is even uglier because it tries to
display 'Embedded:/filena
Here is a question for you: Do you want to display true, embedded
filename, or the may-not-exist external filename in the graphics
dialog? The attached patch does the former, but in a ugly way:
1. call updateDialog("graphics"); in setEmbed().
LFUN_INSET_DIALOG_UPDATE is triggered as expected.
2.
