Re: [Cvslog] r24244 - in /lyx-devel/trunk/src/tex2lyx: Parser.cpp Pars...

2008-04-16 Thread Uwe Stöhr
Jean-Marc Lasgouttes schrieb: > Your getParenthesesOpt function has a problem: since it is modelled > after getOpt(), it allows for an optional argument. But () arguments > are not optional in general. Yes they are required, but the function uses the Parser::getFullArg function which is valid fo

Re: [Cvslog] r24244 - in /lyx-devel/trunk/src/tex2lyx: Parser.cpp Pars...

2008-04-16 Thread Jean-Marc Lasgouttes
Uwe Stöhr <[EMAIL PROTECTED]> writes: >> I think the new method is not needed because direct code is almost as >> compact. >> Moreover, it is better IMO to keep the Parser interface small. > > But getting an option that is in parentheses will surely be useful for > the future as well, therefore I

Re: [Cvslog] r24244 - in /lyx-devel/trunk/src/tex2lyx: Parser.cpp Pars...

2008-04-16 Thread Uwe Stöhr
> I think the new method is not needed because direct code is almost as compact. > Moreover, it is better IMO to keep the Parser interface small. But getting an option that is in parentheses will surely be useful for the future as well, therefore I didn't use the direct code but introduced this

Re: [Cvslog] r24244 - in /lyx-devel/trunk/src/tex2lyx: Parser.cpp Pars...

2008-04-16 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] writes: > Author: uwestoehr > Date: Sat Apr 12 14:50:04 2008 > New Revision: 24244 > > URL: http://www.lyx.org/trac/changeset/24244 > Log: > tex2lyx: text.cpp, Parser.h, Parser.cpp: >fix the import of \makebox, fixes > http://bugzilla.lyx.org/show_bug.cgi?id=2504 Uwe, I hav