Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Peter Kümmel
Andre Poenitz wrote: On Sun, Dec 02, 2007 at 08:54:32PM +0100, Peter Kümmel wrote: The only thing I see is that we must not delete the C string after calling putenv, IIRC that's indeed the requierment. Patch looks ok. Index: support/environment.cpp ===

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 08:54:32PM +0100, Peter Kümmel wrote: > The only thing I see is that we must not delete the C string after > calling putenv, IIRC that's indeed the requierment. Patch looks ok. > Index: support/environment.cpp > =

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Peter Kümmel
Andre Poenitz wrote: #elif defined (HAVE_PUTENV) - static std::map varmap; + static std::map > varmap; string envstr = name + '=' + encoded; - char * newptr = new char[envstr.size() + 1]; - envstr.copy(newptr, envstr.length()); - newptr[envstr.length()] = '

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 07:42:17PM +0100, Peter Kümmel wrote: >>> --- lyx-devel/trunk/src/support/environment.cpp (original) >>> +++ lyx-devel/trunk/src/support/environment.cpp Sat Dec 1 11:52:52 2007 >>> @@ -18,6 +18,7 @@ >>> #include "support/os.h" >>> #include >>> +#include >>> #include

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Peter Kümmel
Andre Poenitz wrote: On Sat, Dec 01, 2007 at 10:52:52AM -, [EMAIL PROTECTED] wrote: Author: kuemmel Date: Sat Dec 1 11:52:52 2007 New Revision: 21898 URL: http://www.lyx.org/trac/changeset/21898 Log: fix memory leak Modified: lyx-devel/trunk/src/support/environment.cpp Modified: lyx-

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-01 Thread Andre Poenitz
On Sat, Dec 01, 2007 at 10:52:52AM -, [EMAIL PROTECTED] wrote: > Author: kuemmel > Date: Sat Dec 1 11:52:52 2007 > New Revision: 21898 > > URL: http://www.lyx.org/trac/changeset/21898 > Log: > fix memory leak > > Modified: > lyx-devel/trunk/src/support/environment.cpp > > Modified: lyx-