Re: [Cvslog] r21631 [1/3] - in /lyx-devel/trunk/src: Buffer.cpp Buffer...

2007-11-17 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > How so? Defining to nothing would have left the << ... << endl; tail > in the code leaving it incompilable. Using the nullstream is not > time neutral as arguments still need construction/destruction. If I output if (false) lyxerr << ... I certainly ho

Re: [Cvslog] r21631 [1/3] - in /lyx-devel/trunk/src: Buffer.cpp Buffer...

2007-11-17 Thread Andre Poenitz
On Fri, Nov 16, 2007 at 09:35:51AM +0100, Jean-Marc Lasgouttes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > [...] > > - easy to shortcut for timing purposes by using #define LYXERR(a, b) > > /*nothing*/ > > The same holds for the old version. How so? Defining to nothing would have left t

Re: [Cvslog] r21631 [1/3] - in /lyx-devel/trunk/src: Buffer.cpp Buffer...

2007-11-16 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > - shorter to type by 10 characters, Bah. > - less visual clutter, in quite a few cases no multi-line statements > are needed anymore, Hmm. > - now if-else safe by using the do { ... } while (0) idiom, OK. > - we can have BOOST_FUNCTION and/or so

Re: [Cvslog] r21631 [1/3] - in /lyx-devel/trunk/src: Buffer.cpp Buffer...

2007-11-15 Thread Andre Poenitz
On Thu, Nov 15, 2007 at 10:03:02PM +0100, Jean-Marc Lasgouttes wrote: > [EMAIL PROTECTED] writes: > > > Author: poenitz > > Date: Thu Nov 15 21:04:51 2007 > > New Revision: 21631 > > > > URL: http://www.lyx.org/trac/changeset/21631 > > Log: > > reduce line noise > > Buffer::Buffer(string const &

Re: [Cvslog] r21631 [1/3] - in /lyx-devel/trunk/src: Buffer.cpp Buffer...

2007-11-15 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] writes: > Author: poenitz > Date: Thu Nov 15 21:04:51 2007 > New Revision: 21631 > > URL: http://www.lyx.org/trac/changeset/21631 > Log: > reduce line noise > Buffer::Buffer(string const & file, bool readonly) > : pimpl_(new Impl(*this, FileName(file), readonly)), gui_(0)