Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-10-05 Thread Abdelrazak Younes
Andre Poenitz wrote: On Tue, Oct 03, 2006 at 10:22:50AM +0200, Abdelrazak Younes wrote: So, you reckon we should move bufferlist to the LyX class maybe? The one Lars wanted to merge with Application? The one I wanted to merge with Application. But it turned out that you (and Lars probably)

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-10-04 Thread Andre Poenitz
On Tue, Oct 03, 2006 at 10:22:50AM +0200, Abdelrazak Younes wrote: > So, you reckon we should move bufferlist to the LyX class maybe? The one Lars wanted to merge with Application? > Something accessed with LyX::bufferList()... > If yes, I'll do the change... > > As you see I am still opposed t

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-10-03 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Sep 28, 2006 at 07:51:21PM +0200, Abdelrazak Younes wrote: Andre Poenitz wrote: On Thu, Sep 28, 2006 at 12:45:50PM +0200, Abdelrazak Younes wrote: The best option is to remove the need for (non const) access to this BufferList. I think Buffer creation/deletion shou

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-10-02 Thread Andre Poenitz
On Thu, Sep 28, 2006 at 07:51:21PM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Thu, Sep 28, 2006 at 12:45:50PM +0200, Abdelrazak Younes wrote: > >>The best option is to remove the need for (non const) access to this > >>BufferList. I think Buffer creation/deletion should be done b

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Sep 28, 2006 at 12:45:50PM +0200, Abdelrazak Younes wrote: The best option is to remove the need for (non const) access to this BufferList. I think Buffer creation/deletion should be done by the frontend not the kernel. The kernel could ask for a new buffer via a s

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Andre Poenitz
On Thu, Sep 28, 2006 at 12:45:50PM +0200, Abdelrazak Younes wrote: > The best option is to remove the need for (non const) access to this > BufferList. I think Buffer creation/deletion should be done by the > frontend not the kernel. The kernel could ask for a new buffer via a > signal for examp

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Andre Poenitz
On Thu, Sep 28, 2006 at 10:28:10AM +0200, Lars Gullik Bjønnes wrote: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > | > I wonder whether it might be better style to pass bufferlist as > | > argument > | > to the function instead of accessing a singleton. > | > | Agreed. Next step. > > I am

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Andre Poenitz
On Thu, Sep 28, 2006 at 09:49:22AM +0200, Abdelrazak Younes wrote: > >Could you please add '-c' to your diff options so that we can see in > >which function these changes are. > > I didn't manage to configure tortoiseSVN to do that. Next time I will > try to generate the diff by hand (but it is v

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > I wonder whether it might be better style to pass bufferlist as | > argument | > to the function instead of accessing a singleton. | | Agreed. Next step. I am not sure that I agree. A singleton is special... there is

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > I wonder whether it might be better style to pass bufferlist as | > argument | > to the function instead of accessing a singleton. | | Agreed. Next step. I am not sure that I agree. A singleton is special... there is only one, not the case is not

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: I didn't manage to configure tortoiseSVN to do that. Next time I will try to generate the diff by hand (but it is very cumbersome). What happens if you install GNU diff and enter it (with the -p argument that makes it show the function names) in Tort

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Georg Baum
Abdelrazak Younes wrote: > I didn't manage to configure tortoiseSVN to do that. Next time I will > try to generate the diff by hand (but it is very cumbersome). What happens if you install GNU diff and enter it (with the -p argument that makes it show the function names) in TortoiseSVN->Settings-

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, Sep 27, 2006 at 10:24:15AM -, [EMAIL PROTECTED] wrote: URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/BufferView.C?rev=15161 == --- lyx-devel/trunk/src/BufferView.C (original) +++

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-28 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, Sep 27, 2006 at 10:24:15AM -, [EMAIL PROTECTED] wrote: URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/BufferView.C?rev=15161 == --- lyx-devel/trunk/src/BufferView.C (original) +++

Re: [Cvslog] r15161 - in /lyx-devel/trunk/src: BufferView.C LaTeX.C Me...

2006-09-27 Thread Andre Poenitz
On Wed, Sep 27, 2006 at 10:24:15AM -, [EMAIL PROTECTED] wrote: > URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/BufferView.C?rev=15161 > == > --- lyx-devel/trunk/src/BufferView.C (original) > +++ lyx-devel/trunk/