Re: [Bug 4334] Crash when adding label to math.

2007-11-07 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: >> I propose to apply my patch to fix the crash and to clear up the methods >> later. > > OK. Done. Jürgen

Re: [Bug 4334] Crash when adding label to math.

2007-11-07 Thread Jean-Marc Lasgouttes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > Jean-Marc Lasgouttes wrote: > >> We have two different methods for insets: plaintext and textString. >> They are called in different cases (I am not sure what the exact >> contexts are, to be frank). If we managed to give them differetn and >> cle

Re: [Bug 4334] Crash when adding label to math.

2007-11-07 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > We have two different methods for insets: plaintext and textString. > They are called in different cases (I am not sure what the exact > contexts are, to be frank). If we managed to give them differetn and > clear semantics, we would have the tool we need. Yes. Howev

Re: [Bug 4334] Crash when adding label to math.

2007-11-07 Thread Jean-Marc Lasgouttes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > Jean-Marc Lasgouttes wrote: > >> What about using subst (on docstring) to replace \n with space? > > I've done that, but it gives very ugly results (basically the whole matrix > mangled in one line, including the LaTeX tags). I think we cannot pro

Re: [Bug 4334] Crash when adding label to math.

2007-11-07 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > What about using subst (on docstring) to replace \n with space? I've done that, but it gives very ugly results (basically the whole matrix mangled in one line, including the LaTeX tags). I think we cannot provide anything useful for matrices anyway (it should return

Re: [Bug 4334] Crash when adding label to math.

2007-11-07 Thread Jean-Marc Lasgouttes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > Juergen Spitzmueller wrote: > >> Quick fix attached. > > This one gives better label string proposals. What about using subst (on docstring) to replace \n with space? JMarc

Re: [Bug 4334] Crash when adding label to math.

2007-11-07 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Quick fix attached. This one gives better label string proposals. Jürgen Index: src/Text.cpp === --- src/Text.cpp (Revision 21475) +++ src/Text.cpp (Arbeitskopie) @@ -90,6 +90,7 @@ using support::conta

Re: [Bug 4334] Crash when adding label to math.

2007-11-07 Thread Juergen Spitzmueller
Darren Freeman wrote: > another mathed-related crash in branch. > > http://bugzilla.lyx.org/show_bug.cgi?id=4334 The problem is that the string which is returned by math matrix via inset.asString() and which is used by getPossibleLabel contains linebreaks that are not allowed in this context. Q

[Bug 4334] Crash when adding label to math.

2007-11-06 Thread Darren Freeman
Hi all, another mathed-related crash in branch. http://bugzilla.lyx.org/show_bug.cgi?id=4334 Somebody please confirm and add the keyword "crash". Have fun, Darren