Re: A change to the ButtonController. Was: Re: [BUG] citation dialog

2001-06-29 Thread Allan Rae
On 28 Jun 2001, Jean-Marc Lasgouttes wrote: > I see I have not applied this yet. Should it be done? It doesn't seem to break anything but I'm not convinced it is the best fix. But it's already in 1.2.0cvs so if you add this to 1.1.6 then porting the next patch should be easier. Allan. (ARRae)

Re: A change to the ButtonController. Was: Re: [BUG] citation dialog

2001-06-28 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> I change the title of this mail as the proposed patch changes Angus> the ButtonController and I think that Allan should be made Angus> aware of it! Angus> The problem lies (as ever) with the button controller. Angus> Specifically,

Re: A change to the ButtonController. Was: Re: [BUG] citation dialog

2001-06-03 Thread Allan Rae
On Fri, 1 Jun 2001, Angus Leeming wrote: > On Friday 01 June 2001 04:26, Allan Rae wrote: > > > The problem lies (as ever) with the button controller. Specifically, the > > > state of all widgets in the list of read_only widgets is refreshed every > > > time we input anything. Clearly, they shoul

Re: A change to the ButtonController. Was: Re: [BUG] citation dialog

2001-06-01 Thread Angus Leeming
On Friday 01 June 2001 04:26, Allan Rae wrote: > > The problem lies (as ever) with the button controller. Specifically, the > > state of all widgets in the list of read_only widgets is refreshed every > > time we input anything. Clearly, they should be refreshed only when > > the read-only status

Re: A change to the ButtonController. Was: Re: [BUG] citation dialog

2001-05-31 Thread Allan Rae
On Wed, 30 May 2001, Angus Leeming wrote: > On Wednesday 30 May 2001 14:33, Jean-Marc Lasgouttes wrote: > > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > > > Angus> does the attached patch do what you want? If so, can I leave > > Angus> this for you to apply to head and to 1.1.6?

A change to the ButtonController. Was: Re: [BUG] citation dialog

2001-05-30 Thread Angus Leeming
On Wednesday 30 May 2001 14:33, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> does the attached patch do what you want? If so, can I leave > Angus> this for you to apply to head and to 1.1.6? > > Close, but not perfect. If I am in a section (

Re: [BUG] citation dialog

2001-05-30 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> does the attached patch do what you want? If so, can I leave Angus> this for you to apply to head and to 1.1.6? Close, but not perfect. If I am in a section (where Left and Block are allowed (for an unknown reason BTW)) and select

Re: [BUG] citation dialog

2001-05-30 Thread Angus Leeming
On Friday 25 May 2001 17:06, Jean-Marc Lasgouttes wrote: > Thanks. While we are at it, another wish: in the paragraph layout > form, the align buttons should be disabled depending on the > AlignPossible entry in the Layout. Could you do that? It would give a > much better feedback to users. > An

Re: [BUG] citation dialog

2001-05-29 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: >> Sorry but your previous patch has already been applied. Could you >> update it? Angus> Here it is. Thanks. Applied. JMarc

Re: [BUG] citation dialog

2001-05-25 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Is this HEAD or BRANCH_1_1_6? Angus Head is obvously the most important, but &.1.6 would be nice too. JMarc, starring at the sea with his laptop on his lap, as it should...

Re: [BUG] citation dialog

2001-05-23 Thread Angus Leeming
On Wednesday 23 May 2001 15:52, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Interesting. No, it's not intended. The patch attached fixes > Angus> that. I may have to port THIS particular patch to the HEAD too. > Angus> H! > > Thanks. Wh

Re: [BUG] citation dialog

2001-05-23 Thread Angus Leeming
On Wednesday 23 May 2001 15:54, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Interesting. No, it's not intended. The patch attached fixes > Angus> that. I may have to port THIS particular patch to the HEAD too. > Angus> H! > > Sorry but

Re: [BUG] citation dialog

2001-05-23 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Interesting. No, it's not intended. The patch attached fixes Angus> that. I may have to port THIS particular patch to the HEAD too. Angus> H! Sorry but your previous patch has already been applied. Could you update it? (and yo

Re: [BUG] citation dialog

2001-05-23 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Interesting. No, it's not intended. The patch attached fixes Angus> that. I may have to port THIS particular patch to the HEAD too. Angus> H! Thanks. While we are at it, another wish: in the paragraph layout form, the align bu

Re: [BUG] citation dialog

2001-05-23 Thread Angus Leeming
On Wednesday 23 May 2001 14:01, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Here's the patch fixing the problem (does not exist in HEAD). > > A remark: now, when I have an empty document and open the popup, > OK/Apply are enabled. Is that i

Re: [BUG] citation dialog

2001-05-23 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Here's the patch fixing the problem (does not exist in HEAD). Angus> Jean-Marc, perhaps you'd like to commit it to the 1.1.6 branch, Angus> just in case there's ever a 1.1.6fix3? I'm currently doing that. This 1.1.6fix3 will prob

Re: [BUG] citation dialog

2001-05-23 Thread Angus Leeming
On Wednesday 23 May 2001 07:03, Ben Stanley wrote: > Hi, > > I noticed this problem with lyx-1.1.6fix1, but didn't report it (bad, > bad boy...). Now I notice it's still there in lyx-1.1.6fix2. > > When you open a citation dialog on an existing citation with a "Text > after", and edit just the

[BUG] citation dialog

2001-05-22 Thread Ben Stanley
Hi, I noticed this problem with lyx-1.1.6fix1, but didn't report it (bad, bad boy...). Now I notice it's still there in lyx-1.1.6fix2. When you open a citation dialog on an existing citation with a "Text after", and edit just the "Text after", you cannot press OK and you cannot press apply. T