Le 06/11/2015 05:42, Vincent van Ravesteijn a écrit :
The fact that the setting was set in BufferView, the fact that it didn't
call markDirty or recordUndo, all tell me that this setting was not
supposed to be a document property.
Historically, lots of thing that required only a buffer and no v
Le 05/11/2015 22:44, Richard Heck a écrit :
OK, try this one.
Only 12 minutes, you're a fast learner :) The patch looks perfect to me.
One advantage of moving stuff to the Buffer class is that it is
available for command-line changes (although toggling by command line is
less useful than act
Op 5 nov. 2015 22:44 schreef "Richard Heck" :
>
> On 11/05/2015 04:02 PM, Jean-Marc Lasgouttes wrote:
>>
>> Le 05/11/15 21:41, Richard Heck a écrit :
>>>
>>> Trivial fix:
>>
>>
>> > case LFUN_CHANGES_TRACK:
>> > buffer_.params().track_changes =
>> > !buffer_.params().track
On 11/05/2015 04:02 PM, Jean-Marc Lasgouttes wrote:
Le 05/11/15 21:41, Richard Heck a écrit :
Trivial fix:
> case LFUN_CHANGES_TRACK:
> buffer_.params().track_changes =
> !buffer_.params().track_changes;
> + buffer().markDirty();
Va de retro, satanas! N
On 11/05/2015 04:02 PM, Jean-Marc Lasgouttes wrote:
Le 05/11/15 21:41, Richard Heck a écrit :
Trivial fix:
> case LFUN_CHANGES_TRACK:
> buffer_.params().track_changes =
> !buffer_.params().track_changes;
> + buffer().markDirty();
Va de retro, satanas! N
Le 05/11/15 21:41, Richard Heck a écrit :
Trivial fix:
> case LFUN_CHANGES_TRACK:
> buffer_.params().track_changes =
> !buffer_.params().track_changes;
> + buffer().markDirty();
Va de retro, satanas! Never ever call marDirty explicitly!
Trivial fix is t
On 11/05/2015 03:29 PM, Georg Baum wrote:
Vincent van Ravesteijn wrote:
Toggling track_changes does not even mark the document as changed, so
you cannot save it. So, when I'm ready writing and I want my
collaborator to use track changes, I'll have turn on track changes, make a
change, undo the
