Re: [Ãpatch] RandomAccessList take 4

2006-03-22 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | I guess we'll end up with a beautiful version using latest technology | which won't fix the original problem (speed) but would look much nicer | than any pragmatic and working solution. I am not quite sure what high horse you have saddled yourself upon,

Re: [Ãpatch] RandomAccessList take 4

2006-03-22 Thread Juergen Spitzmueller
Abdelrazak Younes wrote: > > (I notice that scrolling the UserGuide is > > quite fluently, as long as no graphics or previews are involved [1]). > > You mean it is better or slower than without the patch? No, it's completely unrelated. I just noticed it while testing the patch. Jürgen

Re: [Ãpatch] RandomAccessList take 4

2006-03-22 Thread Abdelrazak Younes
Juergen Spitzmueller a écrit : Georg Baum wrote: This patch compiles for 1.4 Yes. Compiles, runs and feels good. What specifically should we test for Paragraph insertion/deletion (especially around graphics), Undo/Redo, Cut&Paste inside/outside insets, export*, navigate. Navigating when the

Re: [Ãpatch] RandomAccessList take 4

2006-03-22 Thread Juergen Spitzmueller
Georg Baum wrote: > This patch compiles for 1.4 Yes. Compiles, runs and feels good. What specifically should we test for (I notice that scrolling the UserGuide is quite fluently, as long as no graphics or previews are involved [1]). Jürgen [1] It appears to me that in 1.3, the graphics and prev

Re: [Ãpatch ] RandomAccessList take 4

2006-03-21 Thread Andre Poenitz
On Mon, Mar 20, 2006 at 09:25:09AM +0100, Abdelrazak Younes wrote: > Funny that you are doing the exact same changes as my original patch > fixing the code to use std::distance and std::advance (in this case > boost::next). You rejected my patch exactly because of this... I am not > upset but yo

Re: [Ãpatch] RandomAccessList take 4

2006-03-21 Thread Georg Baum
Lars Gullik Bjønnes wrote: > Georg Baum <[EMAIL PROTECTED]> > writes: > > | The problem were missing conversions of > | > | pars.begin() + x > | > | to > | > | boost::next(pars.begin(), x) > > Where were they missing? In some cut and paste code that does no longer exist in 1.5. BTW my patch

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> Ok, this is what I am going to commit. | | Lars> I am not really happy with the fact that RandomListIterator | Lars> really is a std::list<>::iterator. I'd like it to be a

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Am Montag, 20. März 2006 20:16 schrieb Juergen Spitzmueller: | > Jean-Marc Lasgouttes wrote: | > > Juergen> It does not compile as is (not that I tried too hard). | > > | > > I suspect it works with --disable-concept-checks. | > | > No, it doesn't. I'm try

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Georg Baum
Am Montag, 20. März 2006 20:16 schrieb Juergen Spitzmueller: > Jean-Marc Lasgouttes wrote: > > Juergen> It does not compile as is (not that I tried too hard). > > > > I suspect it works with --disable-concept-checks. > > No, it doesn't. I'm trying with --disable-pch later, but I have to leave now

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Juergen> It does not compile as is (not that I tried too hard). > > I suspect it works with --disable-concept-checks. No, it doesn't. I'm trying with --disable-pch later, but I have to leave now. Jürgen

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hi Lars, | | Funny that you are doing the exact same changes as my original patch | fixing the code to use std::distance and std::advance (in this case | boost::next). You rejected my patch exactly because of this...

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hi Lars, | | Funny that you are doing the exact same changes as my original patch | fixing the code to use std::distance and std::advance (in this case | boost::next). You rejected my patch exactly because of this... If you made the exact same chan

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> I'd be interested to have people test it in 1.4 too. Juergen> It does not compile as is (not that I tried too hard). I suspect it works with --disable-concept-checks. JMarc

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Ok, this is what I am going to commit. Lars> I am not really happy with the fact that RandomListIterator Lars> really is a std::list<>::iterator. I'd like it to be a real Lars> random_access_iterator. We should probably create

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > I'd be interested to have people test it in 1.4 too. It does not compile as is (not that I tried too hard). Jürgen

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Ok, this is what I am going to commit. Lars> I am not really happy with the fact that RandomListIterator Lars> really is a std::list<>::iterator. I'd like it to be a real Lars> random_access_iterator. We should probably create

Re: [Ãpatch] RandomAccessList take 4

2006-03-20 Thread Abdelrazak Younes
Hi Lars, Funny that you are doing the exact same changes as my original patch fixing the code to use std::distance and std::advance (in this case boost::next). You rejected my patch exactly because of this... I am not upset but you could have told me at the beginning instead of letting me was

[Ãpatch] RandomAccessList take 4

2006-03-19 Thread Lars Gullik Bjønnes
Ok, this is what I am going to commit. I am not really happy with the fact that RandomListIterator really is a std::list<>::iterator. I'd like it to be a real random_access_iterator. We should probably create our own. (And no; I don't agree that we should only work with offsets and indices, iter