Re: #9145: LyX crash while accepting a change (reopened)

2014-10-14 Thread Alfredo Braunstein
ok, done. A/ On Tue, Oct 14, 2014 at 5:33 PM, Richard Heck wrote: > On 10/14/2014 11:17 AM, Alfredo Braunstein wrote: >> >> On Tue, Oct 14, 2014 at 8:51 AM, Alfredo Braunstein >> wrote: >>> >>> On Mon, Oct 13, 2014 at 6:27 PM, Jean-Marc Lasgouttes >>> wrote: Le 13/10/2014 18:15, Alfr

Re: #9145: LyX crash while accepting a change (reopened)

2014-10-14 Thread Richard Heck
On 10/14/2014 11:17 AM, Alfredo Braunstein wrote: On Tue, Oct 14, 2014 at 8:51 AM, Alfredo Braunstein wrote: On Mon, Oct 13, 2014 at 6:27 PM, Jean-Marc Lasgouttes wrote: Le 13/10/2014 18:15, Alfredo Braunstein a écrit : The fix however seems bogus to me: -cur.forwardPos()

Re: #9145: LyX crash while accepting a change (reopened)

2014-10-14 Thread Alfredo Braunstein
On Tue, Oct 14, 2014 at 8:51 AM, Alfredo Braunstein wrote: > On Mon, Oct 13, 2014 at 6:27 PM, Jean-Marc Lasgouttes > wrote: >> Le 13/10/2014 18:15, Alfredo Braunstein a écrit : > > The fix however seems bogus to me: > -cur.forwardPos(); > +

Re: #9145: LyX crash while accepting a change (reopened)

2014-10-13 Thread Alfredo Braunstein
On Mon, Oct 13, 2014 at 6:27 PM, Jean-Marc Lasgouttes wrote: > Le 13/10/2014 18:15, Alfredo Braunstein a écrit : The fix however seems bogus to me: >>> >>> >>> -cur.forwardPos(); +cur.top().forwardPos(); >>> >>> >>> >>> Why bogus? Why do you want

Re: #9145: LyX crash while accepting a change (reopened)

2014-10-13 Thread Jean-Marc Lasgouttes
Le 13/10/2014 18:15, Alfredo Braunstein a écrit : The fix however seems bogus to me: -cur.forwardPos(); +cur.top().forwardPos(); Why bogus? Why do you want to revert it? To me it seems wrong (for the reasons explained below). But maybe I don't understand i

Re: #9145: LyX crash while accepting a change (reopened)

2014-10-13 Thread Alfredo Braunstein
On Mon, Oct 13, 2014 at 5:39 PM, Jean-Marc Lasgouttes wrote: > Le 13/10/2014 14:29, Alfredo Braunstein a écrit : >> >> The fix however seems bogus to me: > > >> -cur.forwardPos(); >> +cur.top().forwardPos(); > > > Why bogus? Why do you want to revert it? To me it s

Re: #9145: LyX crash while accepting a change (reopened)

2014-10-13 Thread Jean-Marc Lasgouttes
Le 13/10/2014 14:29, Alfredo Braunstein a écrit : The fix however seems bogus to me: -cur.forwardPos(); +cur.top().forwardPos(); Why bogus? Why do you want to revert it? If you look at the top of the chunk, there is another forwardPos/backwardPos that could

#9145: LyX crash while accepting a change (reopened)

2014-10-13 Thread Alfredo Braunstein
The problem was indeed correctly identified by JM in changeset 7c3d1d7: "The problem is the use of cursor movement methods to update cursor. Cursor::forwardPos() steps into insets, which is not always what we want. The problem here is that there is a math inset just after the accepted change, and