Re: #6133: Undo grouping problem using the lyxfind function

2009-08-17 Thread Pavel Sanda
Tommaso Cucinotta wrote: >> It would have helped me a lot if something was said >> about EmbeddedWorkAreas (I just didn't think about these). >> > Abdel added this new type of work area in order to code within all the > behavioural differences between these small "helper" WAs, and the main > d

Re: #6133: Undo grouping problem using the lyxfind function

2009-08-17 Thread Tommaso Cucinotta
Vincent van Ravesteijn - TNW ha scritto: The first thing I would do is to clarify the comments in GuiView.h. I've been staring at these functions for 10 minutes and then I decided I had no clue what was the difference between currentWorkArea and currentMainWorkArea. currentWorkArea() is the one w

RE: #6133: Undo grouping problem using the lyxfind function

2009-08-17 Thread Vincent van Ravesteijn - TNW
>The real fix that I can think of requires the following >changes: >1) moving awareness of the difference between the currentWorkArea() >[ the one with focus, i.e., document, find, or replace WAs ] and the >currentMainWorkArea() [ the one with the main document being edited ] >from GuiView.cpp (a

Re: #6133: Undo grouping problem using the lyxfind function

2009-08-17 Thread Tommaso Cucinotta
rgheck ha scritto: The real fix that I can think of requires the following changes: 1) moving awareness of the difference between the currentWorkArea() [ the one with focus, i.e., document, find, or replace WAs ] and the currentMainWorkArea() [ the one with the main document being edited ] fro

Re: #6133: Undo grouping problem using the lyxfind function

2009-08-16 Thread rgheck
On 08/16/2009 06:36 PM, Tommaso Cucinotta wrote: LyX Ticket Tracker ha scritto: Comment(by lasgouttes): I think the fix is wrong. The undo group should be created just before a (series of) recordUndo calls and the group should be closed in the end. From the frontend, the changes to the doc

Re: #6133: Undo grouping problem using the lyxfind function

2009-08-16 Thread Tommaso Cucinotta
LyX Ticket Tracker ha scritto: Comment(by lasgouttes): I think the fix is wrong. The undo group should be created just before a (series of) recordUndo calls and the group should be closed in the end. From the frontend, the changes to the document should as much as possible be done through LF