Re: Branches and InsetLayout

Sorry, should be fixed. Riki Thanks for the quick fix! Seems your original patch also works good if we remove default labelstring_ value (from_ascii("UNDEFINED")) in InsetLayout.h. And Customization.lyx also says that default LabelString is "", not "UNDEFINED". Yuriy -- lyx-devel mailing

Re: Branches and InsetLayout

I can easily see someone using "_" in a branch name and then wondering why the InsetLayout doesn't work. Like I did. Pushed. Also fixed the label string issue. Riki Hi Riki, After this update the insets for normal branches (without custom InsetLayout) are shown with label "UNDEFINED". Yuri

Re: [LyX/master] Update ru.po and UserGuide

If previous versions will be left, then there will be duplicated items in menu since these linguistics tables "tableaux" translate just as "tables". So I added these "(ling.)" prefixes to distinguish them. There is also a calque from "tableau" word, but it has different meaning and does not fit h

Re: [LyX/master] Update ru.po and UserGuide

I would like to check with you the changes wrt lib/layouttranslations for PDF outputs. With the current .po version I see two changes (see attachment), which look wrong to me. Wouldn't be more correct to leave it in the previous version without braces? Pavel diff --git a/lib/layouttranslatio

Enable HTTPS access to LyX repo

Hello all, Currently LyX repo can be accessed only with SSH (read-write) and Git (read-only) protocols. Git protocol is obsolete and insecure. It is already disabled on GitHub: https://github.blog/2021-09-01-improving-git-protocol-security-github/ So, I propose to enable HTTPS for read-only

Re: trac & gmail

On 16.06.2023 12:17, Pavel Sanda wrote: On Fri, Jun 16, 2023 at 06:01:48AM -0400, Scott Kostyshak wrote: On Fri, Jun 16, 2023 at 11:52:56AM +0200, Pavel Sanda wrote: On Fri, Jun 16, 2023 at 05:42:08AM -0400, Scott Kostyshak wrote: I'm still using GMail. I don't remember how I set things up th

Re: Can't login or reset password on trac

Dear devs, I can't seem to access the bug reporter. Using my usual login info gives me an "invalid password or username" error. Attempting to restore the passoword results in the mail not being sent. I was just able to log in. I'll privately send you a temporary password. Riki

Re: lyx2lyx error not as informative when opening newer file

And opening such file with non-existing version in LyX (master, Win10) gives that old message: is from a newer version of LyX and the lyx2lyx script failed to convert it. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: lyx2lyx error not as informative when opening newer file

incremending the number in the first line of a .lyx file. Bisect leads to: commit fb7b7e5223bc0a03e5b4a89b15f1be0bc0d05385 Author: Yuriy Skalko Date: Fri Sep 11 00:22:55 2020 +0300 Refactor runCommand Yuriy, do you by chance have time to take a look? If not, no problem

Re: [PATCH] Semantic Linefeeds

.. and please add some note into https://wiki.lyx.org/LyX/NewInLyX24 .. Pavel Thanks for the reminder. Committed and documented. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [PATCH] Semantic Linefeeds

This looks good to me. JMarc Ok, here is an updated patch with dummy format change. Yuriy From 945e020306df7ea595e792284c3e427f32682fb0 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sun, 27 Nov 2022 18:30:26 +0200 Subject: [PATCH] Add "semantic linefeeds" after punctuation

Re: [PATCH] Semantic Linefeeds

I haven't tested, but how does this work when those punctuation symbols are not used to end clauses? For example, in the case of: "e.g., some text..." How many lines would this produce? Scott Just 2 lines. There should be a space to have a linebreak. Yuriy -- lyx-devel mailing list lyx-d

[PATCH] Semantic Linefeeds

Now the patch also contains most punctuation marks for non-European languages after which it is worth to put a linebreak. Is it ready to commit now? Yuriy diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp index 4ce94415f7..7b3d5bd4f7 100644 --- a/src/Paragraph.cpp +++ b/src/Paragraph.cpp @@ -

[PATCH] Semantic Linefeeds

Here is an updated patch with Chinese punctuation marks. Also now linebreak is added after em-dash even without next space (for English). Yuriy diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp index 4ce94415f7..7156d442bf 100644 --- a/src/Paragraph.cpp +++ b/src/Paragraph.cpp @@ -1746,16 +174

Re: Semantic Linefeeds

So from your patch I see that we already did that for '.'? And in this case the \n counts as a space ? I thought our semantics was that \n did not count at all. Yes, it was already done for "." and semantics of \n (ignoring it) is the same here. Space after the "." is still added to the next l

Re: Semantic Linefeeds

On User Guide the difference in file size is ~2%, so yes, it can be called negligible. And after looking through User Guide, I agree with Joel that we can go without minimal line length. Also I exported User Guide to LyX 2.3 format and then successfully opened it in LyX 2.3.6. Yuriy -- lyx-d

Re: Semantic Linefeeds

Thanks all for the feedback! Here is a patch to try. Should we also have minimal line length? Yuriy diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp index 4ce94415f7..61a9e23c61 100644 --- a/src/Paragraph.cpp +++ b/src/Paragraph.cpp @@ -1746,16 +1746,21 @@ void Paragraph::write(ostream & os,

Semantic Linefeeds

Hello all, What do you think about adapting semantic linefeeds (https://rhodesmill.org/brandon/2012/one-sentence-per-line/) for stored paragraph text in LyX files? Mainly to breaks lines only after the punctuation marks. Then the diffs in Git for edited documents can be much more readable.

[Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog

rom ba021353090922642e0e262db9afffd6d47e254c Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Fri, 7 Oct 2022 18:37:53 +0300 Subject: [PATCH] Remove conditional compilation portions for old Qt versions < 4.8 --- src/frontends/qt/FancyLineEdit.cpp | 4 src/frontends/qt/GuiApplication.cpp | 2 -- src/fro

Re: [PATCH] Show branches from master document in branch inset dialog

You can use branchCO->itemData(branchCO->currentIndex()).toString() This works in Qt 4 and upwards. Thanks, Jürgen! This way even dedicated Qt4 users will be able to enjoy this update :) Committed. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listin

[PATCH] Show branches from master document in branch inset dialog

ames. Is is OK to disable this for Qt4 alltogether, as README says that LyX is only compilable on Qt4? Yuriy From 716cc9991d1025614424b7ceaa6761ab0f817083 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Fri, 7 Oct 2022 17:41:46 +0300 Subject: [PATCH] Show branches from master document in branch inset dialog --- src/fro

[PATCH] Show branches from master document in branch inset dialog

fixes this. Yuriy From e46a33c41625bc7ca49df53a8bf14997c318f92d Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 6 Oct 2022 20:24:59 +0300 Subject: [PATCH] Show branches from master document in branch inset dialog --- src/frontends/qt/GuiBranch.cpp | 31 +++ 1 fi

Re: Marking inverted branch insets

Riki, is it OK to have this also in stable? Yuriy ping... -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

LyX 2.4.0

Things got a bit crazy again, but I now should have a bit of time. Where do people think we stand with 2.4.0? I've seen a bit of activity in the interim. Do we need to do one more alpha? Or should we proceed directly to beta 1? What if anything needs to be done before we move to whatever the n

Latex run after toggling search pane

Hello, In current master I'm getting automatic run of latex after toggling Find and replace button on the toolbar. Bisect gives this commit: bca1b63d89e27b. Jürgen, can you check this? Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Marking inverted branch insets

Sounds reasonable to me. Riki Riki, is it OK to have this also in stable? Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Marking inverted branch insets

Sounds reasonable to me. Riki Thanks Riki. So I've committed the patch after updating the docs about this change. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Marking inverted branch insets

Done in the attached patch. Now just with adding "~" to inverted insets, I think it is more visible than "!". Yuriy I've checked implementing the additional color change. But to retain LyX flexibility, just adding the "inverted branch label" color to the table and overriding labelColor metho

Re: [PATCH] Adding LFUN for removing LyX modules

8cc029d13a0a6f44e87ccc71f7a3bc33f7d438ff Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Fri, 22 Oct 2021 23:59:58 +0300 Subject: [PATCH] Add LFUN for removing LyX modules --- src/BufferParams.cpp | 6 ++ src/BufferParams.h | 2 ++ src/BufferView.cpp | 28 +++- src

Re: [PATCH] Adding LFUN for removing LyX modules

uriy From f62034cbd7ed6469f20a2605a965074817e8d270 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Fri, 22 Oct 2021 02:30:06 +0300 Subject: [PATCH] Add LFUN for removing LyX modules --- src/BufferParams.cpp | 12 src/BufferParams.h | 4 src/BufferView.cpp | 19 ++

Re: Marking inverted branch insets

I tried to do something a year ago, and my plan then was to strikeout the branch name. Unfortunately, it is not possible to do now, unless we can set he label as html (didn't try). JMarc There is another way to get strikeout text -- Unicode. I tried it with some copied text from https://ya

[PATCH] Adding LFUN for removing LyX modules

YuriyFrom d9f6b76582f665e7f53e165588ff1d530c330df5 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 21 Oct 2021 18:50:49 +0300 Subject: [PATCH] Add LFUN for removing LyX modules --- src/BufferParams.cpp | 6 ++ src/BufferParams.h | 2 ++ src/BufferView.cpp | 13 + src/FuncCode.h |

Re: Marking inverted branch insets

conditionalizing them this way. Riki Yes, this way LaTeX export result will be closer to LyX source. Yuriy From 1718590f4cc7066ba882a4cffbfc8b5f19cb6dd0 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 21 Oct 2021 12:56:05 +0300 Subject: [PATCH] Mark inverted branch insets --- src/i

Re: Marking inverted branch insets

On 20.10.2021 17:20, Thibaut Cuvelier wrote: On Wed, 20 Oct 2021 at 16:07, Yuriy Skalko <mailto:yuriy.ska...@gmail.com>> wrote: >> Really I'm also thinking about more flexible system -- to connect branch >> insets to branches using logical expression

Re: Marking inverted branch insets

I'm working on the highly variative document that contains many branches frequently changing their states. And it is not very convenient because it is impossible to see immediately if current branch inset is inverted or not. Have you experienced such issue? What do you think about marking inverted

Marking inverted branch insets

Hi all, I'm working on the highly variative document that contains many branches frequently changing their states. And it is not very convenient because it is impossible to see immediately if current branch inset is inverted or not. Have you experienced such issue? What do you think about mark

Re: Patch review

I skipped messages related to `char_type` since that can be defined differently on different systems. The rest should be OK. Yuriy From 04db31562072528a5d5ae05a01b999a3026e208d Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Wed, 29 Sep 2021 12:49:21 +0300 Subject: [PATCH] Remove useless casts

Patch review

From 6e2fb6f86550186881838f7020a1535e4fdffbb7 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Tue, 28 Sep 2021 20:13:42 +0300 Subject: [PATCH] Remove useless casts reported by GCC with -Wuseless-cast option --- src/BiblioInfo.cpp| 2 +- src/Buffer.cpp| 2 +- src/Converte

Re: LatexType values

On 28.07.2021 4:33, Richard Kimberly Heck wrote: On 7/27/21 4:19 PM, Yuriy Skalko wrote: Hello all, When I'm defining simple custom inset (in Local Layout): InsetLayout Flex:BoxInset LyxType   custom LabelString   Box LatexType Para

LatexType values

Hello all, When I'm defining simple custom inset (in Local Layout): InsetLayout Flex:BoxInset LyxType custom LabelString Box LatexType Paragraph DecorationClassic End I'm getting this error: insets/InsetLayout.

Labels from inactive branches

Hi all, I'm working on a document with several branches that have many duplicated labels. Now all these labels are shown in the Cross-reference dialog and it doesn't matter if a branch is active or not (duplicated labels have "DUPLICATE:" prefix). It would be much more convenient to see label

Re: [LyX/master] Reduce the amount of needed boost headers

> By the way, when you are already digging into the internal workings of > preview loader, would it be hard to allow mutliple threads loading > graphics images in backgrounds instead of single one? > Documents with lot of figures take a long time to load fully and most > of nowadays machines have

Re: [PATCH] Set correct Windows console code page since all LyX output is, in UTF-8

Looks reasonable to me. Pavel Thanks, committed. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

[PATCH] Set correct Windows console code page since all LyX output is, in UTF-8

? Yuriy From 56cc76bff7e91ab4dedda0281ae9c4926121b176 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 11 Mar 2021 16:19:44 +0200 Subject: [PATCH] Set correct Windows console code page since all LyX output is in UTF-8 --- src/main.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src

Re: [PATCH] Some fixes

Both look good. Jürgen Thanks for reviewing, committed. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

[PATCH] Some fixes

. Yuriy From bf9914554df866ddc7740f36f98d8a6d8ac5334d Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 18 Feb 2021 15:36:24 +0200 Subject: [PATCH 1/2] Fix setting of math matrix size with mouse --- src/frontends/qt/EmptyTable.cpp | 16 src/frontends/qt/EmptyTable.h | 4

Re: [RFC] Simple Search to Bottom Dock

Dear all I have a patch ready that moves the simple search dialog to the bottom dock widget (see attached screenshot). This solves some long standing UI issues: * https://www.lyx.org/trac/ticket/2625 * https://www.lyx.org/trac/ticket/8054 Most importantly, search is more convenient when using

Re: Use C++ testing framework

Compiles fine. Test is very fast (no options used) Is that the expected output? ... [doctest] doctest version is "2.4.5" [doctest] run with "--help" for options === [doctest] test cases: 14 | 14 passed | 0 f

Re: Use C++ testing framework

I'm all for focusing on 2.4.0 release. So I'll not push yet my commits into newly created branch features/unit-test-adoption. After some time-out I've pushed my work on unit testing into unit-test-adoption branch in features repository. So if you have some free time and are interested, pleas

Re: Insert menu

Also I think marginal notes are too different sorts of notes than the ones in the Notes submenu. Footnotes and marginal notes are part of the document structure, the other notes are more editorial devices (the rather esoteric "gray text", whose purpose I never fully grasped, note might be a hybrid

Re: Insert menu

I would think Marginal Notes could certainly go with notes. But footnotes are so common, at least in academic writing, that I'd be reluctant to move them another keystroke away. Riki But frequent usage of menu for this is not very effective. There is a convenient toolbar button for this. Al

Re: Insert menu

I don't think this is a very good category name. Also I think that these are all sorts of "lists" that can be grouped together. In German, we have the general term "Verzeichnisse" which perfectly fits them all (TOC is "Inhaltsverzeichnis", Bibliography "Literaturverzeichnis", List of Figure "Abb

Re: [PATCH] Patches to review

Thanks for all for reviewing the patches! Patch 1 (the Development.lyx patch) is good. Nice addition of the enum class. Patch 4 also looks good. I thought it could break Qt 4.8 compilation but that's not the case [1, 2]. Sorry that I don't know enough to look at the others. Scott Yes,

ru/UserGuide ctests failing

There are several ru/UserGuide ctests failing on current master, including the default output (pdflatex). Scott That is after my latest patch to it? It was an update in contents of the document, no changes in settings. What are the errors? Yuriy -- lyx-devel mailing list lyx-devel@lists.l

[PATCH] Patches to review

Please review my recent patches for LyX. Yuriy From 9c9fd209149b05d6ec879d1792b9628734ce3ed5 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sun, 10 Jan 2021 13:27:40 +0200 Subject: [PATCH 1/5] Update Development.lyx --- lib/doc/Development.lyx | 99

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

I've tried to reproduce on Linux with Clang and libc++ but cannot. However, one thing that I do not understand is that in the output from ldd, both libstdc++.so.6 and libc++.so.1 show up. See attached. Is this expected? Scott linux-vdso.so.1 (0x7ffd059e5000) libmythes-1.2.so

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

The next step from my side should be clang installation and debugging this patch there. But it can happen not very soon. It happened sooner than I expected. I've got Clang 11 from winlibs.com (it uses libstdc++, unfortunately libc++ is not available here). It compiles LyX on Windows without an

Re: Use C++ testing framework

I'm hoping that people will focus their energies mostly on bug-fixing for the 2.4.0 release. But I understand that that isn't as fun as doing new things. Also, I usually think it's best to get agreement on the framework before launching into a lot of work. But, in this case, I think maybe many of

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Thanks Stephan. It crashes on the call to move(?) assignment operator, but it is still not clear looking on these sources. I haven't tried Valgrind yet. To trigger the crash I picked the second file out of the five files in the lastfiles vector. (But this happens with the first and with the la

Re: [LyX features/InsetParams-refactoring] Refactor decodeInsetParam

These have mostly been posted before, yes? Riki Yes, only the latest three are new. Please review them when you'll have time. I'm finished with it for now. Here is the thread in which I've sent previous patches: https://marc.info/?t=16071855355&r=1&w=2 Yuriy -- lyx-devel mailing list l

[Windows] Remove the default binding between buffer-zoom and Alt+0

However, by default, in LyX, this has a very problematic side-effect: Alt+0 resets the zoom level to zero. Personally, I know how to configure this shortcut, but newcomers may be left puzzled (and leave completely). Moreover, it's more common to use Ctrl+0 to reset the zoom level, at least on Win

Re: Creating a branch in the features repository

But there were some messages about big file. Is it normal? The email is too big. Probably because you are pushing a billion commits. Definitely, there were several thousand commits. So that was just email for mailing list. Thanks for the explanation. I think it is worth to sync master bra

Creating a branch in the features repository

Recently I've created a new branch in the features repository as described here: https://wiki.lyx.org/Devel/LyXGit#toc3 But there were some messages about big file. Is it normal? Here is the Git output: - C:\Projects\LyXGit\lyx>git push features InsetPar

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

OK, now will you commit the replacements? Kornel Please commit them. I don't have patch and only figured out why that call is considered ambiguous by Clang. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Use C++ testing framework

Thanks for continuing this conversation, Yuriy. Scott, thanks for such detailed reply. I'm strongly in favor of a unit testing framework. That said, I just don't think most LyX developers are. I don't know if it's because writing tests is not fun or if the belief is that the time spent to wr

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Maybe '-std=c++17'? AFAIR Scott successfully compiled LyX with -std=c++20 on Clang. Other compiler options also seem usual. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

I used the debugger to bring some light into it. Thanks Stephan. It crashes on the call to move(?) assignment operator, but it is still not clear looking on these sources. I haven't tried Valgrind yet. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/list

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Yes, it helps. Now the next are /usr2/src/lyx/lyx-git/src/graphics/GraphicsCacheItem.cpp:445 /usr2/src/lyx/lyx-git/src/mathed/MathExtern.cpp:602 /usr2/src/lyx/lyx-git/src/mathed/MathExtern.cpp:687 /usr2/src/lyx/lyx-git/src/mathed/MathExtern.cpp:772 /usr2/src

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Should it work w/o -std=c++17? What do expect to happen with different compiler switches for build of Qt-libs and LyX? On GCC it works now with all standards: from C++11 to C++20. The show stopper with -mmacosx-version-min=10.10 is: /Users/stephan/git/lyx/src/insets/ExternalTransforms.cpp:334

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

I cannot even compile everything under clang8 /usr2/src/lyx/lyx-git/src/support/FileMonitor.cpp:62:9: error: call to 'make_unique' is ambiguous return make_unique(instance().getGuard(filename)); ^~~~ /usr/bin/../lib/gcc/x86_64-linux-gnu/8/../../../../include/c+

Re: Use C++ testing framework

I am reluctant ... have you seen, how many tests (in cmake) there already are? Here it gives $ ctest -N | wc 7605 22812 504591 OTOH, more tests cannot hurt. Kornel Yes, I've seen (and really appreciate) that there are many ctests. As I understand these are export tests t

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Sorry, I’ve reverted the change for now locally. I can answer your questions later… Perhaps the compiler flags of the autotools build are of interest (but cmake build crashes either): Configuration Host type: x86_64-apple-darwin18.7.0 Special build flags: build=release

Re: Regular crash in modifying regex

Does not crash for me. Can you produce a backtrace? Jürgen Also cannot reproduce on Windows. It is strange that constification commit breaks the search. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Use C++ testing framework

On 16.12.2020 22:14, Yuriy Skalko wrote: There were already several discussions here in 2013, 2015 and even in 1999 about using some unit testing framework, but without any tangible result. I think it is now time to change this :) There are several widely used frameworks, I've chosen &qu

Re: [PATCH] Add move constructor and move assignment operator for FileName class

Frankly, I am not at ease at all with the way things get updated. I do not understand the Qt mechanisms well enough. If you feel like trying to understand it, please do. Be warn though that we are in a working but fragile situation now, changes will lead to a rough ride but it is probably worth

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Hi Yuriy, I’m seeing a crash after this commit when using File->Open recent. I’m having 5 files in list and the first entry has nullptr as private data. Hi Stephan, Sorry for late answer. Does it crash always on choosing the first file in Recent list? I cannot reproduce this on Windows and L

Re: What Localized Manuals Are Maintained?

> Before I send a note asking for help with the copy-paste stuff, what localized manuals are currently maintained? I.e., for which languages do we need to copy over the new and changed material? As I said yesterday, manuals other than Intro and Tutorial are localized in French, German, J

Re: [PATCH] Add move constructor and move assignment operator for FileName class

Also I noticed that these files are accessed on every keypress (even on navigating document with arrows): lib/images/undo.svgz lib/images/textstyle-apply.svgz lib/images/paste.svgz Is it *really* necessary? It would be because of getStatus, I suspect, though I'm not sure why the files would b

Re: [PATCH] Add move constructor and move assignment operator for FileName class

I don't know enough about this stuff to say much. I think this would be worth doing for 2.4.0, as it will probably provide for some speed as well. Riki Committed at 854c9de. Also I noticed that these files are accessed on every keypress (even on navigating document with arrows): lib/images/

[PATCH] Add move constructor and move assignment operator for FileName class

This should reduce memory allocations for this heavily used class. Yuriy From 15c952108bd6e79a712f159326804a145186b50b Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 7 Jan 2021 02:27:31 +0200 Subject: [PATCH] Add move constructor and move assignment operator for FileName class

Re: Problem with standard regex

> BTW, I tested the regexes with Russian documents, and found an error in > Additional.lyx > Correction attached. Really, that was missed out. Please commit it. Done at c6bc5f0c Thanks. I've tested the regexes (with and without format). Now there are no problems with Cyrillic in any pr

Re: Problem with standard regex

Thanks. I am not so sure that 'from_ascii()' is the better choice comparing to 'from_utf8()' though. Maybe it will be better, but I cannot remember seeing exceptions with `what`-messages not in plain English. Feel free to update. BTW, I tested the regexes with Russian documents, and found an

Re: XML stream writer library

TinyXML2 (https://github.com/leethomason/tinyxml2), pugixml ( https://github.com/zeux/pugixml), and Xerces-C++ ( https://xerces.apache.org/xerces-c/) are only DOM-based. There are quite a few C libraries, like libxml2, that can be SAX-like, but C libraries are horrible to use (http://www.xmlsoft.o

Re: Problem with standard regex

Thanks, you are right. But since the exception may not be only from regex, 'ex.what()' alone feels better. Please commit. Kornel Committed at e8099942c7. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Problem with standard regex

Further investigating shows the error in my own code (out of range access). The following exception was catched in the try {} section in findAdv(), so the only message was: "Invalid regular expression!". This was misleading. Indeed that's not very helpful. Ideally it would say *why* it is not

Re: Compilation error with MSVC 19

> I think the right way will be using only standard-compliant > "__cplusplus" in sources and adding the option "/Zc:__cplusplus" for > MSVC compiler in the build scripts so it handle __cplusplus in > standard-compliant way: > > > https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?v

Re: LyX 2.4.0-alpha1

On Tuesday, December 29, 2020 11:32:39 PM WET José Abílio Matos wrote: > There is just one note in here. > > I tried to compile the code using RHEL 7 that ships with gcc 4.8.5 and > naturally the compilation fails here: > > > insets/InsetListings.cpp: In member function 'virtual void > lyx

Re: Compilation error with MSVC 19

Here is a newer version of the patch that does not use _HAS_CXX17, as it should not really be relied upon ( https://stackoverflow.com/questions/52379233/is-has-cxx17-marco-usable-in-custom-project-headers-to-enable-c17-language). I think the right way will be using only standard-compliant "__cp

Re: Compiling in C++20 mode

I used "-k" instead of "-k0" (my make version does not seem to support "-k0". I get the following errors with GCC: /home/vbox/lyxbuilds/master-clang/repo/src/tex2lyx/Parser.cpp:857:34: error: use of deleted function ‘std::basic_ostream& std::operator<<(std::basic_ostream&, wchar_t) [with

Compilation error with MSVC 19

I just tried to recompile LyX on MSVC 19, this is the error I get: [ 40%] Building CXX object src/frontends/qt/CMakeFiles/frontend_qt.dir/GuiApplication.cpp.obj GuiApplication.cpp D:\LyX\lyx-unstable\3rdparty\nod\nod.hpp(272): error C2653: 'result_of': is not a class or namespace name D:\LyX\lyx

Re: Compiling in C++20 mode

Thanks, Yuriy. I now get the following error with GCC: /home/vbox/lyxbuilds/master-clang/repo/src/Buffer.cpp:1774:27: error: use of deleted function ‘std::basic_ostream& std::operator<<(std::basic_ostream&, wchar_t) [with _Traits = std::char_traits]’ 1774 | oss << "0x" << hex << e.failed_c

Re: [LyX/master] Fix C++20 warning on implicit capture of this via [=]

Hi Yuriy, Apple clang spits this warning now - is it ok? src/frontends/qt/GuiLyXFiles.cpp:200:16: warning: explicit capture of 'this' with a capture default of '=' is a C++2a extension [-Wc++2a-extensions] filesLW, [=, this](){ focusAndHighlight(filesLW); }); These now appea

Re: Compiling in C++20 mode

I'm not sure how this line compiled at all with earlier standards on Linux (where char_type is wchar_t). How wchar_t was outputted into char stream? It produced the integer value before C++20: https://en.cppreference.com/w/cpp/io/basic_ostream/operator_ltlt2 So, the patch attached here should w

Re: Compiling in C++20 mode

Thanks for working on this, Yuriy! I'm not sure if the following is helpful, but curent master fails for me with GCC and Clang with C++20 on Ubuntu 20.10. Here are details in case you or anyone else is motivated to take a look: /home/vbox/lyxbuilds/master-clang/repo/src/mathed/MathParser.cpp:373:

Re: Drop QT4 from master

Could it be that this is why boost::regex was useful after all? Did we rush too fast in our joy of getting rid of it? I do not think that solving issues with crappy compilers involves going all the way in Qt's arms. Qt does have its flaws and bugs, and besides banging our head against the wall

Re: [PATCH] CRC-32 from zlib

Looks like a good idea. Note that we have in our tree zlib 1.2.8; dunno what part of the code is using it, but there have been several bugfix releases since then (currently 1.2.11). Pavel As I see we already have latest 1.2.11 in master branch. So I'm committing the patch. Yuriy -- lyx-deve

Re: Compiling in C++20 mode

++ versions. Yuriy From 2f1c206c72a6eca082f4402b8406cd028c01faf1 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Mon, 28 Dec 2020 20:59:48 +0200 Subject: [PATCH] Fix C++20 warning on implicit capture of this via [=] --- src/frontends/qt/GuiBibtex.cpp | 2 +- src/frontends/qt/GuiCitation.cpp

[PATCH] Update Doxygen options to have more dependency graphs

From 4f38e801eb930ca70b6a086f0aa553e1d19b21a3 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Tue, 22 Dec 2020 12:14:00 +0200 Subject: [PATCH 6/7] Update Doxygen options to have more dependency graphs Now many graphs are not generated due to excessive dependencies (default node limit for one

[PATCH] CRC-32 from zlib

zlib has implementation of crc32 algorithm, I've used it instead of Boost's one. Now another part of Boost can be thrown away :) Yuriy From ec7563f53dc84f80bef4ba067a61d7ec5a9d4bac Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sat, 26 Dec 2020 21:23:44 +0200 Subject: [PATCH 7/7]

Re: InsetParams refactoring

Here is an update to my previous patch. I've separated it into several patches. The next step will be moving `string2params` into InsetParams. Please review these patches. Yuriy From f8a2c8a143bd54cec1da51b611e0a66c4af3305e Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sun, 6 Dec 20

  1   2   3   >