Re: [Patch] Test suite for compare function

2020-11-13 Thread Sam Crawley
On Sat, 14 Nov 2020, at 00:12, Kornel Benko wrote: > Running the test I get: > ... > Can't exec > "/usr2/src/lyx/lyx-git/development/batchtests/bin/compare_custom.pl": > Permission denied at > /BUILD/BUILDMint18/BuildLyxGitQt5.9.5local-gcc8.4.0/lyx_batch.pl > line 195. > ... > > The attached dif

Re: [Patch] Test suite for compare function

2020-11-11 Thread Sam Crawley
On Thu, 12 Nov 2020, at 00:18, Pavel Sanda wrote: > On Wed, Nov 11, 2020 at 09:10:09PM +1300, Sam Crawley wrote: > > > > I'm not sure I understand. When cmd_mode == true (which is always the case > > when run() is invoked via the LFUN), > > Maybe I do not un

Re: [Patch] Test suite for compare function

2020-11-11 Thread Sam Crawley
On Wed, 11 Nov 2020, at 00:31, Pavel Sanda wrote: > So I looked at the code for the command line run at this place looks > good enough. Thanks for having a look. > I have another concerns though: > 1) slotOK contains error() call which seems to be missed now. If you > don't want it for >com

Re: [Patch] Test suite for compare function

2020-11-10 Thread Sam Crawley
I hereby grant permission to license my contributions to LyX under the GNU General Public License, version 2 or any later version. Sam Crawley. On Tue, 10 Nov 2020, at 23:39, Kornel Benko wrote: > Am Sun, 8 Nov 2020 11:32:59 +0100 > schrieb Pavel Sanda : > > > On Sun, Nov 08

Re: [Patch] Test suite for compare function

2020-11-08 Thread Sam Crawley
On Sun, 8 Nov 2020, at 23:32, Pavel Sanda wrote: > Git commit messages tend to have the following structure: first summary line, > empty line and then the details. This helps with log summaries. That is the format I used, unless I'm missing something. The 'subject' line in a git patch file is th

Re: [Patch] Test suite for compare function

2020-11-08 Thread Sam Crawley
On Sun, 8 Nov 2020, at 22:28, Kornel Benko wrote: > Am Sun, 08 Nov 2020 17:14:42 +1300 > schrieb "Sam Crawley" : > ... > > diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in > > index 2d93d27c59..32ef0f974a 100644 > > --- a/lib/scripts/

Re: [Patch] Test suite for compare function

2020-11-08 Thread Sam Crawley
On Mon, 9 Nov 2020, at 01:01, Kornel Benko wrote: > Needed new perl module (Slurp.pm), got from package 'libfile-slurp-perl'. I think this use to be in Perl core, but it's now been taken out. I can easily rewrite if the dependency is a problem.-- lyx-devel mailing list lyx-devel@lists.lyx.org ht