Re: Build script to help bisecting by cherry-picking compiler fixes

2024-11-18 Thread Kornel Benko
Am Mon, 18 Nov 2024 11:52:22 +0100 schrieb Pavel Sanda : > 2) Demands: > a) How long takes one test? (Instead of "many hours" which can drastically > change >with different cpu's can you estimate ratio to e.g. total compilation > time?) > b) Can your test work in parallel manner for 4 or 8 c

Re: Build script to help bisecting by cherry-picking compiler fixes

2024-11-18 Thread Kornel Benko
Am Sun, 17 Nov 2024 12:12:48 +0100 schrieb Scott Kostyshak : ... > The tests take a long time to run (several hours on one CPU). So running the > tests > often would be a considerable amount of cycles/power. Would we run the tests > once per > day? This is OK for OSUOSL? I would personally argue

Enhancement Idea: Combination Horizontal and Vertical Split Screen in Lyx

2024-11-18 Thread Louis Hiener
Good afternoon, I am an embedded systems and signal processing development engineer, and have been using Lyx in my daily work since 2001. I use it both for capturing my daily notes (technical and otherwise), as well as for developing technical documentation. As average screen size has increased,

Re: Build script to help bisecting by cherry-picking compiler fixes

2024-11-18 Thread Pavel Sanda
On Sun, Nov 17, 2024 at 12:12:48PM +0100, Scott Kostyshak wrote: > > Can you describe > > 1) how exactly it works in backgrounds? > > Do you mean backporting? It checks if a certain commit is in the log, and if > not it cherry-picks it. For example: > > if ! git merge-base --is-ancestor "b73ab

Re: Build script to help bisecting by cherry-picking compiler fixes

2024-11-18 Thread Scott Kostyshak
On Mon, Nov 18, 2024 at 11:52:22AM +0100, Pavel Sanda wrote: > On Sun, Nov 17, 2024 at 12:12:48PM +0100, Scott Kostyshak wrote: > > > Can you describe > > > 1) how exactly it works in backgrounds? > > > > Do you mean backporting? It checks if a certain commit is in the log, and > > if not it cher

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
>From my understanding, this is a standard Qt practice but a semi-non-standard C++ practice. On a forum someone said that all files you include should be ".h" or ".hpp" and meson is picky about this. Notable project that use this technique (which should save some compile time) are Qt and SQLite (wh

Re: Missing includes

2024-11-18 Thread Jean-Marc Lasgouttes
Le 18/11/2024 à 16:15, Lorenzo Bertini a écrit : From my understanding, this is a standard Qt practice but a semi-non- standard C++ practice. On a forum someone said that all files you include should be ".h" or ".hpp" and meson is picky about this. Notable project that use this technique (whic

Re: Missing includes

2024-11-18 Thread Jean-Marc Lasgouttes
Le 18/11/2024 à 15:51, Pavel Sanda a écrit : On Mon, Nov 18, 2024 at 02:26:03PM +0100, Lorenzo Bertini wrote: and are named moc_.cpp. They are then included in .cpp with #include "moc_.cpp". Ah, right. P Is this a standard Qt practice? If yes, meson should have some support for it (I see th

Re: Missing includes

2024-11-18 Thread Pavel Sanda
On Mon, Nov 18, 2024 at 02:26:03PM +0100, Lorenzo Bertini wrote: > and are named moc_.cpp. They are then included in .cpp with > #include "moc_.cpp". Ah, right. P -- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
They are the moc generated ones. They are obtained from moc_headers = [ 'Action.h', 'BulletsModule.h', 'CategorizedCombo.h', 'CustomizedWidgets.h', 'DialogView.h', 'DockView.h', 'EmptyTable.h', 'FancyLineEdit.h', 'FindAndReplace.h', 'FloatPlacement.h', 'GuiAbout.h', 'GuiApp

Re: Missing includes

2024-11-18 Thread Pavel Sanda
On Mon, Nov 18, 2024 at 12:36:32PM +0100, Lorenzo Bertini wrote: > Currently, there is no way except hacks to tell meson that some cpp files > are not to be compiled but included. I have opened an issue in their repo. > In the meanwhile let's put the patches on hold. BTW do you have list of these

Re: Missing includes

2024-11-18 Thread Pavel Sanda
nOn Mon, Nov 18, 2024 at 10:04:57AM +0100, Lorenzo Bertini wrote: > I have included everything in the patch. When I look at those errors, the > fix seems like a best practice to me, this is why I'm proposing the > changes. Also, I can't figure how can CMake and Autotools still finish the > build.

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
Currently, there is no way except hacks to tell meson that some cpp files are not to be compiled but included. I have opened an issue in their repo. In the meanwhile let's put the patches on hold. Lorenzo Il giorno lun 18 nov 2024 alle ore 10:47 Lorenzo Bertini < lorenzobertin...@gmail.com> ha sc

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
Sorry, it was Clipboard.h instead of GuiClipboard.h. Moreover, I found that ConsoleApplicationPrivate.h does a forward declaration of ConsoleApplication, but uses one of the methods. This required the full declaration of the class, we may need to include ConsoleApplication.h in there. Also, moc_Gu

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
It has occurred to me that something is wrong with this build because to have multiple definitions of functions, so I must be including things twice, once where I shouldn't. This is probably it. I'll report back once I figure this out. Thanks for the help, Lorenzo Il giorno lun 18 nov 2024 alle o

Re: Missing includes

2024-11-18 Thread Lorenzo Bertini
I'm on GCC 14, Fedora 41. C++ standard is set to C++17. I call it with a meson.build like this: sources = [ 'DockView.cpp', ... ] ui_files = [ 'ui/AboutUi.ui', ... ] moc_headers = [ 'Action.h', ... ] ui_headers = qt_mod.compile_ui(sources: ui_sources) moc_sources = qt_mod.compile_moc(headers: m