I have just pushed 110e654b. I tried to run with the hare and hunt with the
hounds: I'm not using default:, I'm adding runtime warnings in case
something unexpected happens, and I'm always returning a non-problematic
value.
Thibaut Cuvelier
On Tue, 29 Oct 2024 at 20:54, Pavel Sanda wrote:
> On
Thank you for your comments, Riki and JMarc!
> That looks good, but of course, the devil is in the details. Note that you
> can create a new Row element type if this is useful.
Indeed, interaction between completion and preedit strings is a great concern.
For the moment, I judged it would be ok
On Tue, Oct 29, 2024 at 04:22:50PM +, Zhe Tang wrote:
> Hi,
>
> I've been a Lyx user for several years and would like to see continued
> development of the program. Can I register for a new account to submit a bug
> report?
Registered. P
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
ht
On Tue, Oct 29, 2024 at 08:22:29PM +0100, Jean-Marc Lasgouttes wrote:
> I am not sure what you mean, Pavel. Not using default: is better in general.
> We should use it only in cases where the number of enum members is too
> large(for example in dispatch+)).
I thought that we generally do default
Hi,
I've been a Lyx user for several years and would like to see continued
development of the program. Can I register for a new account to submit a bug
report?
Thanks,
Zhe Tang
Sent from my iPhone
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
https://lists.lyx.org/mailman/listinfo/lyx-de
I am not sure what you mean, Pavel. Not using default: is better in general. We
should use it only in cases where the number of enum members is too large(for
example in dispatch+)).
If somebody adds an enum value later, we'll get a warning about it.
JMarc
Le 29 octobre 2024 16:13:25 GMT+01:00
On Tue, Oct 29, 2024 at 01:26:18PM +0100, Thibaut Cuvelier wrote:
> > I think default switch clause with either return "" or some warning should
> > be here?
>
> If I add a default case, I get a warning, because I'm covering all cases. I
> can add a comment tonight.
I think it is safer to accept
On Tue, 29 Oct 2024, 10:36 Pavel Sanda, wrote:
> On Tue, Oct 29, 2024 at 03:31:52AM +, Thibaut Cuvelier wrote:
> > + std::string toMathVariantForMathML3() const
> > + {
> > + // mathvariant is the way MathML 3 encodes fonts.
> > + // Not all combinations are su
On Tue, Oct 29, 2024 at 03:31:52AM +, Thibaut Cuvelier wrote:
> + std::string toMathVariantForMathML3() const
> + {
> + // mathvariant is the way MathML 3 encodes fonts.
> + // Not all combinations are supported. Official list:
> + // https://www.w3.o