Re: ctests failing on current master

2024-09-14 Thread Jürgen Spitzmüller
Am Samstag, dem 14.09.2024 um 19:34 +0200 schrieb Scott Kostyshak: > After cloning the repository, it is 262M. Probably I just need a few > files from there? If so, can you tell me which files? Just this: https://github.com/adobe-fonts/source-han-code-jp/releases/download/2.012R/SourceHanCodeJP.tt

Re: ctests failing on current master

2024-09-14 Thread Scott Kostyshak
On Sat, Sep 14, 2024 at 01:27:38PM GMT, Jürgen Spitzmüller wrote: > Am Mittwoch, dem 11.09.2024 um 17:15 +0200 schrieb Kornel Benko: > > > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > > > toc_pdf4_systemF > > > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > > > toc_pdf5_system

Re: Coverity musings

2024-09-14 Thread Jean-Marc Lasgouttes
Le 14/09/2024 à 15:40, Pavel Sanda a écrit : Can you explain what that construct works? If I understand correctly we are changing the underlying structure and that does not feel right for "search" procedure. Apart from that if we search extensively the memory will grow as well? First, for the f

Re: ctests failing on current master

2024-09-14 Thread Scott Kostyshak
On Sat, Sep 14, 2024 at 02:07:55PM GMT, Jürgen Spitzmüller wrote: > Am Samstag, dem 14.09.2024 um 13:27 +0200 schrieb Jürgen Spitzmüller: > > These, for instance. Here, we need to agree on an appropriate > > typewriter font that supports CJK. > > Source Han Code seems to work well: > https://githu

Re: Coverity musings

2024-09-14 Thread Jean-Marc Lasgouttes
Le 14/09/2024 à 00:43, Richard Kimberly Heck a écrit : Do you have access to coverity? I think I did, but I do not remember how to access it. The password, etc, is probably saved in Firefox, if you just send me the URL. Have a look here. https://scan.coverity.com/projects/4164 You do have a

Re: Coverity musings

2024-09-14 Thread Pavel Sanda
On Fri, Sep 13, 2024 at 05:54:05PM +0200, Jean-Marc Lasgouttes wrote: > * still lots of places where Coverity wants us to use std::move because the > variable that is copied will not be used any more. I tend to think that we > should avoid that and reduce our use of move() to the minimum, unless >

Re: ctests failing on current master

2024-09-14 Thread Jürgen Spitzmüller
Am Samstag, dem 14.09.2024 um 13:27 +0200 schrieb Jürgen Spitzmüller: > These, for instance. Here, we need to agree on an appropriate > typewriter font that supports CJK. Source Han Code seems to work well: https://github.com/adobe-fonts/source-han-code-jp -- Jürgen signature.asc Description:

Re: ctests failing on current master

2024-09-14 Thread Jürgen Spitzmüller
Am Mittwoch, dem 11.09.2024 um 17:15 +0200 schrieb Kornel Benko: > > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > > toc_pdf4_systemF > > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > > toc_pdf5_systemF Should be fixed. Basically appropriate non-TeX fonts needed to be set (as

Re: Coverity musings

2024-09-14 Thread Jürgen Spitzmüller
Am Freitag, dem 13.09.2024 um 17:54 +0200 schrieb Jean-Marc Lasgouttes: > Jürgen, could you please have a look and tell me why we should not do > that? It is too simple, I fear I am missing something. I do not understand if and why that works, but if you say so, I believe you. -- Jürgen -- lyx-

Re: [LyX/master] Do not use rand() to set a BranchList id

2024-09-14 Thread Jürgen Spitzmüller
Am Freitag, dem 13.09.2024 um 11:14 +0200 schrieb Jean-Marc Lasgouttes: > Jürgen, could you double-check this? Makes sense to me. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] use std::move() instead of copying when value is no longer used

2024-09-14 Thread Jean-Marc Lasgouttes
Thanks. I would have done it otherwise. A good time to recall that "premature optimization is the root of all evil." JMarc Le 14 septembre 2024 11:01:03 GMT+02:00, "Jürgen Spitzmüller" a écrit : >Am Dienstag, dem 10.09.2024 um 15:21 +0200 schrieb Jean-Marc >Lasgouttes: >> I agree with that. H

Re: ctests failing on current master

2024-09-14 Thread Jürgen Spitzmüller
Am Mittwoch, dem 11.09.2024 um 18:33 +0200 schrieb Kornel Benko: > > Oh, the Spanish docs are not using > > polyglossia... Is there a sane error > > message? > > > > ?? They pass now here. This is without the polyglossia in git, but > with updated TL24. Maybe also due to my babel options fix. -

Re: ctests failing on current master

2024-09-14 Thread Jürgen Spitzmüller
Am Mittwoch, dem 11.09.2024 um 18:46 +0300 schrieb Udicoudco: > > export/doc/es/Tutorial_dvi3_systemF > > export/doc/es/Tutorial_pdf4_systemF > > export/doc/es/Tutorial_pdf5_systemF > > These ones are compiling fine for me after > a fix from Jürgen at 498135ef383a6e75. > Are you testing with the m

Re: [LyX/master] use std::move() instead of copying when value is no longer used

2024-09-14 Thread Jürgen Spitzmüller
Am Dienstag, dem 10.09.2024 um 15:21 +0200 schrieb Jean-Marc Lasgouttes: > I agree with that. However, I have not found the toggle that tells > Coverity to skip this proposal. This is most of our reports. In any case, I will revert the respective commit. -- Jürgen -- lyx-devel mailing list lyx