Re: Coverity musings

2024-09-13 Thread Richard Kimberly Heck
On 9/13/24 3:53 PM, Jean-Marc Lasgouttes wrote: Le 13/09/2024 à 20:44, Richard Kimberly Heck a écrit : * Places where I understand the program, but am not sure of a proper fix. * Places where I do not even understand what the issue is :( Happy to have a look at some of those. Do you have

Re: Coverity musings

2024-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2024 à 20:44, Richard Kimberly Heck a écrit : * Places where I understand the issue, but fixing requires some work and is a bit scary. Example in the patch below: Jürgen, could you please have a look and tell me why we should not do that? It is too simple, I fear I am missing something

Re: Coverity musings

2024-09-13 Thread Richard Kimberly Heck
On 9/13/24 11:54 AM, Jean-Marc Lasgouttes wrote: So what remains now? * still lots of places where Coverity wants us to use std::move because the variable that is copied will not be used any more. I tend to think that we should avoid that and reduce our use of move() to the minimum, unless pr

Coverity musings

2024-09-13 Thread Jean-Marc Lasgouttes
Hi, So I spent some quality time in front of Coverity and here is the result: since the start of this week, the number of outstanding defects is down from 246 to 87. This is in addition to the 75 identical defects that got killed in one fell swoop last week. How was that done? * fixes, ak

Re: [LyX/master] Do not use rand() to set a BranchList id

2024-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2024 à 11:37, Pavel Sanda a écrit : On Fri, Sep 13, 2024 at 11:14:13AM +0200, Jean-Marc Lasgouttes wrote: Le 13/09/2024 ?? 11:11, Jean-Marc Lasgouttes a écrit : commit 9f40eaee15d53ce418a728d3ff3716541d35775f Author: Jean-Marc Lasgouttes Date: Fri Sep 13 11:07:05 2024 +0200 D

Re: [LyX/master] Do not use rand() to set a BranchList id

2024-09-13 Thread Pavel Sanda
On Fri, Sep 13, 2024 at 11:14:13AM +0200, Jean-Marc Lasgouttes wrote: > Le 13/09/2024 ?? 11:11, Jean-Marc Lasgouttes a écrit : > > commit 9f40eaee15d53ce418a728d3ff3716541d35775f > > Author: Jean-Marc Lasgouttes > > Date: Fri Sep 13 11:07:05 2024 +0200 > > > > Do not use rand() to set a Br

Re: [LyX/master] Do not use rand() to set a BranchList id

2024-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2024 à 11:11, Jean-Marc Lasgouttes a écrit : commit 9f40eaee15d53ce418a728d3ff3716541d35775f Author: Jean-Marc Lasgouttes Date: Fri Sep 13 11:07:05 2024 +0200 Do not use rand() to set a BranchList id Use a simple counting instead, beecause Coverity complains that rand

Re: Registration

2024-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2024 à 10:50, Pavel Sanda a écrit : On Fri, Sep 13, 2024 at 10:44:55AM +0200, Pavel Sanda wrote: On Thu, Sep 12, 2024 at 11:32:55AM +0200, Daniel wrote: Are there any alternatives in the pipe? Not really, but I can improve the description to be more straightforward. Just did that.

Re: Registration

2024-09-13 Thread Pavel Sanda
On Fri, Sep 13, 2024 at 10:44:55AM +0200, Pavel Sanda wrote: > On Thu, Sep 12, 2024 at 11:32:55AM +0200, Daniel wrote: > > Are there any alternatives in the pipe? > > Not really, but I can improve the description to be more straightforward. Just did that. JMarc, am I right that messages from unsu

Re: Registration

2024-09-13 Thread Pavel Sanda
On Thu, Sep 12, 2024 at 11:32:55AM +0200, Daniel wrote: > Are there any alternatives in the pipe? Not really, but I can improve the description to be more straightforward. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel