Re: New warning (or at least I only noticed it now)

2022-11-21 Thread Jean-Marc Lasgouttes
Le 22 novembre 2022 03:04:39 GMT+01:00, Pavel Sanda a écrit : >Nice, so now we know the culprit. The question is whether we want >to get rid of reference on the left side or fix the temps on the right. So what is the issue that the warning detect? I still don't get it. JMarc -- lyx-devel ma

Re: Get rid of the "Let it run" prompt?

2022-11-21 Thread Scott Kostyshak
On Mon, Nov 21, 2022 at 10:29:59PM -0500, Scott Kostyshak wrote: > On Mon, Nov 21, 2022 at 02:50:59PM -0500, Scott Kostyshak wrote: > > On Mon, Nov 21, 2022 at 06:57:59PM +0100, Jürgen Spitzmüller wrote: > > > Am Montag, dem 21.11.2022 um 10:57 -0500 schrieb Scott Kostyshak: > > > > Thanks for the

Re: New warning (or at least I only noticed it now)

2022-11-21 Thread Pavel Sanda
On Tue, Nov 22, 2022 at 01:47:26AM +, José Matos wrote: > On Mon, 2022-11-21 at 23:08 +0100, Pavel Sanda wrote: > > Can you try whether the attached changes anything? P > > It does, now those attached are what remains. Nice, so now we know the culprit. The question is whether we want to get

Re: New warning (or at least I only noticed it now)

2022-11-21 Thread José Matos
On Mon, 2022-11-21 at 23:08 +0100, Pavel Sanda wrote: > Can you try whether the attached changes anything? P It does, now those attached are what remains. -- José Abílio /home/jamatos/lyx/lyx.anon/src/Converter.cpp: In member function ‘lyx::Converters::RetVal lyx::Converters::convert(const lyx:

Re: New warning (or at least I only noticed it now)

2022-11-21 Thread Pavel Sanda
On Mon, Nov 21, 2022 at 09:07:02PM +, José Matos wrote: > I hope that this helps, > -- > José Abílio > /home/jamatos/lyx/lyx.anon/src/BufferView.cpp: In member function ???bool > lyx::BufferView::needsFitCursor() const???: > /home/jamatos/lyx/lyx.anon/src/BufferView.cpp:485:47: warning: poss

Re: New warning (or at least I only noticed it now)

2022-11-21 Thread Pavel Sanda
On Mon, Nov 21, 2022 at 02:07:57PM +0100, Pavel Sanda wrote: > > And it seems to me that addresses are consistently returned, which point to > > an array cell (which s not going away). > > Maybe, I haven't study the code carefully. Can look again in the evening. It seems you are right, I did not

Re: New warning (or at least I only noticed it now)

2022-11-21 Thread José Matos
On Mon, 2022-11-21 at 14:07 +0100, Pavel Sanda wrote: > > Maybe, I haven't study the code carefully. Can look again in the > evening. > > Pavel OK, I send attached all the cases. FWIW this is for an updating the code and the running make (I had compiled yesterday, I think). I hope that this hel

Re: Get rid of the "Let it run" prompt?

2022-11-21 Thread Scott Kostyshak
On Mon, Nov 21, 2022 at 06:57:59PM +0100, Jürgen Spitzmüller wrote: > Am Montag, dem 21.11.2022 um 10:57 -0500 schrieb Scott Kostyshak: > > Thanks for the thoughts, Jürgen and JMarc! > > > > Those are good ideas. I'm not going to work on this for 2.4.0. If > > someone else wants to do it, please g

Re: [PATCH] Allow removing words from the personal dictionary, that weren't previously added

2022-11-21 Thread Jürgen Spitzmüller
Am Montag, dem 21.11.2022 um 18:53 +0100 schrieb Stephan Witt: > Not easy, this would require to rewrite the spell check chunk split > algorithm. > > ATM the complete paragraph is passed to the Apple spell checker at > once. > Obviously it won’t mark the unlearned word as misspelled in this > case

Re: Get rid of the "Let it run" prompt?

2022-11-21 Thread Jürgen Spitzmüller
Am Montag, dem 21.11.2022 um 10:57 -0500 schrieb Scott Kostyshak: > Thanks for the thoughts, Jürgen and JMarc! > > Those are good ideas. I'm not going to work on this for 2.4.0. If > someone else wants to do it, please go ahead. Otherwise, I'll make a > note to look into it for the next major vers

Re: Get rid of the "Let it run" prompt?

2022-11-21 Thread Scott Kostyshak
On Mon, Nov 21, 2022 at 10:13:18AM +0100, Jean-Marc Lasgouttes wrote: > Le 21/11/2022 à 07:14, Jürgen Spitzmüller a écrit : > > I agree we can get rid of the dialog if we make the option to stop > > compilation more visible. > > We could make it more obvious that it is possible to cancel by clicki

Re: #12560: fig2pdftex.py lacks a shebang

2022-11-21 Thread Dr Eberhard W Lisse
Ventura does not have python it only has python3. I think this is even true for Monterey Now however it is called, somehow it must be tested what python version is available and how it wants to be called so that it'll work everywhere and becomes resistant to Apple's misunderimprovements. I sym

Re: Any preference on using braces to restrict scope?

2022-11-21 Thread Pavel Sanda
On Mon, Nov 21, 2022 at 02:54:42PM +0100, Thibaut Cuvelier wrote: > On Mon, 21 Nov 2022 at 10:14, Jean-Marc Lasgouttes > wrote: > > > Le 18/11/2022 ?? 18:43, Thibaut Cuvelier a écrit : > > > You can avoid this level of indentation by defining the variable within > > > the if: > > > > > > if (cons

Re: Any preference on using braces to restrict scope?

2022-11-21 Thread Thibaut Cuvelier
On Mon, 21 Nov 2022 at 10:14, Jean-Marc Lasgouttes wrote: > Le 18/11/2022 à 18:43, Thibaut Cuvelier a écrit : > > You can avoid this level of indentation by defining the variable within > > the if: > > > > if (const vector potential_terms = > > getSubentriesAsText(runparams); !potential_terms.emp

Re: New warning (or at least I only noticed it now)

2022-11-21 Thread Pavel Sanda
On Mon, Nov 21, 2022 at 12:00:59PM +0100, Jean-Marc Lasgouttes wrote: > Le 21/11/2022 ?? 11:17, Pavel Sanda a écrit : > >On Mon, Nov 21, 2022 at 10:09:15AM +0100, Jean-Marc Lasgouttes wrote: > >>I cannot really understand what the destroyed temporary is. > > > >Don't we create and return temp at Gu

Re: New warning (or at least I only noticed it now)

2022-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2022 à 11:17, Pavel Sanda a écrit : On Mon, Nov 21, 2022 at 10:09:15AM +0100, Jean-Marc Lasgouttes wrote: I cannot really understand what the destroyed temporary is. Don't we create and return temp at GuiApplication.cpp:3695 ? If you look above at theFontLoader (GuiApplication.cpp 368

Re: New warning (or at least I only noticed it now)

2022-11-21 Thread Pavel Sanda
On Mon, Nov 21, 2022 at 10:09:15AM +0100, Jean-Marc Lasgouttes wrote: > I cannot really understand what the destroyed temporary is. Don't we create and return temp at GuiApplication.cpp:3695 ? If you look above at theFontLoader (GuiApplication.cpp 3689) we do similar logic but we reserve font_loa

Re: 2.3.7 release

2022-11-21 Thread Jean-Marc Lasgouttes
Le 16/11/2022 à 16:49, Pavel Sanda a écrit : The difference is that --enable-qt5 will do nothing and --disable-qt5 will now be needed to compile with qt4. Ok, if you don't want to kill --enable-qt5 and various -with-qt-* we should be fine. The patch is in now. As you can see, it is pretty tr

Re: Any preference on using braces to restrict scope?

2022-11-21 Thread Jean-Marc Lasgouttes
Le 18/11/2022 à 18:43, Thibaut Cuvelier a écrit : You can avoid this level of indentation by defining the variable within the if: if (const vector potential_terms = getSubentriesAsText(runparams); !potential_terms.empty()) { I don't really like this syntax, because it makes extremely long li

Re: Get rid of the "Let it run" prompt?

2022-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2022 à 07:14, Jürgen Spitzmüller a écrit : I agree we can get rid of the dialog if we make the option to stop compilation more visible. We could make it more obvious that it is possible to cancel by clicking on the spinning progress thing by adding a (red?) 'x' in its center. Or an

Re: New warning (or at least I only noticed it now)

2022-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2022 à 08:34, José Matos a écrit : Hi, I have been compiling and running 2.4 compiled with the latest preview of gcc 13. I got a new warning: "note: the temporary was destroyed at the end of the full expression" Attached follows an example, there are more I can send if they are rele

lyx-devel@lists.lyx.org

2022-11-21 Thread Kornel Benko
Am Sun, 20 Nov 2022 18:06:50 -0500 schrieb Scott Kostyshak : > I made a bash function that makes it easy to search for "let it run" and > it will find "let it &run". > > https://gitlab.com/scottkosty/lyx-tester/-/blob/master/convenience-functions.sh > > Does anyone know of an easier way to do th

Re: State of the killqt4 branch

2022-11-21 Thread Kornel Benko
Am Sun, 20 Nov 2022 21:12:56 +0100 schrieb Jean-Marc Lasgouttes : > Dear all, > > I think I have done everything I can do on the branch (actually I just > noticed a few remnants in config/, I will handle that). > > What remains to be done? Who can help? > > Kornel: there are still trace of Qt4