Re: [patch] Selection stats in statusbar

2022-08-18 Thread Kornel Benko
Am Fri, 19 Aug 2022 07:06:57 +0200 schrieb "Jürgen Spitzmüller" : > Am Donnerstag, dem 18.08.2022 um 18:43 +0200 schrieb Jean-Marc > Lasgouttes: > > Indeed, threads create lots of interesting bugs... It would be better > > if we could avoid them > > The UX difference to the timer approach is h

Re: Failed about 150 export tests

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 17:19 +0200 schrieb Kornel Benko: > Compilation with pdflatex of lib/doc/zh_CN/Tutorial.lyx does not end. > Using lualatex or xelatex is OK though. That's this issue I think: https://tex.stackexchange.com/questions/548139/ Maybe someone should report the bug at ht

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 18:43 +0200 schrieb Jean-Marc Lasgouttes: > Indeed, threads create lots of interesting bugs... It would be better > if we could avoid them The UX difference to the timer approach is huge. The threaded calculation feels smooth and is almost instant. The crash is f

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jean-Marc Lasgouttes
Indeed, threads create lots of interesting bugs... It would be better if we could avoid them JMarc Le 18 août 2022 18:13:38 GMT+02:00, "Jürgen Spitzmüller" a écrit  >Performance is an issue in larger documents (e.g., UserGuide). > >This one, using threads, is snappy and seems to update relia

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 11:42 +0200 schrieb Jürgen Spitzmüller: > The attached seems to work basically. But I haven't check for all > cases (I am dure there are cases I missed) and didn't push hard for > performance (currently the timer is commented out; if this is too > expensive, process

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jean-Marc Lasgouttes
Le 18 août 2022 14:25:28 GMT+02:00, "Jürgen Spitzmüller" a écrit : >> My method: statistics update only when idle for a long enough time >> and only once, hence, cannot interfere with continuous typing and are >> very unlikely to interfere at all. > >And it updated after that timing whether it

Re: Failed about 150 export tests

2022-08-18 Thread Kornel Benko
Am Thu, 18 Aug 2022 10:26:49 -0400 schrieb Scott Kostyshak : > On Thu, Aug 18, 2022 at 08:58:20AM -0400, Scott Kostyshak wrote: > > On Wed, Aug 17, 2022 at 07:43:40PM +0200, Kornel Benko wrote: > > > Am Wed, 17 Aug 2022 18:06:28 +0200 > > > schrieb "Jürgen Spitzmüller" : > > > > > > > Am Mitt

Re: Failed about 150 export tests

2022-08-18 Thread Kornel Benko
Am Thu, 18 Aug 2022 09:10:59 -0400 schrieb Scott Kostyshak : > On Wed, Aug 17, 2022 at 09:05:15AM -0400, Scott Kostyshak wrote: > > On Wed, Aug 17, 2022 at 02:25:57PM +0200, Kornel Benko wrote: > > > Am Wed, 17 Aug 2022 14:04:32 +0200 > > > schrieb "Jürgen Spitzmüller" : > > > > > > > Am Mitt

Re: Failed about 150 export tests

2022-08-18 Thread Scott Kostyshak
On Thu, Aug 18, 2022 at 08:58:20AM -0400, Scott Kostyshak wrote: > On Wed, Aug 17, 2022 at 07:43:40PM +0200, Kornel Benko wrote: > > Am Wed, 17 Aug 2022 18:06:28 +0200 > > schrieb "Jürgen Spitzmüller" : > > > > > Am Mittwoch, dem 17.08.2022 um 09:05 -0400 schrieb Scott Kostyshak: > > > > The Europ

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Daniel
On 18/08/2022 14:25, Jürgen Spitzmüller wrote: Am Donnerstag, dem 18.08.2022 um 14:08 +0200 schrieb Daniel: No function exits early on that approach. The function does not get called in the first place. I think it is really better. Currently: statistics update continuously and, hence, can inter

Re: Failed about 150 export tests

2022-08-18 Thread Scott Kostyshak
On Wed, Aug 17, 2022 at 09:05:15AM -0400, Scott Kostyshak wrote: > On Wed, Aug 17, 2022 at 02:25:57PM +0200, Kornel Benko wrote: > > Am Wed, 17 Aug 2022 14:04:32 +0200 > > schrieb "Jürgen Spitzmüller" : > > > > > Am Mittwoch, dem 17.08.2022 um 13:08 +0200 schrieb Kornel Benko: > > > > Configuring

Re: Failed about 150 export tests

2022-08-18 Thread Scott Kostyshak
On Wed, Aug 17, 2022 at 07:43:40PM +0200, Kornel Benko wrote: > Am Wed, 17 Aug 2022 18:06:28 +0200 > schrieb "Jürgen Spitzmüller" : > > > Am Mittwoch, dem 17.08.2022 um 09:05 -0400 schrieb Scott Kostyshak: > > > The EuropeCV tests are failing because of the following I think: > > > > > >   https:

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 14:08 +0200 schrieb Daniel: > No function exits early on that approach. The function does not get > called in the first place. I think it is really better. > > Currently: statistics update continuously and, hence, can interfere > with continuous typing. Which is

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Daniel
On 18/08/2022 11:44, Jürgen Spitzmüller wrote: Am Donnerstag, dem 18.08.2022 um 11:31 +0200 schrieb Daniel: This shouldn't be an issue. The idea is that statistics are only generated after some time has passed without interruption. They are not shown immediately. Hence, continuous arrow key move

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Scott Kostyshak
On Thu, Aug 18, 2022 at 11:44:49AM +0200, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 18.08.2022 um 11:31 +0200 schrieb Daniel: > > This shouldn't be an issue. The idea is that statistics are only > > generated after some time has passed without interruption. They are > > not > > shown immedia

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 11:31 +0200 schrieb Daniel: > This shouldn't be an issue. The idea is that statistics are only > generated after some time has passed without interruption. They are > not > shown immediately. Hence, continuous arrow key movement would not > trigger statistics at

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 18.08.2022 um 09:55 +0200 schrieb Jürgen Spitzmüller: > You need a more suitable signal that only emits when text is edited > or loaded. The attached seems to work basically. But I haven't check for all cases (I am dure there are cases I missed) and didn't push hard for performa

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Daniel
On 18/08/2022 09:55, Jürgen Spitzmüller wrote: Am Mittwoch, dem 17.08.2022 um 19:40 +0200 schrieb Daniel: What I did in https://www.lyx.org/trac/attachment/ticket/12422/0001-Show-word-count-in-status-bar.patch was just to hook it on GuiView::showMessage() because this would be updated in all c

Re: [patch] Selection stats in statusbar

2022-08-18 Thread Jürgen Spitzmüller
Am Mittwoch, dem 17.08.2022 um 19:40 +0200 schrieb Daniel: > What I did in > > https://www.lyx.org/trac/attachment/ticket/12422/0001-Show-word-count-in-status-bar.patch > > was just to hook it on GuiView::showMessage() because this would be > updated in all cases where text stuff changes.  show