[PATCH] Patches to review

2021-01-20 Thread Yuriy Skalko
Please review my recent patches for LyX. Yuriy From 9c9fd209149b05d6ec879d1792b9628734ce3ed5 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sun, 10 Jan 2021 13:27:40 +0200 Subject: [PATCH 1/5] Update Development.lyx --- lib/doc/Development.lyx | 99 +++--

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-20 Thread Jürgen Spitzmüller
Am Donnerstag, dem 21.01.2021 um 08:10 +0100 schrieb Juergen Spitzmueller: > commit 514cd879702dc946b75a4f688e3c67478a767a56 > Author: Juergen Spitzmueller > Date:   Thu Jan 21 08:09:41 2021 +0100 > >     Prevent branch background color from leaking out of the document >     >     This is assure

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

2021-01-20 Thread Stephan Witt
Am 21.01.2021 um 08:05 schrieb Yuriy Skalko : > >> I've tried to reproduce on Linux with Clang and libc++ but cannot. >> However, one thing that I do not understand is that in the output from >> ldd, both libstdc++.so.6 and libc++.so.1 show up. See attached. Is this >> expected? >> Scott >>

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

2021-01-20 Thread Yuriy Skalko
I've tried to reproduce on Linux with Clang and libc++ but cannot. However, one thing that I do not understand is that in the output from ldd, both libstdc++.so.6 and libc++.so.1 show up. See attached. Is this expected? Scott linux-vdso.so.1 (0x7ffd059e5000) libmythes-1.2.so

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

2021-01-20 Thread Scott Kostyshak
On Wed, Jan 20, 2021 at 07:24:54PM +0100, Jean-Marc Lasgouttes wrote: > Le 20/01/2021 à 18:01, Scott Kostyshak a écrit : > > It took me a while to figure out this was going on, but Kornel helped > > fix things for the bundled Hunspell (even for the bundled Hunspell we > > were trying to link agains

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

2021-01-20 Thread Jean-Marc Lasgouttes
Le 20/01/2021 à 18:01, Scott Kostyshak a écrit : It took me a while to figure out this was going on, but Kornel helped fix things for the bundled Hunspell (even for the bundled Hunspell we were trying to link against the system Hunspell in CMake). I'm planning to search for materials to understan

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

2021-01-20 Thread Scott Kostyshak
On Wed, Jan 20, 2021 at 05:43:08PM +0100, Jean-Marc Lasgouttes wrote: > Le 20/01/2021 à 17:14, Scott Kostyshak a écrit : > > > > I've tried to reproduce on Linux with Clang and libc++ but cannot. > > > > However, one thing that I do not understand is that in the output from > > > > ldd, both libstd

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

2021-01-20 Thread Jean-Marc Lasgouttes
Le 20/01/2021 à 17:14, Scott Kostyshak a écrit : I've tried to reproduce on Linux with Clang and libc++ but cannot. However, one thing that I do not understand is that in the output from ldd, both libstdc++.so.6 and libc++.so.1 show up. See attached. Is this expected? I wonder if that may be a

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

2021-01-20 Thread Scott Kostyshak
On Wed, Jan 20, 2021 at 03:48:45PM +0100, Kornel Benko wrote: > Am Wed, 20 Jan 2021 00:16:49 -0500 > schrieb Scott Kostyshak : > > > On Tue, Jan 19, 2021 at 11:17:25PM +0200, Yuriy Skalko wrote: > > > > The next step from my side should be clang installation and debugging > > > > this patch there.

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

2021-01-20 Thread Kornel Benko
Am Wed, 20 Jan 2021 00:16:49 -0500 schrieb Scott Kostyshak : > On Tue, Jan 19, 2021 at 11:17:25PM +0200, Yuriy Skalko wrote: > > > The next step from my side should be clang installation and debugging > > > this patch there. But it can happen not very soon. > > > > It happened sooner than I exp