DocBook milestone: most tests pass!

Dear list, The latest DocBook commit marks a milestone: almost all tests pass! This means that, for many documents, the DocBook output from LyX is really useable as-is. Many tests are inverted, but it's usually for quite minor details (a few DocBook-validation errors) due to the templates: in thes

Re: Patches to review

On 11/27/20 4:43 PM, Yuriy Skalko wrote: If it really isn't used, then go ahead. Riki Here is patch to remove it + another patches to review. #1, #4, and #5 are all fine. I think #3 is fine, too, but someone who knows more about that code than I do should have a look, too. I suspect #2 i

Re: LyX 2.3.6 Tarballs

On 11/27/20 2:09 PM, Yu Jin wrote: Am Fr., 27. Nov. 2020 um 19:33 Uhr schrieb Pavel Sanda >: On Fri, Nov 27, 2020 at 12:29:32PM -0500, Richard Kimberly Heck wrote: > Are here: > > http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/

Re: Patches to review

If it really isn't used, then go ahead. Riki Here is patch to remove it + another patches to review. Yuriy From a164646e24e8271950d51ccc6d889f860cddff5b Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Fri, 27 Nov 2020 11:09:16 +0200 Subject: [PATCH 1/5] Use range-based loops --- src/graph

Re: LyX 2.3.6 Tarballs

On Friday, November 27, 2020 5:29:32 PM WET Richard Kimberly Heck wrote: > Are here: > > http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/ > > Please let me know if there are any problems, and please prepare > binaries. Thanks, as always, to those who do that work, Stephan, Eugene, > and Enrico, and to a

Re: LyX 2.3.6 Tarballs

On Friday, November 27, 2020 5:29:32 PM WET Richard Kimberly Heck wrote: > Are here: > > http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/ > > Please let me know if there are any problems, and please prepare > binaries. Thanks, as always, to those who do that work, Stephan, Eugene, > and Enrico, and to a

Re: LyX 2.3.6 Tarballs

Am Fr., 27. Nov. 2020 um 19:33 Uhr schrieb Pavel Sanda : > On Fri, Nov 27, 2020 at 12:29:32PM -0500, Richard Kimberly Heck wrote: > > Are here: > > > > http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/ > > > > Please let me know if there are any problems, and please prepare > binaries. > > Thanks, as alwa

Re: LyX 2.3.6 Tarballs

On Fri, Nov 27, 2020 at 12:29:32PM -0500, Richard Kimberly Heck wrote: > Are here: > > http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/ > > Please let me know if there are any problems, and please prepare binaries. > Thanks, as always, to those who do that work, Stephan, Eugene, and Enrico, > and to all

PS 2.3.x is Closed

...until we get confirmation that all is well with the tarballs. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

LyX 2.3.6 Tarballs

Are here: http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/ Please let me know if there are any problems, and please prepare binaries. Thanks, as always, to those who do that work, Stephan, Eugene, and Enrico, and to all those both inside and outside the LyX team who produce RPMs, etc. Riki -- ly

Re: [LyX/master] Fix Clang warning about struct/class mismatch

On Fri, Nov 27, 2020 at 10:31:31AM +0100, Jean-Marc Lasgouttes wrote: > Le 26/11/2020 à 22:39, Scott Kostyshak a écrit : > > Actually I realize I am ignorant on this: why is it preferred to use a > > forward declaration here? i.e., why not the following: > > > > #include "frontends/CaretGeometry.h

Re: Docbook compilation warning

On Fri, 27 Nov 2020 at 12:18, Kornel Benko wrote: > /usr2/src/lyx/lyx-git/src/output_docbook.cpp: In function ‘void > lyx::docbookParagraphs(const lyx::Text&, const lyx::Buffer&, > lyx::XMLStream&, const > lyx::OutputParams&)’: > /usr2/src/lyx/lyx-git/src/output_docbook.cpp:1087:7: warning: varia

Re: ctests: How to protect against tests accidentally being ignored? i.e., ctest -N changing

On Fri, Nov 27, 2020 at 12:56:42AM +0100, Kornel Benko wrote: > Am Thu, 26 Nov 2020 23:55:57 +0100 > schrieb Thibaut Cuvelier : > > > On Thu, 26 Nov 2020 at 22:44, Scott Kostyshak wrote: > > > > > On Thu, Nov 26, 2020 at 07:19:55PM +0100, Kornel Benko wrote: > > > > Am Thu, 26 Nov 2020 19:11:14

Re: [LyX/master] Remove deprecated enum value with Qt5

Le 27/11/2020 à 10:39, José Abílio Matos a écrit : On Friday, November 27, 2020 8:57:52 AM WET Jean-Marc Lasgouttes wrote: In cases like this and in terms of style I prefer to let the most recent option above. Yes, I should have done that. Feel free to change it! JMarc -- lyx-devel mailing li

Re: [LyX/master] Remove deprecated enum value with Qt5

Le 27/11/2020 à 15:26, Richard Kimberly Heck a écrit : On 11/27/20 4:28 AM, Jean-Marc Lasgouttes wrote: Le 27/11/2020 à 09:57, Jean-Marc Lasgouttes a écrit : commit 4b15d64f5172f622ec9747f25635a822aef725d3 Author: Jean-Marc Lasgouttes Date:   Thu Nov 26 20:17:57 2020 +0100 Remove deprec

Re: Patches to review

On 11/27/20 5:35 AM, Yuriy Skalko wrote: >> All the patches are fine. I have only one remark concerning >> Counters::copy. I do not understand why this is a Counters method >> _and_ it receives two Counters instances as parameters. This looks >> like a badly specified method. >> >> >> OTOH, it look

Re: [LyX/master] Remove deprecated enum value with Qt5

On 11/27/20 4:28 AM, Jean-Marc Lasgouttes wrote: > Le 27/11/2020 à 09:57, Jean-Marc Lasgouttes a écrit : >> commit 4b15d64f5172f622ec9747f25635a822aef725d3 >> Author: Jean-Marc Lasgouttes >> Date:   Thu Nov 26 20:17:57 2020 +0100 >> >> Remove deprecated enum value with Qt5 > > Riki, this is u

Docbook compilation warning

/usr2/src/lyx/lyx-git/src/output_docbook.cpp: In function ‘void lyx::docbookParagraphs(const lyx::Text&, const lyx::Buffer&, lyx::XMLStream&, const lyx::OutputParams&)’: /usr2/src/lyx/lyx-git/src/output_docbook.cpp:1087:7: warning: variable ‘currentlyInAppendix’ set but not used [-Wunused-but-set-

Re: [LyX/master] Add default TransformID enum value

Looks good for me. Kornel Autotools looks fine on a first sight, JMarc might have some comment. Pavel Thanks for reviewing. Committed. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Patches to review

All the patches are fine. I have only one remark concerning Counters::copy. I do not understand why this is a Counters method _and_ it receives two Counters instances as parameters. This looks like a badly specified method. OTOH, it looks like it is not used. What about removing it ? JMarc

Re: [LyX/master] Rewrite (again!) the code for caret drawing

Le 26/11/2020 à 19:01, Scott Kostyshak a écrit : I'm guessing this change did not cause the following warning (since Qt::ImMicroFocus was there before), but since you touched the code I bring it up here. When I compile, I get the following warning: /home/scott/lyxbuilds/master/repo/src/frontends

Re: Patches to review

Le 26/11/2020 à 22:07, Yuriy Skalko a écrit : Here are next 5 patches. All the patches are fine. I have only one remark concerning Counters::copy. I do not understand why this is a Counters method _and_ it receives two Counters instances as parameters. This looks like a badly specified metho

Re: [LyX/master] Remove deprecated enum value with Qt5

On Friday, November 27, 2020 8:57:52 AM WET Jean-Marc Lasgouttes wrote: > +#if (QT_VERSION < 0x05) > case Qt::ImMicroFocus: { > +#else > + case Qt::ImCursorRectangle: { > +#endif This remark has nothing to do with your patch. :-) The reason why I am raising this is to ask if we

Re: [LyX/master] Fix Clang warning about struct/class mismatch

Le 26/11/2020 à 22:39, Scott Kostyshak a écrit : Actually I realize I am ignorant on this: why is it preferred to use a forward declaration here? i.e., why not the following: #include "frontends/CaretGeometry.h" Is it because of faster compilation time or because we don't want to include a file

Re: [PATCH] Unification of several types

Le 26/11/2020 à 22:42, Yuriy Skalko a écrit : Ping... Sorry, I did not realize you were still waiting. Go ahead. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] Remove deprecated enum value with Qt5

Le 27/11/2020 à 09:57, Jean-Marc Lasgouttes a écrit : commit 4b15d64f5172f622ec9747f25635a822aef725d3 Author: Jean-Marc Lasgouttes Date: Thu Nov 26 20:17:57 2020 +0100 Remove deprecated enum value with Qt5 Riki, this is useful in branch too. JMarc --- src/frontends/qt/GuiWorkArea.