Re: Changers

I'm not sure about section to add this. Please amend the attached patch. Please commit your version, IMHO the requirements belong to INSTALL/README. Pavel What about specifying also version for Clang? Minimal version with full C++11 support is 3.3 (https://clang.llvm.org/cxx_status.html).

Re: [LyX/master] ctests: fix race condition for parallel testing

On Mon, Nov 16, 2020 at 12:10:14AM +0100, Kornel Benko wrote: > Am Sun, 15 Nov 2020 23:48:55 +0100 > schrieb Kornel Benko : > > > Am Sun, 15 Nov 2020 23:10:48 +0100 (CET) > > schrieb Scott Kostyshak : > > > > > commit dbb72a370aa8117c7dee645b195664115a7b70ed > > > Author: Scott Kostyshak > > > D

Re: [PATCH] Remove old duplicated files, newer are in, autotests/mathmacros

On Sun, Nov 15, 2020 at 06:47:47PM -0500, Richard Kimberly Heck wrote: > On 11/15/20 4:10 PM, Yuriy Skalko wrote: > > I've spotted some duplication in LyX repository related to math > > macros. This patch deletes unneeded files. > > I'm clueless about test stuff. Scott? Kornel? Just from a quick

Re: [PATCH] Remove old duplicated files, newer are in, autotests/mathmacros

On 11/15/20 4:10 PM, Yuriy Skalko wrote: > I've spotted some duplication in LyX repository related to math > macros. This patch deletes unneeded files. I'm clueless about test stuff. Scott? Kornel? Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx

Re: [LyX/master] ctests: fix race condition for parallel testing

Am Sun, 15 Nov 2020 23:48:55 +0100 schrieb Kornel Benko : > Am Sun, 15 Nov 2020 23:10:48 +0100 (CET) > schrieb Scott Kostyshak : > > > commit dbb72a370aa8117c7dee645b195664115a7b70ed > > Author: Scott Kostyshak > > Date: Sun Nov 15 17:40:02 2020 -0500 > > > > ctests: fix race condition fo

Re: [LyX/master] ctests: fix race condition for parallel testing

Am Sun, 15 Nov 2020 23:10:48 +0100 (CET) schrieb Scott Kostyshak : > commit dbb72a370aa8117c7dee645b195664115a7b70ed > Author: Scott Kostyshak > Date: Sun Nov 15 17:40:02 2020 -0500 > > ctests: fix race condition for parallel testing > > The unicode tests would often fail when tes

Re: Changers

On Sun, Nov 15, 2020 at 10:55:17PM +0100, Pavel Sanda wrote: > On Sun, Nov 15, 2020 at 10:49:43PM +0200, Yuriy Skalko wrote: > > I'm not sure about section to add this. Please amend the attached patch. > > Please commit your version, IMHO the requirements belong to INSTALL/README. > Pavel OK wit

Re: Changers

On Sun, Nov 15, 2020 at 10:49:43PM +0200, Yuriy Skalko wrote: > I'm not sure about section to add this. Please amend the attached patch. Please commit your version, IMHO the requirements belong to INSTALL/README. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailma

Re: Changers

On Sun, Nov 15, 2020 at 09:59:57PM +0100, Jean-Marc Lasgouttes wrote: > to work in older gcc versions, I can add them to the autoconf test. I am not > sure that it is worth blocking gcc 4.7 in autoconf. I don't see any need for that. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://

Re: CMake: cofigure failure (Windows)

Am Sun, 15 Nov 2020 22:01:16 +0100 schrieb Yu Jin : > Am So., 15. Nov. 2020 um 21:28 Uhr schrieb Kornel Benko : > > > Am Sun, 15 Nov 2020 20:16:49 +0100 > > schrieb Yu Jin : > > > > > Am So., 15. Nov. 2020 um 20:15 Uhr schrieb Yu Jin : > > > > I agree with CMAKE_PREFIX_PATH. I think that GNUWIN32

[PATCH] Remove old duplicated files, newer are in, autotests/mathmacros

I've spotted some duplication in LyX repository related to math macros. This patch deletes unneeded files. Yuriy From c0aab852629e96dcf202e99737a206783a73a71b Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sun, 15 Nov 2020 22:22:47 +0200 Subject: [PATCH 1/3] Remove old duplicated files, newe

Re: CMake: cofigure failure (Windows)

Am So., 15. Nov. 2020 um 21:28 Uhr schrieb Kornel Benko : > Am Sun, 15 Nov 2020 20:16:49 +0100 > schrieb Yu Jin : > > > Am So., 15. Nov. 2020 um 20:15 Uhr schrieb Yu Jin : > > > I agree with CMAKE_PREFIX_PATH. I think that GNUWIN32_DIR was a good > way > > > of handling that (I assume it was that

Re: Changers

Le 15/11/2020 à 20:53, Scott Kostyshak a écrit : I think that for LyX 2.4 is reasonable to bump at least to gcc 4.8, because 4.7 does not have full support for C++11 yet. I am personally compiling with 4.9, so unless someone trumps me with lower version we should state 4.9 in README. +1 we shou

Re: Changers

I cannot reproduce this in my GCC 7.3 even in C++11 mode (by default it compiles in C++17 with CMake build). Please check if this helps: This helps indeed. Committed. By the way, what is the oldest supported GCC? README says it is GCC 4.7. Is it right? I think that for LyX 2.4 is reasonab

Re: CMake: cofigure failure (Windows)

Am Sun, 15 Nov 2020 20:16:49 +0100 schrieb Yu Jin : > Am So., 15. Nov. 2020 um 20:15 Uhr schrieb Yu Jin : > > > Am So., 15. Nov. 2020 um 18:20 Uhr schrieb Thibaut Cuvelier < > > tcuvel...@lyx.org>: > > > >> On Sun, 15 Nov 2020 at 16:59, Kornel Benko wrote: > >> > >>> Am Sun, 15 Nov 2020 16:47:36

Re: Changers

On Sun, Nov 15, 2020 at 08:41:24PM +0100, Pavel Sanda wrote: > On Sun, Nov 15, 2020 at 06:00:14PM +0200, Yuriy Skalko wrote: > > >Yuriy, > > >this fails on older gccs, could you have a look? > > > > I cannot reproduce this in my GCC 7.3 even in C++11 mode (by default it > > compiles in C++17 with

Re: Changers

On Sun, Nov 15, 2020 at 06:00:14PM +0200, Yuriy Skalko wrote: > >Yuriy, > >this fails on older gccs, could you have a look? > > I cannot reproduce this in my GCC 7.3 even in C++11 mode (by default it > compiles in C++17 with CMake build). Please check if this helps: This helps indeed. > By the w

Re: CMake: cofigure failure (Windows)

Am So., 15. Nov. 2020 um 20:15 Uhr schrieb Yu Jin : > Am So., 15. Nov. 2020 um 18:20 Uhr schrieb Thibaut Cuvelier < > tcuvel...@lyx.org>: > >> On Sun, 15 Nov 2020 at 16:59, Kornel Benko wrote: >> >>> Am Sun, 15 Nov 2020 16:47:36 +0100 >>> schrieb Yu Jin : >>> >>> > Am So., 15. Nov. 2020 um 16:34

Re: CMake: cofigure failure (Windows)

Am So., 15. Nov. 2020 um 18:20 Uhr schrieb Thibaut Cuvelier < tcuvel...@lyx.org>: > On Sun, 15 Nov 2020 at 16:59, Kornel Benko wrote: > >> Am Sun, 15 Nov 2020 16:47:36 +0100 >> schrieb Yu Jin : >> >> > Am So., 15. Nov. 2020 um 16:34 Uhr schrieb Yu Jin : >> > >> > > Am So., 15. Nov. 2020 um 16:03

Re: Changers

On Sun, Nov 15, 2020 at 06:00:14PM +0200, Yuriy Skalko wrote: > > Yuriy, > > this fails on older gccs, could you have a look? > > I cannot reproduce this in my GCC 7.3 even in C++11 mode (by default it > compiles in C++17 with CMake build). Please check if this helps: Just adding another data poi

Re: CMake: cofigure failure (Windows)

On Sun, 15 Nov 2020 at 16:59, Kornel Benko wrote: > Am Sun, 15 Nov 2020 16:47:36 +0100 > schrieb Yu Jin : > > > Am So., 15. Nov. 2020 um 16:34 Uhr schrieb Yu Jin : > > > > > Am So., 15. Nov. 2020 um 16:03 Uhr schrieb Kornel Benko < > kor...@lyx.org>: > > > > > >> Am Sun, 15 Nov 2020 15:08:43 +010

Re: Changers

Yuriy, this fails on older gccs, could you have a look? I cannot reproduce this in my GCC 7.3 even in C++11 mode (by default it compiles in C++17 with CMake build). Please check if this helps: diff --git a/src/support/Changer.h b/src/support/Changer.h index 19a6b9a0cb..4c79052665 100644 ---

Re: CMake: cofigure failure (Windows)

Am Sun, 15 Nov 2020 16:47:36 +0100 schrieb Yu Jin : > Am So., 15. Nov. 2020 um 16:34 Uhr schrieb Yu Jin : > > > Am So., 15. Nov. 2020 um 16:03 Uhr schrieb Kornel Benko : > > > >> Am Sun, 15 Nov 2020 15:08:43 +0100 > >> schrieb Yu Jin : > >> > >> > > You have to investigate the cmake module FomdPe

Re: CMake: cofigure failure (Windows)

Am Sun, 15 Nov 2020 16:34:59 +0100 schrieb Yu Jin : > Am So., 15. Nov. 2020 um 16:03 Uhr schrieb Kornel Benko : > > > Am Sun, 15 Nov 2020 15:08:43 +0100 > > schrieb Yu Jin : > > > > > > You have to investigate the cmake module FomdPerl.cmake. > > > > It may help, if you use HINTS, for instance fo

Re: CMake: cofigure failure (Windows)

Am So., 15. Nov. 2020 um 16:34 Uhr schrieb Yu Jin : > Am So., 15. Nov. 2020 um 16:03 Uhr schrieb Kornel Benko : > >> Am Sun, 15 Nov 2020 15:08:43 +0100 >> schrieb Yu Jin : >> >> > > You have to investigate the cmake module FomdPerl.cmake. >> > > It may help, if you use HINTS, for instance for path

Re: CMake: cofigure failure (Windows)

Am So., 15. Nov. 2020 um 16:03 Uhr schrieb Kornel Benko : > Am Sun, 15 Nov 2020 15:08:43 +0100 > schrieb Yu Jin : > > > > You have to investigate the cmake module FomdPerl.cmake. > > > It may help, if you use HINTS, for instance for path D:\ > > > find_package(Perl REQUIRED PATHS "D:\\

Re: CMake: cofigure failure (Windows)

Am Sun, 15 Nov 2020 15:08:43 +0100 schrieb Yu Jin : > > You have to investigate the cmake module FomdPerl.cmake. > > It may help, if you use HINTS, for instance for path D:\ > >         find_package(Perl REQUIRED PATHS "D:\\") > > > > At least, this one works on linux too. > > > Uhm, ist

Re: CMake: cofigure failure (Windows)

Am So., 15. Nov. 2020 um 12:57 Uhr schrieb Kornel Benko : > Am Sun, 15 Nov 2020 11:32:34 +0100 > schrieb Yu Jin : > > > I can not configure master with CMake currently, it says: > > > > CMake Error at C:/Program > > > Files/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 > >

Re: CMake: cofigure failure (Windows)

Am Sun, 15 Nov 2020 11:32:34 +0100 schrieb Yu Jin : > I can not configure master with CMake currently, it says: > > CMake Error at C:/Program > Files/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 > (message): > Could NOT find Perl (missing: PERL_EXECUTABLE) > Call Stack

CMake: cofigure failure (Windows)

I can not configure master with CMake currently, it says: CMake Error at C:/Program Files/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message): Could NOT find Perl (missing: PERL_EXECUTABLE) Call Stack (most recent call first): C:/Program Files/CMake/share/cmake-3.1

Re: Changers

On Thu, Nov 12, 2020 at 02:21:21PM +0200, Yuriy Skalko wrote: > >I still prefer noChange() or nullChange() to changeNone(), but we would have > >to ask a native English speaker. > > I proposed `changeNone` to have consistent naming for all change`Something` > functions. But noChange is also good.

Re: GPL Statement

On Fri, Nov 13, 2020 at 08:38:15PM -0700, Q wrote: > As requested . > > I hereby grant permission to license my contributions to LyX under the GNU > General Public License, version 2 or any later version. Thanks, I added you to our credits. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: [Patch] Test suite for compare function

On Wed, Nov 11, 2020 at 04:32:57PM +1300, Sam Crawley wrote: > I hereby grant permission to license my contributions to LyX under the GNU > General Public License, version 2 or any later version. Thanks, I added you to credits. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists

Re: [Patch] Test suite for compare function

On Sat, Nov 14, 2020 at 11:28:43AM -0500, Richard Kimberly Heck wrote: > On 11/13/20 8:24 PM, Scott Kostyshak wrote: > > On Sat, Nov 14, 2020 at 01:43:08AM +0100, Kornel Benko wrote: > >> Am Sat, 14 Nov 2020 13:22:39 +1300 > >> schrieb "Sam Crawley" : > >> > >>> On Sat, 14 Nov 2020, at 12:36, Korne