On Thu, 12 Nov 2020, at 00:18, Pavel Sanda wrote:
> On Wed, Nov 11, 2020 at 09:10:09PM +1300, Sam Crawley wrote:
> >
> > I'm not sure I understand. When cmd_mode == true (which is always the case
> > when run() is invoked via the LFUN),
>
> Maybe I do not understand your intentions then. I thoug
On Thu, Nov 12, 2020 at 10:52:35AM +1300, Andrew Parsloe wrote:
> LyX 2.4.0 testing release, windows 10
>
> In the dialogue resulting from Insert > Table, when I drag the cursor
> diagonally from top left, the number of rows and columns generated is about
> two more than the actual cursor position
On Wed, Nov 11, 2020 at 12:25:02PM -0500, Richard Kimberly Heck wrote:
> I'm getting an error trying to export the math manual to PDF. It looks
> similar to:
>
> https://tex.stackexchange.com/questions/249002/error-with-chemgreek
>
> but loading textgreek does not seem to help.
All Math manual t
Le 12/11/2020 à 00:33, Yuriy Skalko a écrit :
Since LyX uses primarily camelCase names, I renamed it to changeNone()
and make_change(ref, val) to changeRef(ref, val). Is it good enough?
I still prefer noChange() or nullChange() to changeNone(), but we would
have to ask a native English speaker
Why not, I like the idea of having everything in the same header. Then I would
rename make_change() to no_change() and even maybe introduce something like
make_change_if(cond, var, value), but I am not sure about this last idea (or
another name like maybe_change or cond_change, or...).
JMarc
LyX 2.4.0 testing release, windows 10
In the dialogue resulting from Insert > Table, when I drag the cursor
diagonally from top left, the number of rows and columns generated is
about two more than the actual cursor position (see the attachment). It
takes some fiddling around to get the desire
On Wed, Nov 11, 2020 at 08:38:01PM +0200, Yuriy Skalko wrote:
> > I did not look at the patch, but I think you should go ahead and commit.
> > What do you think about adding "OUTDATED" to section titles that seem
> > like the information could be old and not relevant?
> >
> > Scott
>
> I've commi
Concerning gprof: please note that it does not take into account the code that
is not instrumented, like Qt, the kernel and maybe parts of the c++ standard
library.
I tend to use perf on linux instead (especially through hotspot, with its
awesome flamegraph feature).
Often I only use my cru
I did not look at the patch, but I think you should go ahead and commit. What
do you think about adding "OUTDATED" to section titles that seem like the
information could be old and not relevant?
Scott
I've committed it. I cannot say that full sections are outdated. There
are places throughou
Le 11/11/2020 à 19:16, Richard Kimberly Heck a écrit :
I really think that we should reduce our use of codes as much as
possible. Isn't it possible to use a virtual method here that would be
implemented by each inset? t is bad to have the knowledge about the
insets scattered around the code.
Le 11/11/2020 à 19:06, Richard Kimberly Heck a écrit :
On 11/11/20 7:00 AM, Yuriy Skalko wrote:
My profiling results are in attached SVG. I've done scrolling
through some of the manuals during profiled run.
What profiler did you use?
I tried to look again at the code, but could not find t
On 11/11/20 12:18 PM, Jean-Marc Lasgouttes wrote:
Le 11/11/2020 à 17:13, Richard Kimberly Heck a écrit :
commit fdd0a6f84923f1d4a1f82457a3e256a2ee706f6b
Author: Richard Kimberly Heck
Date: Wed Nov 11 11:24:59 2020 -0500
Revert "Improve structure of updateMacros"
The problem he
On 11/11/20 7:00 AM, Yuriy Skalko wrote:
My profiling results are in attached SVG. I've done scrolling
through some of the manuals during profiled run.
What profiler did you use?
I tried to look again at the code, but could not find the code that I
believed to create a nested loop and thu
On 11/11/20 12:17 PM, Scott Kostyshak wrote:
On Wed, Nov 11, 2020 at 05:13:51PM +0100, Richard Kimberly Heck wrote:
commit fdd0a6f84923f1d4a1f82457a3e256a2ee706f6b
Author: Richard Kimberly Heck
Date: Wed Nov 11 11:24:59 2020 -0500
Revert "Improve structure of updateMacros"
Th
I've reverted this commit. It's one case where using inset codes gets the wrong
result.
Riki
Thanks for reverting, that branches really should handle not only exact
types of the insets.
Yuriy
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Le 11/11/2020 à 13:08, Yuriy Skalko a écrit :
Now I've found that Changer is just no-op variant of RefChanger.
Their separation into different headers confused me.
Isn't it just some type of abstract base class?
JMarc
Yes, it is base class, but it cannot be abstract because it is used in
I'm getting an error trying to export the math manual to PDF. It looks
similar to:
https://tex.stackexchange.com/questions/249002/error-with-chemgreek
but loading textgreek does not seem to help.
Riki
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx
On Wed, Nov 11, 2020 at 05:13:51PM +0100, Richard Kimberly Heck wrote:
> commit fdd0a6f84923f1d4a1f82457a3e256a2ee706f6b
> Author: Richard Kimberly Heck
> Date: Wed Nov 11 11:24:59 2020 -0500
>
> Revert "Improve structure of updateMacros"
>
> The problem here is that the check agai
On Wed, Nov 11, 2020 at 01:50:45PM +0200, Yuriy Skalko wrote:
> > > P.S. I've tried to search for some docs on Changers in LyX repository and
> > > found this useful document: development/coding/CodingRulesAndAdvice.lyx.
> > > Maybe it will be reasonable to merge it into lib/doc/Development.lyx so
On 11/11/20 9:36 AM, Kornel Benko wrote:
Am Tue, 10 Nov 2020 01:05:12 -0500
schrieb Scott Kostyshak :
On Fri, Nov 06, 2020 at 08:05:10PM +0100, Yuriy Skalko wrote:
commit 5a54ccfa87057fd3220d7193b40ac2dd37a9e6e1
Author: Yuriy Skalko
Date: Wed Nov 4 11:27:08 2020 +0200
Improve structur
Am Tue, 10 Nov 2020 01:05:12 -0500
schrieb Scott Kostyshak :
> On Fri, Nov 06, 2020 at 08:05:10PM +0100, Yuriy Skalko wrote:
> > commit 5a54ccfa87057fd3220d7193b40ac2dd37a9e6e1
> > Author: Yuriy Skalko
> > Date: Wed Nov 4 11:27:08 2020 +0200
> >
> > Improve structure of updateMacros
> > --
Now I've found that Changer is just no-op variant of RefChanger. Their separation into different headers confused me.
Isn't it just some type of abstract base class?
JMarc
Yes, it is base class, but it cannot be abstract because it is used in
client code for no-change cases.
I've tried t
I see that you've tried this, but reverted in 9e7832915f. What were the problems due to this removal?
I do not remember, sorry. Looking at the mail archive did not ring a bell
either.
I've found some info in the ticket you referenced in recent reply to
Riki: https://www.lyx.org/trac/tic
P.S. I've tried to search for some docs on Changers in LyX repository and
found this useful document: development/coding/CodingRulesAndAdvice.lyx.
Maybe it will be reasonable to merge it into lib/doc/Development.lyx so that
developer documentation will be in one place?
+1 probably would need to
On Wed, Nov 11, 2020 at 09:10:09PM +1300, Sam Crawley wrote:
> > 2) It seems that if (!cmd_mode) you will call finished(false) twice
> > thus wrongly
> >reverting the toggles from FuncRequest(LFUN_CHANGES_OUTPUT) in
> > finished(), right?
>
> I'm not sure I understand. When cmd_mode == true
On Wed, 11 Nov 2020, at 00:31, Pavel Sanda wrote:
> So I looked at the code for the command line run at this place looks
> good enough.
Thanks for having a look.
> I have another concerns though:
> 1) slotOK contains error() call which seems to be missed now. If you
> don't want it for
>com
26 matches
Mail list logo
