Re: OutputParams refactoring

2020-11-07 Thread Jean-Marc Lasgouttes
Le 07/11/2020 à 16:52, Yuriy Skalko a écrit : I never understood how it works, but I always assumed it was C++ for grown ups, jut without the lambda function mess. All I can say is that it works :) JMarc That's the most important thing, the rest are implementation details :) Now I've found

Re: ParIterator::operator==

2020-11-07 Thread Jean-Marc Lasgouttes
Le 07/11/2020 à 15:55, Yuriy Skalko a écrit : I'm not a C++ guru, but seems like nothing wrong with this code assuming Dociterator's operator== is right. It can be further simplified to this: bool operator==(ParConstIterator const & iter1, ParConstIterator const & iter2) { DocIterator c

Re: Patches

2020-11-07 Thread Richard Kimberly Heck
On 11/7/20 10:06 AM, Yuriy Skalko wrote: >> Toward that end, I've created a features/cleanup/updateMacros branch >> and committed a very small piece. The first step, for me, is to >> figure out how this stuff works! >> >> Riki > > Should I commit my recent patches into this branch? Sure. > What

Re: OutputParams refactoring

2020-11-07 Thread Yuriy Skalko
I never understood how it works, but I always assumed it was C++ for grown ups, jut without the lambda function mess. All I can say is that it works :) JMarc That's the most important thing, the rest are implementation details :) Now I've found that Changer is just no-op variant of RefChanger

Re: Patches

2020-11-07 Thread Yuriy Skalko
Toward that end, I've created a features/cleanup/updateMacros branch and committed a very small piece. The first step, for me, is to figure out how this stuff works! Riki Should I commit my recent patches into this branch? What is the way LyX project uses for updating feature branches: rebas

Re: ParIterator::operator==

2020-11-07 Thread Yuriy Skalko
This method is commented out ostensibly because the current implementation bool operator==(ParConstIterator const & iter1, ParConstIterator const & iter2) { // FIXME: this makes two full copies! return DocIterator(iter1) == DocIterator(iter2); } made two copies, so was expensive. But w