Re: Refactoring patches

2020-10-19 Thread Pavel Sanda
On Mon, Oct 19, 2020 at 06:27:19PM +0300, Yuriy Skalko wrote: > > Ok, please go on. > > I am interested to see what will be the output of header_check.sh now :) > > > > Pavel > > Done. Please share the result of your check when you'll have it. The current list looks like the attached, most entri

Re: Refactoring patches

2020-10-19 Thread Pavel Sanda
On Tue, Oct 20, 2020 at 12:52:11AM +0300, Yuriy Skalko wrote: I guess you checked, but these two below look strange... Otherwise looks fine. P > diff --git a/src/Buffer.h b/src/Buffer.h > index 2d96ff938e..7d1b5eca97 100644 > --- a/src/Buffer.h > +++ b/src/Buffer.h > @@ -13,6 +13,7 @@ > #define

Re: Refactoring patches

2020-10-19 Thread Richard Kimberly Heck
On 10/19/20 5:52 PM, Yuriy Skalko wrote: The last pass with the assistance from iwyu tool. Assuming it compiles, it looks fine. Using strfwd.h in various places is definitely worth it. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Refactoring patches

2020-10-19 Thread Richard Kimberly Heck
On 10/19/20 5:54 AM, Yuriy Skalko wrote: If I looked at the correct patch (I do not follow this thread very closely), things like int const & should definitely be removed from the sources. If they did compile correctly, then I see no harm in replacing them by 'int' in declarations and 'int con

Re: Refactoring patches

2020-10-19 Thread Yuriy Skalko
The last pass with the assistance from iwyu tool. Yuriy From d115ee3dc78c2d72aa081266654dd15b0f5402dc Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Tue, 20 Oct 2020 00:42:39 +0300 Subject: [PATCH] Clean includes using the output of iwyu tool --- src/Author.h| 2 +- src/Bibl

CMake deb: support "python3 | python2" dependency

2020-10-19 Thread Scott Kostyshak
"make package" is convenient for making a .deb. Currently the .deb depends on the "python" package but in 20.04 it makes things complicated. Does anyone else install LyX with locally built debs? The attached patch seems to work well. Kornel, OK to commit? Scott From abc48258f41fea0d1b72281bcd0d44

Re: Regression while adding unnumbered chapters to ToC?

2020-10-19 Thread Scott Kostyshak
On Mon, Oct 19, 2020 at 06:50:33PM +0200, Günter Milde wrote: > On 18.10.20, Scott Kostyshak wrote: > > On Tue, Sep 29, 2020 at 10:45:11AM -0400, Scott Kostyshak wrote: > > > On Thu, Sep 17, 2020 at 02:11:19PM -0400, Scott Kostyshak wrote: > > > > On Thu, Sep 17, 2020 at 01:51:08PM +0200, Günter Mi

Re: Refactoring patches

2020-10-19 Thread Yuriy Skalko
> Ok, please go on. > I am interested to see what will be the output of header_check.sh now :) > > Pavel Done. Please share the result of your check when you'll have it. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Refactoring patches

2020-10-19 Thread Pavel Sanda
On Mon, Oct 19, 2020 at 05:30:28PM +0300, Yuriy Skalko wrote: > >> Updated patch for cleaning header includes in .cpp files. Is it OK to > >> apply it now? > > > > Does it mean that you're done with the headers :) ? > > Pavel > > Not yet :) I've done with headers after this last patch. If it is O

Re: Refactoring patches

2020-10-19 Thread Yuriy Skalko
>> Updated patch for cleaning header includes in .cpp files. Is it OK to >> apply it now? > > Does it mean that you're done with the headers :) ? > Pavel Not yet :) I've done with headers after this last patch. If it is OK, I'll commit the patch for .cpp after this one. Yuriy From 18e6e2802acd50

Re: Refactoring patches

2020-10-19 Thread Pavel Sanda
On Mon, Oct 19, 2020 at 12:04:24PM +0300, Yuriy Skalko wrote: > >> Yes. We'll deal with the rest later. > >> Pavel > > > > The .cpp changing part (for future applying) is in attached patch. > > Yuriy > > Updated patch for cleaning header includes in .cpp files. Is it OK to > apply it now? Does

Re: Refactoring patches

2020-10-19 Thread Pavel Sanda
On Mon, Oct 19, 2020 at 11:55:10AM +0300, Yuriy Skalko wrote: > > All these look good to me, so please go on. Pavel > > And here is the next update. Nice, good to go. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Refactoring patches

2020-10-19 Thread Yuriy Skalko
> If I looked at the correct patch (I do not follow this thread very closely), > things like int const & should definitely be removed from the sources. If > they did compile correctly, then I see no harm in replacing them by 'int' in > declarations and 'int const' in implementation of non trivia

Re: Refactoring patches

2020-10-19 Thread Jean-Marc Lasgouttes
Le 19/10/2020 à 11:13, Yuriy Skalko a écrit : That all is very interesting :) But what will be the decision? Commit/Add const and commit/Don't commit? If I looked at the correct patch (I do not follow this thread very closely), things like int const & should definitely be removed from the sou

Re: Refactoring patches

2020-10-19 Thread Yuriy Skalko
> I guess it may be useful in some places, I would not make that general. > > If we want to play with const ther eis Ezst Const :) > http://slashslash.info/eastconst/ > > JMarc That all is very interesting :) But what will be the decision? Commit/Add const and commit/Don't commit? Yuriy -- ly

Re: Refactoring patches

2020-10-19 Thread Yuriy Skalko
>> Yes. We'll deal with the rest later. >> Pavel > > The .cpp changing part (for future applying) is in attached patch. > Yuriy Updated patch for cleaning header includes in .cpp files. Is it OK to apply it now? Yuriy From 5dc7e176cf02481f0765149cd81693dd8291341d Mon Sep 17 00:00:00 2001 From:

Re: Refactoring patches

2020-10-19 Thread Yuriy Skalko
> All these look good to me, so please go on. Pavel And here is the next update. Yuriy From 50f4ab1a4e69346df9bc313ec61e8878852215ef Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Mon, 19 Oct 2020 11:51:00 +0300 Subject: [PATCH] Reduce includes in header files --- src/BiblioInfo.h|